Complain about improperly sized tests (#2873)

2024-12-22 03:30:35 +00:00 · 2019-06-30 12:00:22 -04:00 · 2019-06-30 12:00:22 -04:00 · f12fdfda0f
commit f12fdfda0f
parent 72139c41ea
44 changed files with 49 additions and 1 deletions
--- a/.bazelrc
+++ b/.bazelrc
@ -0,0 +1,3 @@
+# Print warnings for tests with inappropriate test size or timeout.
+test --test_verbose_timeout_warnings
+
--- a/.buildkite-bazelrc
+++ b/.buildkite-bazelrc
@ -17,6 +17,9 @@ build:remote-cache --jobs=50
 build:remote-cache --host_platform_remote_properties_override='properties:{name:\"cache-silo-key\" value:\"prysm\"}' 
 build:remote-cache --remote_instance_name=projects/prysmaticlabs/instances/default_instance

+# Import workspace options.
+import %workspace%/.bazelrc
+
 build --experimental_strict_action_env
 build --disk_cache=/tmp/bazelbuilds
 build --experimental_multi_threaded_digest
@ -28,6 +31,5 @@ build --curses=yes --color=yes
 build --keep_going
 build --test_output=errors
 build --flaky_test_attempts=5
-build --test_timeout=5,60,-1,-1
 # Disabled race detection due to unstable test results under constrained environment build kite
 # build --features=race
--- a/beacon-chain/attestation/BUILD.bazel
+++ b/beacon-chain/attestation/BUILD.bazel
@ -29,6 +29,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["service_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/blockchain/BUILD.bazel
+++ b/beacon-chain/blockchain/BUILD.bazel
@ -36,6 +36,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "block_processing_test.go",
        "fork_choice_reorg_test.go",
--- a/beacon-chain/blockchain/stategenerator/BUILD.bazel
+++ b/beacon-chain/blockchain/stategenerator/BUILD.bazel
@ -19,6 +19,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["state_generator_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/chaintest/BUILD.bazel
+++ b/beacon-chain/chaintest/BUILD.bazel
@ -22,6 +22,7 @@ go_binary(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["yaml_test.go"],
    data = glob(["tests/**"]),
    embed = [":go_default_library"],
--- a/beacon-chain/chaintest/backend/BUILD.bazel
+++ b/beacon-chain/chaintest/backend/BUILD.bazel
@ -32,6 +32,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["simulated_backend_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/core/balances/BUILD.bazel
+++ b/beacon-chain/core/balances/BUILD.bazel
@ -16,6 +16,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["rewards_penalties_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/core/blocks/BUILD.bazel
+++ b/beacon-chain/core/blocks/BUILD.bazel
@ -30,6 +30,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "block_operations_test.go",
        "block_test.go",
--- a/beacon-chain/core/epoch/BUILD.bazel
+++ b/beacon-chain/core/epoch/BUILD.bazel
@ -26,6 +26,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "epoch_operations_test.go",
        "epoch_processing_test.go",
--- a/beacon-chain/core/helpers/BUILD.bazel
+++ b/beacon-chain/core/helpers/BUILD.bazel
@ -29,6 +29,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "committee_test.go",
        "deposits_test.go",
--- a/beacon-chain/core/state/BUILD.bazel
+++ b/beacon-chain/core/state/BUILD.bazel
@ -28,6 +28,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "state_test.go",
        "transition_test.go",
--- a/beacon-chain/core/state/stateutils/BUILD.bazel
+++ b/beacon-chain/core/state/stateutils/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["validator_index_map_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/core/validators/BUILD.bazel
+++ b/beacon-chain/core/validators/BUILD.bazel
@ -18,6 +18,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["validator_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/db/BUILD.bazel
+++ b/beacon-chain/db/BUILD.bazel
@ -39,6 +39,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "attestation_test.go",
        "block_operations_test.go",
--- a/beacon-chain/node/BUILD.bazel
+++ b/beacon-chain/node/BUILD.bazel
@ -41,6 +41,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["node_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/powchain/BUILD.bazel
+++ b/beacon-chain/powchain/BUILD.bazel
@ -33,6 +33,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "block_cache_test.go",
        "block_reader_test.go",
--- a/beacon-chain/sync/initial-sync/BUILD.bazel
+++ b/beacon-chain/sync/initial-sync/BUILD.bazel
@ -33,6 +33,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["service_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/beacon-chain/utils/BUILD.bazel
+++ b/beacon-chain/utils/BUILD.bazel
@ -19,6 +19,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "clock_test.go",
        "shuffle_test.go",
--- a/contracts/deposit-contract/BUILD.bazel
+++ b/contracts/deposit-contract/BUILD.bazel
@ -20,6 +20,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["depositContract_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/shared/BUILD.bazel
+++ b/shared/BUILD.bazel
@ -10,6 +10,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["service_registry_test.go"],
    embed = [":go_default_library"],
 )
--- a/shared/bitutil/BUILD.bazel
+++ b/shared/bitutil/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["bit_test.go"],
    embed = [":go_default_library"],
    deps = ["//shared/mathutil:go_default_library"],
--- a/shared/bls/BUILD.bazel
+++ b/shared/bls/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["bls_test.go"],
    embed = [":go_default_library"],
    deps = ["//shared/bytesutil:go_default_library"],
--- a/shared/bls/spectest/BUILD.bazel
+++ b/shared/bls/spectest/BUILD.bazel
@ -17,6 +17,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "aggregate_pubkeys_test.go",
        "aggregate_sigs_test.go",
--- a/shared/bytesutil/BUILD.bazel
+++ b/shared/bytesutil/BUILD.bazel
@ -9,6 +9,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["bytes_test.go"],
    embed = [":go_default_library"],
 )
--- a/shared/cmd/BUILD.bazel
+++ b/shared/cmd/BUILD.bazel
@ -14,6 +14,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["customflags_test.go"],
    embed = [":go_default_library"],
 )
--- a/shared/event/BUILD.bazel
+++ b/shared/event/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "example_feed_test.go",
        "example_scope_test.go",
--- a/shared/featureconfig/BUILD.bazel
+++ b/shared/featureconfig/BUILD.bazel
@ -16,6 +16,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["config_test.go"],
    embed = [":go_default_library"],
    deps = ["@com_github_urfave_cli//:go_default_library"],
--- a/shared/forkutil/BUILD.bazel
+++ b/shared/forkutil/BUILD.bazel
@ -10,6 +10,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["signature_test.go"],
    embed = [":go_default_library"],
    deps = ["//proto/beacon/p2p/v1:go_default_library"],
--- a/shared/hashutil/BUILD.bazel
+++ b/shared/hashutil/BUILD.bazel
@ -18,6 +18,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "beacon_block_test.go",
        "hash_test.go",
--- a/shared/iputils/BUILD.bazel
+++ b/shared/iputils/BUILD.bazel
@ -9,6 +9,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["external_ip_test.go"],
    embed = [":go_default_library"],
    tags = ["requires-network"],
--- a/shared/keystore/BUILD.bazel
+++ b/shared/keystore/BUILD.bazel
@ -25,6 +25,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "deposit_input_test.go",
        "key_test.go",
--- a/shared/mathutil/BUILD.bazel
+++ b/shared/mathutil/BUILD.bazel
@ -9,6 +9,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["math_helper_test.go"],
    embed = [":go_default_library"],
 )
--- a/shared/messagehandler/BUILD.bazel
+++ b/shared/messagehandler/BUILD.bazel
@ -14,6 +14,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["messagehandler_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/shared/p2p/BUILD.bazel
+++ b/shared/p2p/BUILD.bazel
@ -56,6 +56,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "addr_factory_test.go",
        "connection_manager_test.go",
@ -107,6 +108,7 @@ go_test(

 go_test(
    name = "go_norace_test",
+    size = "small",
    srcs = [
        "discovery_norace_test.go",
        "service_norace_test.go",
--- a/shared/p2p/adapter/metric/BUILD.bazel
+++ b/shared/p2p/adapter/metric/BUILD.bazel
@ -15,6 +15,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["metric_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/shared/params/BUILD.bazel
+++ b/shared/params/BUILD.bazel
@ -9,6 +9,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["config_test.go"],
    embed = [":go_default_library"],
 )
--- a/shared/prometheus/BUILD.bazel
+++ b/shared/prometheus/BUILD.bazel
@ -20,6 +20,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "logrus_collector_test.go",
        "service_test.go",
--- a/shared/sliceutil/BUILD.bazel
+++ b/shared/sliceutil/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = [
        "slice_generic_test.go",
        "slice_test.go",
--- a/shared/slotutil/BUILD.bazel
+++ b/shared/slotutil/BUILD.bazel
@ -10,6 +10,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["slotticker_test.go"],
    embed = [":go_default_library"],
    deps = ["//shared/params:go_default_library"],
--- a/shared/trieutil/BUILD.bazel
+++ b/shared/trieutil/BUILD.bazel
@ -13,6 +13,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["sparse_merkle_test.go"],
    embed = [":go_default_library"],
    deps = ["//shared/hashutil:go_default_library"],
--- a/tools/cluster-pk-manager/server/BUILD.bazel
+++ b/tools/cluster-pk-manager/server/BUILD.bazel
@ -52,6 +52,7 @@ go_binary(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["server_test.go"],
    embed = [":go_default_library"],
    deps = ["//proto/cluster:go_default_library"],
--- a/validator/accounts/BUILD.bazel
+++ b/validator/accounts/BUILD.bazel
@ -15,6 +15,7 @@ go_library(

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["account_test.go"],
    embed = [":go_default_library"],
    deps = [
--- a/validator/node/BUILD.bazel
+++ b/validator/node/BUILD.bazel
@ -2,6 +2,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")

 go_test(
    name = "go_default_test",
+    size = "small",
    srcs = ["node_test.go"],
    embed = [":go_default_library"],
    deps = [