Justin Traglia
4c916403e9
Enable dupword linter & fix findings ( #12271 )
...
* Enable dupword linter & fix findings
* Correct an incorrect fix
* Add nolint comment
* Add another nolint comment
* Revert unintended change to bazel version
---------
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
2023-04-18 22:01:27 +00:00
Justin Traglia
b6181f8d1a
Enable nilerr linter & fix findings ( #12270 )
...
* Enable nilerr linter & fix findings
* Deal with other findings
* Fix another finding that I missed somehow
* Fix another another issue
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* Update tests to expect error
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: terencechain <terence@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2023-04-18 20:53:16 +00:00
Justin Traglia
8428a79971
Enable whitespace linter & fix findings ( #12273 )
...
* Enable whitespace linter & fix findings
* Fix new finding
* fix new violation
---------
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
2023-04-18 18:58:27 +00:00
Justin Traglia
9f7711e74a
Enable misspell linter & fix findings ( #12272 )
...
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
2023-04-14 10:03:11 +00:00
Preston Van Loon
4b033f4cc7
Update go to 1.19.3 ( #11630 )
...
* Update go to 1.19.3
* Update other items to 1.19
* Update golangci-lint to latest release
* Run gofmt -s with go1.19
* Huge gofmt changes
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2022-11-18 19:12:19 +00:00
Håvard Anda Estensen
4796827d22
Replace deprecated linter deadcode with unused ( #11334 )
...
* Replace deprecated linter deadcode with unused
* Ignore unused warnings
* Print filename and line number when linting fails
* Fix path
* Remove unused methods
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: terencechain <terence@prysmaticlabs.com>
2022-08-29 12:45:25 -04:00
Raul Jordan
82bbfce524
Use GolangCI-Lint for Goimports Checking Instead of Third-Party Image ( #11246 )
2022-08-17 17:15:08 +00:00
Taranpreet26311
ed07359573
Enable Gofmt Linting via Golang-CI Lint to Allow for Generic Code in Prysm ( #11205 )
...
* converting to generic
* enable gofmt linting
* enable gofmt
Co-authored-by: James He <james@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2022-08-17 13:53:46 +00:00
Jie Hou
56af079aea
Change gocognit complextity threshold to 65 ( #10906 )
...
Co-authored-by: Nishant Das <nishdas93@gmail.com>
2022-06-20 03:57:39 +00:00
Jie Hou
b04dd9fe5c
Enable gocognit linter ( #10867 )
...
* Enable gocognit linter
Currently the gocognit complexity threshold is set to 95 to make
sure no existing files will fail the linter. In future we will
reduce this threshold to a much lower one.
The recommended threshold is usually 30. Our code base has maximum
of 97 right now...But it's better late than never to pay attention
to our code compexity.
* Test to see github complains
* Resume to 97
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2022-06-14 14:19:34 +08:00
frederickalcantara
a170c69653
upgrading linter from gometalinter to golangci-lint ( #2100 )
...
* upgrading linter from gometalinter to golangci-lint
* fixed golangci-lint linting
* removed linting before_script command
* removed disable-all command
* Fixed golang config file
* fixed golang config file v2
* removed gosec issue rule
* formatting
* fixed travis build to run golangci-lint
* Add install golangci-lint command
* fixing golangci-lint script
* removed https://
* Added golangci-lint cmd script
* added go get for local lint install
* created a before_script
* add install before script
* Added get script
* added go mod download
* removed go mod downloads
* changed
* removed before script
* Added before script go get lint
* added exit zero to see what went wrong
* removed golang run script
* removed before script
* change lint command
* verbose output
* removed verbose
* change linter enable and disable configuration
* Update .golangci.yml
Removed gotype as a linter
* Update .golangci.yml
Added typecheck linter
* Update .golangci.yml
Added fixed lint version
* Update .golangci.yml
Added gotype
* Update .golangci.yml
Added typecheck
* removed env:lint
* Added env lint
* fixing lint upgrade
* Changing travis configuration
* FIxed spelling errors
* disabled typecheck
* Enabled typecheck
* remove binary
* Deleting lib binary
* adding more linters
* fixed constants
* fix spelling
* fixed all lint issues
* Revert "Changing travis configuration"
This reverts commit 334afe9d05e96261b01f275aa3ada20e7f36aac4.
* Merge branch 'master' of https://github.com/prysmaticlabs/prysm into update-linter
* Changed from Infof to Info
* Fixing commits
* fixing commits with linter config
* added install
* Fixing
* fix log statement
2019-04-26 14:24:01 +08:00
