kevlu93
eca67cec4c
Embed Config Pattern for Sync Services ( #8636 )
...
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
2021-03-21 19:07:42 +00:00
terence tsao
ce725ceec3
Move state pkg to stateV0 pkg ( #8620 )
...
* Move state pkg to stateV0 pkg
* Build.bazel
* Remove unused RootsArrayHashTreeRoot
* Revert "Remove unused RootsArrayHashTreeRoot"
This reverts commit bf0bda30d1a8eb7a071f6e3ce9ee85041b45aca6.
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-03-17 19:49:49 +00:00
Victor Farazdagi
fa2084330b
Fix race condition in TestService_Initialized ( #8597 )
2021-03-11 21:16:40 +00:00
Victor Farazdagi
fa92766095
Fixes flaky TestBlocksFetcher_nonSkippedSlotAfter test ( #8586 )
...
* Fixes flaky TestBlocksFetcher_nonSkippedSlotAfter test
* fix conditional
2021-03-10 20:03:26 +00:00
Raul Jordan
090fbbf18c
Add Goland Standard "cmd" Pattern for Beacon-Chain Binaries ( #8540 )
...
* beacon chain cmd pattern
* imports spacing
* more import fix
* edit build file
* e2e viz
* amend e2e
2021-03-02 13:36:03 -06:00
Victor Farazdagi
a069738c20
ETH2 Types: Slot ( #8408 )
...
* update shared/params
* update eth2-types deps
* update protobufs
* update shared/*
* fix testutil/state
* update beacon-chain/state
* update beacon-chain/db
* update tests
* fix test
* update beacon-chain/core
* update beacon-chain/blockchain
* update beacon-chain/cache
* beacon-chain/forkchoice
* update beacon-chain/operations
* update beacon-chain/p2p
* update beacon-chain/rpc
* update sync/initial-sync
* update deps
* update deps
* go fmt
* update beacon-chain/sync
* update endtoend/
* bazel build //beacon-chain - works w/o issues
* update slasher code
* udpate tools/
* update validator/
* update fastssz
* fix build
* fix test building
* update tests
* update ethereumapis deps
* fix tests
* update state/stategen
* fix build
* fix test
* add FarFutureSlot
* go imports
* Radek's suggestions
* Ivan's suggestions
* type conversions
* Nishant's suggestions
* add more tests to rpc_send_request
* fix test
* clean up
* fix conflicts
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: nisdas <nishdas93@gmail.com>
2021-02-16 07:45:34 +00:00
Radosław Kapka
0716519be9
Fix error formatting inside fmt.Errorf ( #8439 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-02-12 23:44:46 +00:00
Radosław Kapka
47fdb3b99a
Revert "Rename NewService to New ( #8337 )" ( #8440 )
...
* Revert "Rename `NewService` to `New` (#8337 )"
This reverts commit d121b19145
2021-02-12 17:45:22 +00:00
Victor Farazdagi
a8e501b3cf
ETH2 Types: Epoch ( #8373 )
...
* update deps
* update deps
* update protos/*
* update deps
* reset protos
* update protos
* update shared/params/config
* update protos
* update /shared
* update shared/slotutil and shared/testutil
* update beacon-chain/core/helpers
* updates beacon-chain/state
* update beacon-chain/forkchoice
* update beacon-chain/blockchain
* update beacon-chain/cache
* update beacon-chain/core
* update beacon-chain/db
* update beacon-chain/node
* update beacon-chain/p2p
* update beacon-chain/rpc
* update beacon-chain/sync
* go mod tidy
* make sure that beacon-chain build suceeds
* go fmt
* update e2e tests
* update slasher
* remove redundant alias
* update validator
* gazelle
* fix build errors in unit tests
* go fmt
* update deps
* update fuzz/BUILD.bazel
* fix unit tests
* more unit test fixes
* fix blockchain UTs
* more unit test fixes
2021-02-09 10:05:22 +00:00
Radosław Kapka
86a9d4c6a4
Configurable testutil's BeaconState ( #8407 )
...
* Configurable testutil's BeaconState
* fix shared and fuzz tests
* return state copy
* use mainnet config values for default state
* handle error in block fuzz
* goimports
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2021-02-08 20:00:09 +00:00
Panagiotis Georgiadis
0a180dc662
Make a const instead of 3 'abc' occurences ( #8406 )
2021-02-08 17:08:29 +01:00
Victor Farazdagi
372dc47b64
Deprecate enableSyncBacktracking flag ( #8371 )
...
* Deprecate enableSyncBacktracking flag
* keep deprecated flags
2021-02-01 11:18:24 +00:00
terence tsao
d121b19145
Rename NewService to New ( #8337 )
...
* Hide beacon operation field if it's 0
* Rename NewSerivce to New
* Revert "Hide beacon operation field if it's 0"
This reverts commit 896fa11a0bb605212293d6fff02a8974c54710ab.
* Fix NewServiceRegistry
* Update slasher/detection/service.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-26 10:26:57 +00:00
terence tsao
d5ec248691
Rename getter functions to be idiomatic ( #8320 )
...
* Rename getter functions
* Rename new
* Radek's feedback
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-25 21:27:30 +00:00
terence tsao
9ff825a570
Update variable names that are same as imports ( #8220 )
...
* Fix names that are same as import name
* Review feedbacks
2021-01-07 10:42:03 -06:00
Radosław Kapka
9b3e1eb643
Implement GetHealth in the node API ( #8217 )
...
* Implement GetHealth in the node API
* repair fuzz mock
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2021-01-06 20:11:20 +00:00
Radosław Kapka
392e61fbee
Revert changes to sync service status check ( #8215 )
2021-01-06 11:19:53 +00:00
Radosław Kapka
7135a8542f
Check if initial sync service has been initialized ( #8214 )
2021-01-06 10:45:22 +00:00
Victor Farazdagi
e772e8c8c2
Init sync: minor style fixes ( #8156 )
...
* simplify FSM calls
* improve calculateHeadAndTargetEpochs API
* simplify
* simplify nil assignment
2020-12-18 14:31:15 +00:00
terence tsao
20dede7532
Move state summary cache to DB ( #8101 )
2020-12-16 08:56:21 -08:00
Victor Farazdagi
0f18867f08
Remove duplicate package imports ( #8104 )
...
* remove duplicate imports
* remove unused lookupLimit
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-12-14 22:22:55 +00:00
Steven Allen
2428880058
Update go-libp2p to 0.12.0 ( #8015 )
...
* Update go-libp2p to 0.12.0
go-libp2p 0.12.0 made some significant changes to the stream interfaces around
stream closing:
* Close now closes in both directions and frees the stream. However, unlike
FullClose did, it doesn't _wait_ for the remote peer to respond with an EOF.
* To close for writing, call CloseWrite (like one would on a TCP connection, etc.).
This patch:
* Replaces calls to FullClose with Close where appropriate.
* Replaces calls to Close with CloseWrite where appropriate.
* Removes redundant Close calls.
* Calls Reset to where appropriate to indicate that the request/response was
aborted. Unlike Close, this will not flush and will not cause the remote peer
to read an EOF. Instead, the remote peer will read an ErrReset error.
* Ensures we always either close or reset streams. Send wasn't closing the
stream on some error paths.
* Now that stream closing is async, we explicitly wait for a response when
"hanging up" on a peer (so we don't hang up before they receive our
response/goodbye message).
* update bazel
* Gazelle
* revert unintentional bazel workspace change
* appease an overzealous linter
* update to latest
* Refactor encoder
* gazelle
* Gazelle
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Nishant Das <nishdas93@gmail.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-12-14 17:22:25 +00:00
Victor Farazdagi
b51aec6981
Init sync: minor fixes ( #8060 )
...
* fixes typo
* simplify code
2020-12-07 09:33:06 +00:00
Victor Farazdagi
be078d6a16
Update TestMain(): do not call os.Exit() explicitly ( #8046 )
...
* update workspace
* update testmain
2020-12-04 16:10:07 +00:00
Victor Farazdagi
afbfaedea4
Unskip fixed init-sync service test ( #8042 )
2020-12-04 11:57:46 +00:00
Victor Farazdagi
647b4cf108
Round robin: half open interval in syncToFinalizedEpoch ( #8039 )
2020-12-03 21:55:42 +00:00
Victor Farazdagi
7dd0c24fea
Skip bogus init-sync test ( #8038 )
2020-12-03 20:20:04 +00:00
Victor Farazdagi
3092f75ec2
Init sync: conditional syncing to finalized slot ( #7999 )
...
* extract sync methods
* add unit test
* gazelle
* Update beacon-chain/sync/initial-sync/round_robin.go
Co-authored-by: Shay Zluf <thezluf@gmail.com>
* better set back step
Co-authored-by: Shay Zluf <thezluf@gmail.com>
2020-12-03 14:10:51 +00:00
Victor Farazdagi
5417e8cf31
Init-sync: enable peer scorer by default ( #7974 )
...
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-12-03 00:45:20 +00:00
Victor Farazdagi
c7f7a29d7e
remove redundant start slot ( #7991 )
...
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-12-02 20:47:39 +03:00
Potuz
9a1423d62d
Log with field error instead of err ( #7998 )
2020-12-01 05:38:42 -08:00
Victor Farazdagi
54a42ce4a8
more robust processing of invalid head slot ( #7990 )
2020-11-29 15:03:25 -06:00
Victor Farazdagi
f361450e8d
Update TestMain() to use os.Exit() ( #7814 )
...
* update TestMain
* fix sync/initial-sync test
* restore code in rate limiter
* fix rate_limiter tests
2020-11-13 18:28:14 -08:00
Raul Jordan
4290ba416c
Fix Prysm Runtime Data Races ( #7770 )
...
* handle state trie data races
* race fixes
* added proper locks
* fix gaz
* use thread-safe refs() function
2020-11-10 20:57:07 -06:00
Victor Farazdagi
09e3f0360e
Remove redundant calls to os.exit() in TestMain ( #7761 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-10 14:56:47 +00:00
Victor Farazdagi
51796d77f6
Init-sync: backtracking to alternative forks ( #7564 )
...
* cherry-pick from previous commits
* use finalized checpoint instead of head slot
* add helpers
* add dedicated error for missing blocks
* add backtracking options to fetcher
* TestBlocksFetcher_alternativeSlotBefore regression test
* update peer block provider test
* update injected deps
* update round robing deps
* update fetcher
* patch status and stream handlers
* test template
* gazelle
* revert BestNonFinalized changes
* extract waitForBandwidth method
* extend test
* remove redundant code
* add flag
* update queue
* update thresholds
* upd inequality
* minor cleanup
* check for mode
* add backtracking queue test
* merge from master
* remove redundant test
* correct logging level
* fix tests
* remove test template
* Nishant's suggestion to parametrize magic number
2020-11-06 15:54:20 +00:00
Victor Farazdagi
6e21b7a623
Add one more assertion to fetcher test ( #7733 )
2020-11-05 19:48:49 +00:00
Victor Farazdagi
f6cbfd5e27
Init-sync fetcher: backtracking ( #7704 )
...
* fetcher: backtracking
* gazelle
* amend comments
* cleanup
* cleanup
* minor fixes
* simplify
* remove unrelevant test
* add TestBlocksFetcher_findAncestor
* more tests
* Address Nishant's feedback
* optimize backtracking
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-05 07:27:46 +00:00
Victor Farazdagi
c5a8363998
Remove redundant error return from filterPeers() ( #7730 )
2020-11-04 23:29:50 +00:00
Victor Farazdagi
7acd73e1fe
Refactor p2p requests: extract BeaconBlocksByRangeRequest and BeaconBlocksByRootRequest ( #7718 )
...
* extract SendBeaconBlocksByRangeRequest
* adds extra processing
* extract SendBeaconBlocksByRootRequest
* extract into rpc_send_request.go
* add tests
* more tests
* gazelle
* remove redundant import
* for consistency
* for consistency
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-04 20:09:19 +00:00
Victor Farazdagi
926d3b9b34
Init-sync: more tests + minor refactoring ( #7692 )
...
* cherry-pick commits
* re-arrange calls
2020-10-31 21:33:57 +00:00
Nishant Das
df762bbfee
cleaner logging ( #7689 )
2020-10-31 19:10:08 +08:00
Victor Farazdagi
4fc0a50569
Turn init-sync FSM logs to trace level ( #7670 )
...
* trace
* go fmt
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2020-10-29 04:55:07 +00:00
Preston Van Loon
fcbb168c76
Code health: review map usage ( #7635 )
...
* remove unused cache states map
* correct typo
* Remove unused array
* Add lock around deposits cache chainstart pubkeys
* Copy attestation before grabbing lock. This may reduce lock contention time as other callers wanting the lock do not need to wait as long for the lock to become available.
* Copy attestation before grabbing lock. This may reduce lock contention time as other callers wanting the lock do not need to wait as long for the lock to become available.
* Set capacity to 1 since it is known that the slice will be 1 after insertion
* require validatorSlashingPreconditionCheck caller to hold lock
* Add lock for voluntary exits pool HasBeenIncluded
* Require rate limiter retrieveCollector to hold lock
* Add lock requirement assertions in sync
* Remove unused struct
* remove ClearCachedStates API
* field initSyncState is unused
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-10-26 21:17:07 +00:00
Victor Farazdagi
e6d688f6d5
Init-sync: re-arrange tests ( #7641 )
...
* move tests
* formatting
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-26 08:54:06 +00:00
Victor Farazdagi
8a3b75e9e3
Update init-sync FSM ( #7640 )
...
* update fsm
* more tests
2020-10-26 05:26:35 +00:00
Radosław Kapka
7e2112b4ba
Fix panic issues on beacon node shutdown ( #7625 )
...
* allow service cleanup on node shutdown
* revert error to fatal
* remove unused struct field
2020-10-23 12:43:48 +00:00
Victor Farazdagi
0b53a89d00
More verbose output on init-sync ( #7578 )
...
* more verbose output on init-sync
* log slot
* no error stack
* remove redundant data
* less verbose
2020-10-20 14:59:38 +00:00
terence tsao
7076a1ec4a
More feature flag deletions ( #7533 )
...
* Delete disable state lock and init sync verbose flags
* Delete disable slashing broadcast
* Remove disable wait for sync, noise, eth1 cache, static subnet
* Remove enable broadcast recovery attemp and make it as default
* Remove disable head update on per attestation
* Revert disable att braodcast discovery attempt
* gazelle
* Fixed an anti pattern
* Add enableAttBroadcastDiscoveryAttempts back
* Add back WaitForSync
* Remove extra lines
* Use DisableDynamicCommitteeSubnets path per @prestonvanloon feedback
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-14 23:28:49 +00:00
Victor Farazdagi
a005c77b3f
Update error usage patterns to go1.13+ ( #7529 )
...
* rely on errors.Is
* wrap errors
2020-10-14 17:39:52 +00:00
