terence tsao
3aaa98decf
Next slot state caching ( #8357 )
...
* Add and use trailing slot state cache
* Remove comment
* Update comments
* Update comments
* Move it to background
* Warn is more appropiate
* Raul's comment
* Same strategy for proposer
* Own helper
* Minor touchups
* Tests
* Feature flag
* Gaz
2021-01-29 16:52:43 +00:00
terence tsao
d5ec248691
Rename getter functions to be idiomatic ( #8320 )
...
* Rename getter functions
* Rename new
* Radek's feedback
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-25 21:27:30 +00:00
Radosław Kapka
7842fd9da6
Replace bytes.Equal with assert.DeepEqual in tests ( #8318 )
...
* beacon chain
* format imports
* Update beacon-chain/db/kv/migration_archived_index_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/db/kv/migration_block_slot_index_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* remove unused imports
* Update beacon-chain/core/state/skip_slot_cache_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/core/state/skip_slot_cache_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/core/state/skip_slot_cache_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/core/state/skip_slot_cache_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/db/kv/migration_archived_index_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
* Update beacon-chain/db/kv/migration_block_slot_index_test.go
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
2021-01-22 15:15:40 +00:00
Preston Van Loon
33e266388f
GetDuties: Refactor assignment status to deduplicate status computation ( #8313 )
2021-01-21 14:22:05 -08:00
terence tsao
5d841874f7
Return error on AttestingIndices bitfield length check ( #8285 )
...
* Return error on committee len check
* AttestingIndices unit test
* Add equality check
* Fixing more tests
* Fix rest of the tests
* Fix invalid bit length test
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-20 03:00:52 +00:00
Radosław Kapka
f89fd67952
Better receiver names in beacon chain module ( #8286 )
2021-01-19 13:21:32 +00:00
terence tsao
daf6da5beb
Add hydrate indexed att test helper ( #8261 )
...
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2021-01-13 22:05:57 +00:00
terence tsao
eeda9f18fe
Disallow duties request where req.Epoch > current.Epoch+1 ( #8252 )
...
* Disallow request epoch to be out of bound
* Input Slot and epoch checks
* Tests
* Review feedbacks
* Unavailable error code
* Rename genesis time fetcher to time fetcher
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-12 23:27:37 +00:00
Radosław Kapka
5fd03f8fb0
Unify the pattern of using a package-level logger ( #8245 )
...
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2021-01-11 20:03:28 +00:00
terence tsao
9a1866b735
Hydrate header test helper ( #8234 )
...
* Hydrate headers and fix tests
* Gazelle
* Fix a slashing test
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
2021-01-09 16:45:45 +00:00
terence tsao
bc650c82b4
Hydrate attestation for tests ( #8228 )
2021-01-07 21:00:21 +00:00
Victor Farazdagi
04b2e0776d
Fix import shadowing of state package ( #8191 )
...
* update shadowed var name
* update var names
* remove unnecessary delta
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2021-01-04 20:07:12 +00:00
Victor Farazdagi
f038d782c2
Fix issue with custom chain/network ID configuration ( #8147 )
...
* move chain/network id to beacon config
* go fmt
* improve tests
* validator params
* update deposit contract address
* complete tests
* re-arrange comments
* Less mis-leading comment, per Terence's review
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-12-18 22:22:48 +00:00
Nishant Das
e2d7ec6f97
Refactor Method Signatures For Powchain ( #8110 )
...
* checkpoint
* fix tests
* fix visibility
* fix
* victor's review
* remove redundant LF
* remove redundant LF
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
2020-12-17 12:33:34 +00:00
Nishant Das
82bba593eb
Do Not Verify Attestations When Packing Them ( #8135 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-12-16 18:06:49 +00:00
terence tsao
20dede7532
Move state summary cache to DB ( #8101 )
2020-12-16 08:56:21 -08:00
Victor Farazdagi
46d99fdc00
Attestation aggregation: remove proper set duplicates ( #8063 )
...
* fix proper-set issue
* move test into dedicated test file
* move functionality from maxcover -> proposer
* adds dedup to proposer
* fix tests
* update tests
* remove redundant proper subset test
* fix bug with identical expression
2020-12-11 11:13:14 +03:00
Victor Farazdagi
be078d6a16
Update TestMain(): do not call os.Exit() explicitly ( #8046 )
...
* update workspace
* update testmain
2020-12-04 16:10:07 +00:00
terence tsao
2153a2d7c3
Remove logging deposit inclusion slot ( #8023 )
...
* Remove logging deposit inclusion slot
* Remove old tests
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-12-02 21:17:47 +00:00
Preston Van Loon
29c6a0c42c
Fix zero genesis check, make processAttestation routine wait for genesis time to be set ( #7947 )
...
* Fix zero genesis check, make processAttestation routine wait for genesis time to be set
* Update beacon-chain/blockchain/receive_attestation.go
Co-authored-by: Nishant Das <nishdas93@gmail.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-25 18:52:59 +00:00
terence tsao
a051e684ae
Update log levels ( #7931 )
2020-11-23 13:16:08 -08:00
terence tsao
97ad5cd5fd
Reduce no attestation in pool to warn ( #7863 )
...
* Reduce no attestation in pool to warn
* Use NotFound
* Update validator/client/aggregate.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* Update validator/client/aggregate.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2020-11-20 12:17:26 -08:00
Ivan Martinez
cfed4fa1b5
Remove listen for ChainStarted in WaitForChainStart ( #7849 )
...
* Remove GenValRoot from ChainStarted and remove ChainStarted from WaitForChainStart
* Fix test and add logs
2020-11-18 05:51:00 +00:00
Ivan Martinez
fec469291e
Add GenesisValidatorRoot to ChainStartResponse ( #7846 )
...
* Add genesis validator root to chainstartresposne
* Deps
* Tidy
* Fix tests
* Fix test
* Fix test and add to ChainStartedData
2020-11-17 20:15:48 -06:00
Ivan Martinez
5889670cc7
Remove WaitForSynced ( #7835 )
...
* Remove waitforsynced
* Remove WaitForsynced entirely
* Fix bazel
* tidy
2020-11-16 20:48:16 -06:00
Victor Farazdagi
f361450e8d
Update TestMain() to use os.Exit() ( #7814 )
...
* update TestMain
* fix sync/initial-sync test
* restore code in rate limiter
* fix rate_limiter tests
2020-11-13 18:28:14 -08:00
Preston Van Loon
0c9389a438
Fix instances of "The result of append is not used anywhere SCC-SA4010" ( #7812 )
2020-11-13 22:54:12 +00:00
Victor Farazdagi
09e3f0360e
Remove redundant calls to os.exit() in TestMain ( #7761 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-10 14:56:47 +00:00
Nishant Das
5995d2394c
Pass By Value Instead Of Reference ( #7710 )
...
* change to value from reference
* fix up
* make it a pointer
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-11-09 10:08:08 +00:00
Nishant Das
211d9bc0b9
Update BLST And Herumi ( #7632 )
...
* fix build from source
* clean up
* update again
* change everything
* workaround for now
* fix versioning
* all passing now
* fix build issues
* clean up
* revert use of MulVerify
* gaz
* stub
* Apply suggestions from code review
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* fix all
* fix test
* todo
* fix stub
* revert back
* make deep source happy
* Update shared/bls/herumi/public_key.go
* Update shared/bls/blst/signature.go
* Update shared/bls/blst/signature_test.go
* imports
* move iface to common, export errors
* rm iface build
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
2020-10-30 19:06:33 +00:00
Nishant Das
f1bce1001d
Restrict Proposer Lookup to the Current Epoch ( #7542 )
...
* checkpoint
* add test
* Update beacon-chain/core/helpers/committee_test.go
* preston's review
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-10-26 13:40:38 -07:00
Radosław Kapka
ec0af98a9e
Cache ETH1 headers on startup for eth1data voting ( #7541 )
...
* initial commit
* branch cleanup
* gzl
* underscore for unused parameteres
* caching implemented
* BlockExistsWithCache - tests
* add missing method to mock POWChain
* add missing method to faulty mock POWChain
* fix failing test
* add underflow checks
* change warning to error
* use helper to calculate end block
Co-authored-by: nisdas <nishdas93@gmail.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-20 05:10:27 +00:00
terence tsao
7076a1ec4a
More feature flag deletions ( #7533 )
...
* Delete disable state lock and init sync verbose flags
* Delete disable slashing broadcast
* Remove disable wait for sync, noise, eth1 cache, static subnet
* Remove enable broadcast recovery attemp and make it as default
* Remove disable head update on per attestation
* Revert disable att braodcast discovery attempt
* gazelle
* Fixed an anti pattern
* Add enableAttBroadcastDiscoveryAttempts back
* Add back WaitForSync
* Remove extra lines
* Use DisableDynamicCommitteeSubnets path per @prestonvanloon feedback
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-14 23:28:49 +00:00
Ivan Martinez
803d7c9bd2
Add functionality to retrieve all pending items from pools ( #7530 )
...
* Allow slashing pools to retrieve all items
* Add functionality to exits too to retrieve all exits
* Rename to noLimit
* ndo err
* Fix tests
* Fix test
* Fix test again
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-10-14 21:08:24 +00:00
Victor Farazdagi
a005c77b3f
Update error usage patterns to go1.13+ ( #7529 )
...
* rely on errors.Is
* wrap errors
2020-10-14 17:39:52 +00:00
terence tsao
8f04c555fc
More feature flags removal ( #7526 )
...
* Remove disable domain cache
* Remove don't verify att sig flag
* Remove batch verify and attester copies
* Remove batch verify usage
* Update tests
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-14 16:18:40 +00:00
Radosław Kapka
b742511193
Numeric conversion cleanup ( #7465 )
...
* validator count
* fix build errors
* fix test error
* randao mixes
* active indices
* lastReceivedMerkleIndex
* redundant conversions
* eth1FollowDistance
* refs
* fix compile error
* slasher
* validator
* revert changes to lastReceivedMerkleIndex
* remove todo
* fix references test
* fix committee test
* Revert "validator count"
This reverts commit 19b376e39914b88b620a113215daa539e3e66758.
# Conflicts:
# beacon-chain/rpc/beacon/validators.go
* Revert "fix build errors"
This reverts commit f4acd6e9776c899a0523df10b64e55783b44c451.
* Revert "fix test error"
This reverts commit 2a5c9eec63e4546139220c71fe3c07ad92bed3b6.
* Revert "randao mixes"
This reverts commit 2863f9c24dd8cfc44ffce16321f68ef3b793e9a2.
* Revert "active indices"
This reverts commit 6e8385f3956a08ef9c8980b5343365a1bee48542.
* Revert "refs"
This reverts commit c64a153f67cd26daa58c3bf5f911da05d41cfb5d.
* Revert "fix references test"
This reverts commit fe773b55a6f8cc38c6c5c1f96615fdb8bbd4397d.
* Revert "fix committee test"
This reverts commit 7a0931c4487707e3eaf75a592415577f04253772.
* fix compilation errors
* Revert "slasher"
This reverts commit 8b34137931cff1e6cdffeaf65e1ef07eefdea647.
* trieutil
* some int() simplifications
* fix deepsource issues
* removed redundant fmt.Sprint
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-13 12:43:49 +00:00
Victor Farazdagi
ac1a4a078c
Fix reported anti patterns ( #7501 )
...
* merge var decl
* single append
* replace bytes.Compare -> bytes.Equal
* remove redundant spritnf
* remove redundant spritnf
* trimprefix
* remove redundant nil check
* remove redundant return
* plain channel or unblock on context closing
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-12 16:12:00 +00:00
Victor Farazdagi
a019a0db4c
Combines func params of the same type ( #7500 )
...
* combines func params
* update leftovers
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-12 15:43:19 +00:00
Preston Van Loon
7cc32c4dda
Various code inspection resolutions ( #7438 )
...
* remove unused code
* remove defer use in loop
* Remove unused methods and constants
* gofmt and gaz
* nilness check
* remove unused args
* Add TODO for refactoring subscribeWithBase to remove unused arg. It seems too involved to include in this sweeping PR. https://github.com/prysmaticlabs/prysm/issues/7437
* replace empty slice declaration
* Remove unnecessary type conversions
* remove redundant type declaration
* rename receivers to be consistent
* Remove bootnode query tool. It is now obsolete by discv5
* Remove relay node. It is no longer used or supported
* Revert "Remove relay node. It is no longer used or supported"
This reverts commit 4bd7717334dad85ef4766ed9bc4da711fb5fa810.
* Delete unused test directory
* Delete unsupported gcp startup script
* Delete old k8s script
* build fixes
* fix build
* go mod tidy
* revert slasher/db/kv/block_header.go
* fix build
* remove redundant nil check
* combine func args
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
2020-10-12 08:11:05 +00:00
Victor Farazdagi
d169b490fa
Fix ineffectual assignments ( #7403 )
...
* update rpc/beacon
* more fixes to beacon-chain/rpc
* update beacon-chain/sync
* Merge refs/heads/master into fix-ineffectual-assignments
* updates beacon-chain/p2p
* Merge branch 'fix-ineffectual-assignments' of github.com:prysmaticlabs/prysm into fix-ineffectual-assignments
* update beacon-chain/*
* fix imports
* update beacon-chain/blockchain
* more updates
* Merge refs/heads/master into fix-ineffectual-assignments
* Merge branch 'master' into fix-ineffectual-assignments
* Merge refs/heads/master into fix-ineffectual-assignments
* next round of updated
* Merge branch 'fix-ineffectual-assignments' of github.com:prysmaticlabs/prysm into fix-ineffectual-assignments
* wrap up remaining items
2020-10-01 18:53:36 +00:00
Victor Farazdagi
95a5b4945b
Fixes incorrect checks for errors in several tests ( #7392 )
...
* fixes TestServer_ListAssignments_Pagination_InputOutOfRange
* fixes TestServer_ListValidatorBalances_PaginationOutOfRange
* fix TestServer_ListAttestations_Genesis
* remove redundant TestServer_GetValidatorParticipation_DoesntExist and TestGetDuties_NextEpoch_CantFindValidatorIdx
* Merge branch 'master' into fix-invalid-errcheck-tests
* remove unnecessary import
* fix TestStore_OnAttestation
* fix TestStore_OnAttestationUsingCheckptCache
* fix TestVerifyBlkDescendant
* fix pagination tests
* fix account v2 tests
* fix account v2 tests (remote)
* fix TestServer_JWTInterceptor_BadToken
* Merge refs/heads/master into fix-invalid-errcheck-tests
2020-10-01 14:38:53 +00:00
terence tsao
5178474280
Check err for filterAttestationsForBlockInclusion ( #7398 )
...
* Check err for
* Merge refs/heads/master into check-err
2020-09-30 22:45:17 +00:00
Radosław Kapka
dca93ce641
Unnecessary Slice-to-Slice Conversion analyzer ( #7321 )
...
* analyzer with tests
* fix bazel file
* modify analyzer to fix build issues
* add analyzer to tool chain
* remove arrays from inspections
* fix redundant [:] operator
* Merge branch 'master' into use-slice-directly
* Merge branch 'master' into use-slice-directly
* fix another inspection
* add package-level comment
2020-09-23 16:14:34 +00:00
Victor Farazdagi
3621b2ff25
Better naming for constructor funcs ( #7316 )
...
* sync/initial-sync
* NewBeaconClientService -> NewService
* NewSlashingProtectionService -> NewService
* NewPrometheusService -> NewService
* NewColdStartService -> NewService
* NewRegularSync -> NewService
* NewDetectionService -> NewService
* NewWallet -> New
* NewKeystore -> New
* Merge branch 'master' into better-naming
* Merge branch 'master' into better-naming
* NewDepositCache -> New
2020-09-23 08:59:49 +00:00
Nishant Das
719e99ffd9
Replace Roughtime With Timeutils Across Prysm ( #7301 )
...
* remove roughtime
* change all references
* rename
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-09-22 19:49:58 +08:00
Victor Farazdagi
c8b91ba7b0
Attestation proposing: more tests ( #7267 )
...
* refactors test
* Merge branch 'master' into optimize-proposals
* more filtering and sorting proposer atts
* Merge branch 'master' into optimize-att-proposer
* Merge branch 'master' into optimize-att-proposer
* revert
* Terence's suggestion on naming
2020-09-18 17:16:31 +00:00
Radosław Kapka
cc147c7097
Align eth1data Majority Vote with the spec ( #7200 )
...
* align voting with the spec
* Merge branch 'master' into eth1vote-spec-align
* remove redundant else statements
* add comment to exported variable
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge branch 'master' into eth1vote-spec-align
# Conflicts:
# beacon-chain/rpc/validator/proposer_test.go
* refactor tests
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* fix mock POWChain
* move last block's time check and add more test cases
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
* Merge refs/heads/master into eth1vote-spec-align
2020-09-18 09:46:31 +00:00
Victor Farazdagi
e477df321c
Updates proposer tests namings ( #7234 )
...
* adds proposer_ namespacing
* remove redundant string
* Merge branch 'master' into proposer-test-fix-naming
* Merge refs/heads/master into proposer-test-fix-naming
2020-09-14 12:55:20 +00:00
terence tsao
3147a5ee01
Check attestation slot before broadcast ( #7209 )
2020-09-10 13:16:35 -07:00
