4419 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Raul Jordan	7c52ef8c2b	Accounts V2: Simplify Wallet Save/Read To and From Disk Functions (#6686) ... * simplify wallet functions * fix build * futher simplify wallet * simplify read/write methods * move direct functions to direct keymanager * further move direct km specific funcs * cleanup * simplify the direct tests * fixed tests * lint * further simplify * tidy * fix config write * fixed test Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>	2020-07-22 21:12:51 -05:00
Victor Farazdagi	0006377aec	Applies assertion funcs to validator tests (#6694) ... * Applies assertion funcs to validator/keymanager/v1 tests * gazelle * Applies assertion funcs to validator/keymanager/v2 tests * Applies assertion funcs to validator/misc tests * Applies assertion funcs to validator/misc tests * Merge branch 'master' into validator-apply-testutils-assertions * gazelle * Merge branch 'master' into validator-apply-testutils-assertions * Merge branch 'master' into validator-apply-testutils-assertions * Merge refs/heads/master into validator-apply-testutils-assertions	2020-07-23 01:13:52 +00:00
Preston Van Loon	208659d7f5	Enable local slashing protection by default (#6687) ... * Enable local slashing protection by default * Merge refs/heads/master into enable-local-protection-by-default * Merge refs/heads/master into enable-local-protection-by-default * Merge refs/heads/master into enable-local-protection-by-default * Merge refs/heads/master into enable-local-protection-by-default * Merge refs/heads/master into enable-local-protection-by-default * Merge refs/heads/master into enable-local-protection-by-default	2020-07-23 00:47:19 +00:00
Ivan Martinez	cf57db910c	Accounts V2: Remove traces from command errors (#6692) ... * Remove traces from errors for accounts command * Merge refs/heads/master into remove-stack * Merge refs/heads/master into remove-stack * Merge refs/heads/master into remove-stack * Merge refs/heads/master into remove-stack * Merge refs/heads/master into remove-stack	2020-07-23 00:11:00 +00:00
Ivan Martinez	73a9429f1e	Accounts V2: Remove CanUnlockAccounts from Wallet (#6693) ... * Remove CanUnlockAccounts from Wallet * Merge refs/heads/master into remve-canunlockaccounts * Merge refs/heads/master into remve-canunlockaccounts * Merge refs/heads/master into remve-canunlockaccounts	2020-07-22 23:26:39 +00:00
Raul Jordan	cab89c37f1	Accounts V2: Remove Mnemonic Confirm From Direct Keymanager (#6696) ... * remove mnemonic from direct * Merge refs/heads/master into remove-mnemonic-direct	2020-07-22 22:52:31 +00:00
Ivan Martinez	7d80415089	Move deposit utils to depositutil package (#6690) ... * Move deposit utils to depositutil package * gofmt * Gaz * Merge refs/heads/master into move-deposit-utils * Merge refs/heads/master into move-deposit-utils	2020-07-22 22:21:41 +00:00
Preston Van Loon	f19770a393	Revert "Add Github Superlinter" (#6691) ... * Revert "Add Github Superlinter (#6677)" This reverts commit 6270347fdb. * Merge refs/heads/master into revert-6677-rauljordan-patch-1	2020-07-22 21:48:04 +00:00
rkapka	95efcb6410	Applies assertion funcs to forkchoice tests (#6685) ... * refactored 3 files * refactored the rest of files * Merge branch 'origin-master' into refactor-forkchoice-tests * gazelle fix * Merge branch 'master' into refactor-forkchoice-tests * Merge branch 'master' into refactor-forkchoice-tests * Merge branch 'master' into refactor-forkchoice-tests	2020-07-22 21:11:03 +00:00
Raul Jordan	6270347fdb	Add Github Superlinter (#6677) ... * Add Github Superlinter This PR adds the Github superlinter to our codebase as a Github action. Resolves #6308. * Apply suggestions from code review * Merge refs/heads/master into rauljordan-patch-1 * fix action * Merge refs/heads/master into rauljordan-patch-1 * Merge refs/heads/master into rauljordan-patch-1 * Merge refs/heads/master into rauljordan-patch-1 * Merge refs/heads/master into rauljordan-patch-1 * Merge refs/heads/master into rauljordan-patch-1	2020-07-22 20:22:26 +00:00
Victor Farazdagi	e5b7c3f3e6	Applies assertion funcs to validator/keymanager tests (#6683) ... * Applies assertion funcs to validator/keymanager/v1 tests * gazelle * Applies assertion funcs to validator/keymanager/v2 tests * Merge refs/heads/master into validator-keymanager-apply-testutils-assertions * Merge refs/heads/master into validator-keymanager-apply-testutils-assertions	2020-07-22 19:42:43 +00:00
terence tsao	6c408d31df	Remove unused protos and operations (#6684) ... * Remove attestation containers * Remove unused last votes Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>	2020-07-22 14:05:41 -05:00
Victor Farazdagi	4400321081	Handles case when no peers with finalized blocks are found (#6679) ... * Handles case when no peers with finalized blocks are found * more tests * Merge branch 'master' into handle-zero-block-init-sync * Merge branch 'master' into handle-zero-block-init-sync	2020-07-22 18:14:24 +00:00
terence tsao	17f845dcb0	Update head before send feed (#6681) ... * Update head before state feed * Test * Merge branch 'master' of github.com:prysmaticlabs/prysm into update-head	2020-07-22 17:05:17 +00:00
Preston Van Loon	62ae22e3f9	Use correct context for chainHeadRetrieval (#6678) ... * Use correct context for chainHeadRetrieval * Merge refs/heads/master into fix-context	2020-07-22 16:20:20 +00:00
Nishant Das	647599e87f	fix for virtual networks (#6676)	2020-07-22 10:44:17 -05:00
Raul Jordan	4017743f7f	Accounts V2: Refactor Wallet Open / Close and Keymanager Initialization (#6668) ... * refactoring create account * dep * much easier, create a derived account by simply unlocking wallet * revert changes to new * make open wallet smarter and utilize cli ctx * remove the wallet config * successfully build * simplify ctx creation for tests * tests should pass individually * tests pass * fixed up to allow for wallet password file input * fix broken tests * formatting * fmt * simplify recover * fixed up tests * implicit use of default wallet path working Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>	2020-07-21 23:49:04 -05:00
Preston Van Loon	28096a846e	Better gRPC retry including stream retry (#6670) ... * Add gRPC retry delay, apply retry and delay to streams * gofmt, fix flag * lint Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>	2020-07-21 22:45:52 -05:00
Ivan Martinez	e0d11ff1d2	Accounts V2: Wallet Recover (#6661) ... * Implement derived wallet recover * Fix log * Fix tests * Comments * Merge branch 'master' of github.com:prysmaticlabs/prysm into derived-recover * Remove log * Comments * Fix fatal * add comment * Merge refs/heads/master into derived-recover * Merge refs/heads/master into derived-recover * Merge refs/heads/master into derived-recover * Merge refs/heads/master into derived-recover	2020-07-22 02:41:39 +00:00
Ivan Martinez	8a65af168d	Accounts V2: Change fatal logs to return errors (#6672) ... * Change logging out errors to returns * Merge branch 'master' of github.com:prysmaticlabs/prysm into change-logs-to-return * Lint * Merge branch 'master' into change-logs-to-return	2020-07-22 02:04:08 +00:00
terence tsao	d1a828ad87	Rm archival service db usages and proto definitions (#6671)	2020-07-21 17:04:46 -07:00
Preston Van Loon	f1cfb6a222	Update go-ethereum (#6660) ... * Update go-ethereum * fix go-ethereum * Merge branch 'master' into update-go-ethereum * Merge refs/heads/master into update-go-ethereum * Merge refs/heads/master into update-go-ethereum * Merge refs/heads/master into update-go-ethereum	2020-07-21 21:52:19 +00:00
Raul Jordan	3023f5dbd3	Accounts V2: Derived Keymanager Sign (#6667) ... * amend derived with secret keys cache * all tests for sign * Merge branch 'master' into sign-derived * formatting * Merge branch 'sign-derived' of github.com:prysmaticlabs/prysm into sign-derived * initialize * use seed * fix build * Merge refs/heads/master into sign-derived * Merge refs/heads/master into sign-derived * Update validator/keymanager/v2/derived/derived.go	2020-07-21 21:15:47 +00:00
terence tsao	c41e382255	Optimize AppendValidator for beacon state (#6659)	2020-07-21 12:58:30 -07:00
Preston Van Loon	784f4169ef	Check gossip message decoded length before decoding (#6663) ... * Check gossip message decoded length before decoding * gofmt * Merge refs/heads/master into snappy-decodedlen-check * Merge refs/heads/master into snappy-decodedlen-check * Merge refs/heads/master into snappy-decodedlen-check * @nisdas feedback	2020-07-21 19:14:34 +00:00
terence tsao	367738e83b	Remove unused attestation operations in DB (#6664) ... * Remove attestation usages in DB * Merge refs/heads/master into rm-unused * Merge refs/heads/master into rm-unused * Fixed export wrapper * Merge branch 'rm-unused' of github.com:prysmaticlabs/prysm into rm-unused	2020-07-21 18:17:33 +00:00
Victor Farazdagi	ca54c1d480	Applies assertion funcs to validator/client tests (#6654) ... * Applies assertion funcs to validator/client tests * gazelle * Merge branch 'master' into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions * Merge refs/heads/master into validator-client-apply-testutils-assertions	2020-07-21 13:02:21 +00:00
Raul Jordan	e97d310453	Accounts V2: Derived Keymanager List Accounts (#6662) ... * begin on list derived accounts * begin on list derived accounts * continued work on listing derived accounts * deterministic pet name * petnames * finished list * display deposit data * lint * use direct km * tidy * begin on revising tests for accounts list * fix direct list test * gaz * tests all passing for derived list * gaz	2020-07-21 05:06:11 +00:00
Raul Jordan	bc16fa9f50	Accounts V2: Derived Keymanager, Wallet & Account Creation (#6624) ... * initialize derived wallet * derived wallet + account creation * initialize wallet seed * encrypted seed file creation * generate next acct * create seed from pass * properly creating derived accounts * fix up formatting * prep for review * start tests for derived create account * add derived test * linter * gaz * derived keymanager create account test complete * Merge branch 'master' into derived-keymanager * tests pass * gaz * fix list test * Merge refs/heads/master into derived-keymanager * ivan feedback * skip mnemonic confirm * Merge branch 'derived-keymanager' of github.com:prysmaticlabs/prysm into derived-keymanager * comment * tidy * fmt * organize * test interface conformity * Update validator/accounts/v2/iface/wallet.go * ivan comments * Merge branch 'derived-keymanager' of github.com:prysmaticlabs/prysm into derived-keymanager * Merge refs/heads/master into derived-keymanager * Merge branch 'master' of github.com:prysmaticlabs/prysm into derived-keymanager * Fix * Fix test * Merge refs/heads/master into derived-keymanager * fix errs * imports * Gaz	2020-07-21 02:05:23 +00:00
Victor Farazdagi	9deeb592e6	Adds type info into equality assertions (#6656) ... * Adds type info into equality assertions * tests * reorder got/want * more tests * Merge refs/heads/master into assertions-better-error-reporting * Merge refs/heads/master into assertions-better-error-reporting * Merge refs/heads/master into assertions-better-error-reporting	2020-07-21 00:47:53 +00:00
Ivan Martinez	93bbb86a30	Accounts-V2: Add tests for exporting and importing (#6615) ... * Add test for exporting and importing * Add test for non-interactive * Test import cli * Merge branch 'master' of github.com:prysmaticlabs/prysm into test-export * Merge branch 'master' into test-export * Cleanup tests a bit * Change to assert * Fix tests * Merge branch 'master' of github.com:prysmaticlabs/prysm into test-export * Fix comment, change constants * Fixes * Change to require * Fix broken test * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export * Merge refs/heads/master into test-export	2020-07-20 21:12:46 +00:00
Ivan Martinez	d54663a553	Add --historical-slasher-node flag to simplify slasher usage (#6627) ... * Add historical-slasher-node flag * Fix build * Remove useless flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Fix flag * Merge branch 'add-flasher-flag' of github.com:prysmaticlabs/prysm into add-flasher-flag * Add flags to beacon chain * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag * Merge refs/heads/master into add-flasher-flag	2020-07-20 20:23:48 +00:00
terence tsao	0488c9869e	Init sync batch block clean up (#6599)	2020-07-20 12:35:30 -07:00
Victor Farazdagi	f0ffd5af03	Introduces peer scorer service (#6579) ... * introduces peer scorer service * gazelle * Merge branch 'master' into peer-scoring-service * fixes comment * fix build error * linter suggestions * Merge branch 'master' into peer-scoring-service * updates tests * Merge branch 'master' into peer-scoring-service * badresponses scorer tests * gazelle * Merge branch 'master' into peer-scoring-service * Merge branch 'master' into peer-scoring-service * adds scorer_test * gazelle * updates bad response default penalty * more comments * Merge branch 'master' into peer-scoring-service * Merge branch 'master' into peer-scoring-service * Merge branch 'master' into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * introduces peerdatastore into status * makes sure that commong peer data store is used * Merge branch 'peer-scoring-service' of github.com:prysmaticlabs/prysm into peer-scoring-service * linter * gazelle * updates tests * Merge branch 'master' into peer-scoring-service * fixes tests * Nishant's suggestions * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge refs/heads/master into peer-scoring-service * Merge branch 'master' into peer-scoring-service * gofmt * Nishant's suggestion to use isBadPeer * Merge refs/heads/master into peer-scoring-service	2020-07-20 15:12:59 +00:00
Victor Farazdagi	22141db319	Applies assertion funcs to validator/accounts tests (#6653) ... * Applies assertion funcs to validator/accounts tests * Applies assertion funcs to validator/accounts tests	2020-07-20 10:56:45 +00:00
Victor Farazdagi	10d3275638	Applies assertion funcs to rpc tests (#6641) ... * applies assertion funcs to beacon-chain/rpc tests * Merge branch 'master' into rpc-apply-testutils-assertions * applies assertion funcs to beacon-chain/rpc/beacon tests * Merge branch 'master' into rpc-apply-testutils-assertions * applies assertion funcs to beacon-chain/rpc/debug tests * applies assertion funcs to beacon-chain/rpc/validator tests * Merge branch 'master' into rpc-apply-testutils-assertions * Merge refs/heads/master into rpc-apply-testutils-assertions	2020-07-20 02:15:51 +00:00
Victor Farazdagi	1d0fe105fc	Extends assertions to accept fmt params (#6645) ... * Extends assertions to accept fmt params	2020-07-20 01:36:28 +00:00
terence tsao	0544dd1f8e	Applies assertion funcs to shared tests (#6643) ... * cmd tests * deposit util tests * feature config tests * hashutil tests * htr util tests * interop tests * ip util tests	2020-07-19 21:08:29 +00:00
Preston Van Loon	b60a965981	ProcessAttestations: Add requirement that inclusion distance is not zero (#6642) ... * Add requirement that inclusion distance is not zero, add regression test * fix test input data * Merge refs/heads/master into fix-panic * Merge refs/heads/master into fix-panic	2020-07-19 16:38:45 +00:00
terence tsao	38c8393e52	Revert "Fixes issue with vals order in assert.Equal" (#6640) ... * Revert "Fixes issue with vals order in assert.Equal (#6631)" This reverts commit d535cb95d8. * Merge branch 'master' into revert-6631-assertions-less-assuming-error-msg	2020-07-19 04:45:04 +00:00
Victor Farazdagi	568238009e	Extracts peer data store in p2p/peers status (#6639) ... * introduces peer data store to p2p/peers * Merge refs/heads/master into p2p-extract-data-store * Merge refs/heads/master into p2p-extract-data-store * refactores status service * Merge branch 'p2p-extract-data-store' of github.com:prysmaticlabs/prysm into p2p-extract-data-store * updates tests * gofmt * rever decay test	2020-07-19 03:45:08 +00:00
Preston Van Loon	c419e4ed8f	Improved cold state checkpoints: migrate database index and usage (#6461) ... * Add database migrations, still need to update the API usage... * gofmt goimports * progress * Merge branch 'master' of github.com:prysmaticlabs/prysm into index-migration * use slot instead of index * rename LastArchivedIndex to LastArchivedSlot * rename LastArchivedIndexRoot to LastArchivedRoot * remove unused HighestSlotStates method * deprecate old key, include in migration * deprecate old key, include in migration * remove blocks index in migration * rename bucket variable * fix code to pass tests * Merge branch 'master' of github.com:prysmaticlabs/prysm into index-migration * gofmt, goimports * fix * Add state slot index * progress * lint * fix build * Merge branch 'master' of github.com:prysmaticlabs/prysm into index-migration * kafka * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * remove SaveArchivedPointRoot, a few other big changes * Merge branch 'index-migration' of github.com:prysmaticlabs/prysm into index-migration * fix tests and lint * lint again * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * block migration, some renaming * gaz, gofmt * add tests * change index to uint bytes * Merge branch 'index-migration' of github.com:prysmaticlabs/prysm into index-migration * rm method notes * stop if the bucket doesn't exist * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * @rauljordan pr feedback * Simplify * Merge refs/heads/master into index-migration * Remove unused method, add roundtrip test * gofmt * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge refs/heads/master into index-migration * Merge branch 'master' of github.com:prysmaticlabs/prysm into index-migration	2020-07-18 18:05:04 +00:00
terence tsao	d53539499c	Applies assertion funcs to shared tests (part 1) (#6626) ... * Update kv aggregated_test.go * Update block_test.go * Update forkchoice_test.go * Update unaggregated_test.go * Update prepare_forkchoice_test.go * Update prune_expired_test.go * Update atts service_test.go * Update service_attester_test.go * Update service_proposer_test.go * Upate exit service_test.go * Gaz * Merge branch 'master' of github.com:prysmaticlabs/prysm * Move averageBalance from log.go to info.go * Move avg balance from log.go to info.go * Add info test * Remove unused logEpochData in log.go * Gaz * Merge branch 'master' of github.com:prysmaticlabs/prysm * Merge branch 'master' of github.com:prysmaticlabs/prysm * aggregation tests * attestation util tests * bench util tests * block util tests * herumi tests * bytesutil tests * Merge refs/heads/master into testutil-shared * Merge refs/heads/master into testutil-shared * Merge refs/heads/master into testutil-shared * Merge refs/heads/master into testutil-shared * Merge refs/heads/master into testutil-shared * Update shared/aggregation/attestations/attestations_test.go Co-authored-by: Victor Farazdagi <simple.square@gmail.com> * Merge branch 'master' of github.com:prysmaticlabs/prysm into testutil-shared * Fixed ordering * Merge branch 'testutil-shared' of github.com:prysmaticlabs/prysm into testutil-shared * Update shared/aggregation/attestations/attestations_test.go Co-authored-by: Victor Farazdagi <simple.square@gmail.com> * Update shared/bytesutil/bytes_test.go Co-authored-by: Victor Farazdagi <simple.square@gmail.com>	2020-07-18 16:31:42 +00:00
Victor Farazdagi	d535cb95d8	Fixes issue with vals order in assert.Equal (#6631) ... * fixes issue with vals order in assert.Equal	2020-07-18 11:14:50 +00:00
Victor Farazdagi	7ba500c417	Applies assertion funcs to state tests (#6623) ... * applies assertion funcs to beacon-chain/state tests * applies assertion funcs to beacon-chain/state/stategen tests * applies assertion funcs to beacon-chain/state/stateutil tests * gazelle * Merge refs/heads/master into state-apply-testutils-assertions * Merge refs/heads/master into state-apply-testutils-assertions * Merge refs/heads/master into state-apply-testutils-assertions	2020-07-18 07:56:48 +00:00
Preston Van Loon	c573306621	Check for array out of bounds when calculating proposer delta -- follow up (#6630) ... * failing test * fix	2020-07-18 06:39:43 +00:00
Preston Van Loon	5336a167af	Check for array out of bounds when calculating proposer delta (#6629) ... * Check for array out of bounds when calculating proposer delta * Merge refs/heads/master into proposer-delta-bug	2020-07-18 04:31:03 +00:00
Preston Van Loon	0e4cb68249	Add regression test found by fuzzer (#6628) ... * Add regression test found by fuzzer	2020-07-18 03:47:03 +00:00
Nishant Das	cc3c3a0c54	QSP 29: Add Rate Limiter For All Topics (#6606) ... * initial commit * Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding into rateLimiter * finally * add mutex * rate limiter for all rpc reqs * remove recursive readlocks * spelling * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * fix all tests * fix all tests * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter * Merge refs/heads/master into rateLimiter	2020-07-17 08:58:51 +00:00
Raul Jordan	9ad6277852	Accounts V2: Create Wallet Non-Interactively + Add Test Coverage (#6611) ... * create wallet noninteractively * tests for wallet create * kapol feedback * Merge refs/heads/master into create-wallet-tests * Merge refs/heads/master into create-wallet-tests	2020-07-17 08:21:16 +00:00