To increase DRY and enable DRY in tests and other users of the Beacon Chain state package,
an error that was duplicated unnecessarily in each version of the state is moved to the root
Beacon Chain state package.
* Deduplicate sync committee indices from state
* Deduplicate code in listblocks RPC endpoints, which only differ in response object
* Deduplicate test code in config/fieldparams
* Delete stale benchmark target. This is already included in go_default_test
* deduplicate test cases in TestIsSlashableValidator_OK and fix blst
BUILD file
* Deduplicate TestStore_IsFinalizedChildBlock
* Revert crypto/bls/blst/BUILD.bazel
* Deduplicate TestStore_SaveBlock_NoDuplicates
* Use a generic wrapper for beacon blocks to streamline test
* Deduplicate TestStore_BlocksCRUD
* Deduplicate TestStore_BlocksHandleZeroCase
* Deduplicate TestStore_BlocksBatchDelete
* deduplicate TestStore_BlocksHandleInvalidEndSlot
* Deduplicate TestStore_BlocksCRUD_NoCache
* Deduplicate common block test setup. Make TestStore_Blocks_FiltersCorrectly support multiple forks in test
* Deduplicate the rest of these tests
* lint
* Deprecation warning
* Add test for WrappedSignedBeaconBlock
* Test error path
* Add merge spectests
* fix build
* gazelle
* operation
* all tests should pass
* go fmt
* fix test
* fix dependency
* rm unused constants
* rename to bellatrix
* Gaz
* Rm unused files
* Use Bellatrix for test names
* Add more spec tests
* Gaz and fix test
* sync with dev
* Preston's feedback
* Go fmt
* sync with dev
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* Rename BeaconStateMerge to BeaconStateBellatrix
* Rename version.Merge to version.Bellatrix
* Rename ComputeFieldRootsWithHasherMerge to ComputeFieldRootsWithHasherBellatrix
* Rename test names to Bellatrix
* Rename comments and strings to Bellatrix
* Fix formatting in a few files
* Revert wrong renaming in test name
* Revert renaming to Bellatrix in mainnet_config.go
* Revert renaming of db key without migration
* Regenerate from proto changes
* Rename new use of already renamed symbols
* gofmt and goimports after regenerating protofiles
* revert weird imports
Co-authored-by: prestonvanloon <preston@prysmaticlabs.com>
* Extract gossip topic without a full copy via strings.Split
* Add basic benchmark
* gofmt
* Add empty topic test case
* Remove nl
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* initial commit for work on web3signer-keymanager
* WIP key manager client
* adding in more valid unit tests
* refactoring some of my code to work better with current implementations
* adding comments, some error situations and fixing unit tests
* updating go.mod
* gaz
* addressing sandbox errors on test
* fixing more sand box debug items
* missed yet another error case on my test
* reverting go.mod
* addressing comments
* missed removal of unit test
* removing some deepsource issues
* adjusting based on review comments
* addressing comments
* adding the missed types
* changing public keys to only pull once
* fixing commented code format
* gaz
* Update validator/keymanager/remote-web3signer/keymanager.go
updating comments
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/keymanager.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/keymanager.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/keymanager.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/keymanager.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/keymanager.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Update validator/keymanager/remote-web3signer/client.go
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* fixing conflicts
* addressing comments
* fixing deepsource issues
* more deep source issue fix
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* Minor cleanups on monitor service
* Update tests
* Update process_block_test.go
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* allow checkpoint or genesis origin; refactoring
some quick readability improvements and simplifying the logic enforcing
the startup ordering of the attestation processing routine
* address PR feedback
* gofmt
* Update beacon-chain/blockchain/receive_attestation.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* Apply suggestions from code review
use log.WithError for aggregation friendliness
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: kasey <kasey@users.noreply.github.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* begin the middleware approach
* attempt middleware
* middleware works in tandem with web ui
* handle delete as well
* delete request
* DELETE working
* tool to perform imports
* functioning
* commentary
* build
* gaz
* smol test
* enable keymanager api use protonames
* edit
* one rule
* rem gw
* Fix custom compiler
(cherry picked from commit 3b1f65919e04ddf7e07c8f60cba1be883a736476)
* gen proto
* imports
* Update validator/node/node.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
* remaining comments
* update item
* rpc
* add
* run gateway
* simplify
* rem flag
* deep source
Co-authored-by: prestonvanloon <preston@prysmaticlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* make db merge compatible
* util merge.go per @rauljordan
* Go fmt
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* Value assigned to a variable is never read before being overwritten
* The result of append is not used anywhere
* Suspicious assignment of range-loop vars detected
* Unused method receiver detected
* Revert "Auxiliary commit to revert individual files from 54edcb445484a2e5d79612e19af8e949b8861253"
This reverts commit bbd1e1beabf7b0c5cfc4f514dcc820062ad6c063.
* Method modifies receiver
* Fix test
* Duplicate imports detected
* Incorrectly formatted error string
* Types of function parameters can be combined
* One more "Unused method receiver detected"
* Unused parameter detected in function
* Add a service for the monitor
* Do not block service start
* gaz
* move channel subscription outide go routine
* add service start test
* fix panic on node tests
* Radek's first pass
* Radek's take 2
* uncap error messages
* revert reversal
* Terence take 1
* gaz
* Missing locks found by Terence
* Track via bool not empty interface
* Add tests for every function
* fix allocation of slice
* Minor cleanups
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
* Add sync committeee contributions to monitor
* gaz
* Raul's review
* Added lock around TrackedValidators
* add comment to trackedIndex
* add missing locks because of trackedIndex
* Terence fixes 2
* moved TrackedValidator to service from config
* Terence comment fix
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
* quick lazy balance cache proof of concept
* WIP refactoring to use lazy cache
* updating tests to use functional opts
* updating the rest of the tests, all passing
* use mock stategen where possible
reduces the number of test cases that require db setup
* rename test opt method for clear link
* Update beacon-chain/blockchain/process_block.go
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
* test assumption that zerohash is in db
* remove unused MockDB (mocking stategen instead)
* fix cache bug, switch to sync.Mutex
* improve test coverage for the state cache
* uncomment failing genesis test for discussion
* gofmt
* remove unused Service struct member
* cleanup unused func input
* combining type declaration in signature
* don't export the state cache constructor
* work around blockchain deps w/ new file
service_test brings in a ton of dependencies that make bazel rules
for blockchain complex, so just sticking these mocks in their own
file simplifies things.
* gofmt
* remove intentionally failing test
this test established that the zero root can't be used to look up the
state, resulting in a change in another PR to update stategen to use the
GenesisState db method instead when the zero root is detected.
* fixed error introduced by develop refresh
* fix import ordering
* appease deepsource
* remove unused function
* godoc comments on new requires/assert
* defensive constructor per terence's PR comment
* more differentiated balance cache metric names
Co-authored-by: kasey <kasey@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* save stuff
* fix in v1
* clean up more
* fix bugs
* add comments and clean up
* add flag + test
* add tests
* fmt
* radek's review
* gaz
* kasey's review
* gaz and new conditional
* improve naming
* Validator monitor process slashings
* Preston's comment
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* add test for tracked index
* Prestons requested changes
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* begin powchain service refactor
* begin refactor
* powchain passes
* options pkg
* gaz
* rev
* rev
* comments
* move to right place
* bazel powchain
* fix test
* log
* contract addr
* happy path and comments
* gaz
* new service
* weak subjectivity verification refactor
This separates weak subjectivity verification into a
distinct type which does not have a dependency on
blockchain.Service
* remove unused variable
* saving enqueued init blocks before ws verify
* remove TODO, handled in previous commit
* accept suggested comment change
start comment w/ name of function NewWeakSubjectivityVerifier
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
* update log w/ Raul's suggested language
* explicit zero value for clarity
* add comments clarifying how we adhere to spec
* more clear TODO per Raul's feedback
* gofmt
Co-authored-by: kasey <kasey@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
