mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-24 20:37:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
8,222 Commits 1 Branch 17 Tags 132 MiB
dd73f762ec
Commit Graph

4777 Commits

Author SHA1 Message Date
Potuz
dd14d5cef0
refactor slot tickers with intervals (#12440) 
* refactor slot tickers with intervals

* GoDoc

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-08-03 20:55:16 -03:00
Radosław Kapka
3a09405bb7
HTTP Beacon API: /eth/v1/validator/aggregate_and_proofs (#12686) 
* HTTP Beacon API: `/eth/v1/validator/contribution_and_proofs`

* add comment to invalid test case

* fix validation and test

* review

* in progress

* implementation

* remove test file

* remove duplicate

* tests

* review

* test fixes

---------

Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-08-03 22:24:23 +00:00
Nishant Das
a820d4dcc8
Minor Optimization on InnerShuffleList (#12690) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-08-03 06:56:07 +00:00
terencechain
dbc17cf2ca
Fix: use correct context for UpdateCommitteeCache (#12691) 2023-08-03 06:00:58 +00:00
Potuz
e5d1eb885d
Update caches blocking (#12679) 
* update NSC together with epoch boundary caches

* block when updating caches

* reviews

* removal of very useful helper because the reviewers requested it :)

* use IsEpochEnd
 2023-08-02 05:59:09 +00:00
terencechain
c342c9a14e
fix: update nil check for new validator (#12677) 2023-08-01 04:13:57 +00:00
Radosław Kapka
a9b003e1fe
HTTP Beacon API: /eth/v1/validator/contribution_and_proofs (#12660) 
* HTTP Beacon API: `/eth/v1/validator/contribution_and_proofs`

* add comment to invalid test case

* fix validation and test

* review

---------

Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-07-31 17:32:39 +00:00
Radosław Kapka
955175b7eb
Update server-side events dependency (#12676) 
* Update server-side events dependency

* go sum

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-07-31 15:51:19 +00:00
Potuz
c17682940e
only handle epoch boundary on canonical blocks (#12666) 
* only handle epoch boundary on canonical blocks

* do not fetch headstate
 2023-07-31 12:07:09 -03:00
Nishant Das
db450f53a4
Fix Update Of Committee Cache (#12668) 
* fix it

* sammy's comment

* fix tests

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-07-28 13:34:03 +00:00
terencechain
493905ee9e
feat: add state regren duration metric (#12672) 2023-07-27 19:33:25 +00:00
terencechain
a44c209be0
feat: add metric for block gossip time (#12670) 2023-07-27 15:17:24 +00:00
terencechain
183e72b194
fix: update epoch + 1 (#12667) 2023-07-27 18:53:36 +08:00
Potuz
337c254161
update shuffling caches at epoch boundary (#12661) 
* update shuffling caches at epoch boundary

* move span

* do not advance to a past slot
 2023-07-26 18:46:18 +00:00
Potuz
ded00495e7
Parallelize cl el validation (#12590) 
* Parallelize EL and CL block validation

* fix by Nishant
 2023-07-26 12:23:51 -03:00
Nishant Das
113172d8aa
Exit Initial Sync Early (#12659) 
* add check

* fix test
 2023-07-26 00:38:25 +00:00
Radosław Kapka
2b40c44879
Use the correct root in consensus validation (#12657) 
Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-07-25 12:04:08 +02:00
Radosław Kapka
fc193b09bf
HTTP Beacon API: /eth/v1/validator/aggregate_attestation (#12643) 
* initial implementation

* it works

* tests

* extracted helper functions

* fix code

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-07-24 22:16:45 +00:00
Radosław Kapka
a0d53f5155
Register GetValidatorPerformance as POST (#12658) 2023-07-24 21:17:08 +00:00
Nishant Das
dd403f830c
clean up logging (#12653) 2023-07-24 20:29:50 +08:00
Potuz
f97db3b738
Different parallel hashing (#12639) 
* Paralellize hashing of large lists

* add unit test

* add file

* do not parallelize on low processor count

* revert minimal proc count

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-07-21 20:36:20 -04:00
Radosław Kapka
43378ae8d5
Use BlockProcessed event in Beacon API (#12625) 
* Use `BlockProcessed` event in Beacon API

* log error

---------

Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-07-20 17:26:34 +00:00
james-prysm
405cd6ed86
Publish blockv2 ssz (#12636) 
* wip produce block v2 ssz

* adding functions for ssz processing

* fixing linting

* Update beacon-chain/rpc/eth/beacon/handlers.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* addressing review feedback

* fixing linting

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-07-20 16:26:40 +00:00
terencechain
ba9bbdd6b9
Style: minor cleanups to blockchain pkg (#12640) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-07-20 10:17:35 +00:00
Nishant Das
d4fd3c34de
Use GetPayloadBodies in our Engine Client (#12630) 
* add it to our engine client

* lint

* add better debugging info

* temp debugging

* fix

* fix it

* pretty

* dumb bug

* Revert "pretty"

This reverts commit 6a6df3cc5fd0c269e7917bc2b96f304498d6959e.

* Revert "fix it"

This reverts commit 73dc617bb0b653f882c79cd09c1c9df9af1e5453.

* Revert "fix"

This reverts commit 3aecdaac6d21cd43ae0db5f17a71f07bf1a5f928.

* Revert "temp debugging"

This reverts commit ffcd2c61a0dd38667e9555d284a9dd8f87972bfc.

* Revert "add better debugging info"

This reverts commit 96184e8567bdcf82b40c55838660443233105865.

* raul's comment

* regression test

---------

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-07-18 15:46:23 +00:00
Radosław Kapka
ec2fda7ad9
getSyncCommitteeRewards API endpoint (#12633) 2023-07-18 10:31:15 +02:00
Nishant Das
af0ee9bd16
use read-only validators (#12628) 2023-07-15 00:34:45 -07:00
Radosław Kapka
456ba7c498
Fix comments when receiving block (#12624) 2023-07-14 10:30:02 +00:00
Kaushal Kumar Singh
1894a124ea
Fix: Size of SyncCommitteeBits should be 64 bytes (512 bits) instead of 512 bytes (#12586) 
* Fix: Size of SyncCommitteeBits should be 64 bytes (512 bits) instead of 512 bytes

* Updated unit test
 2023-07-13 10:43:17 +00:00
james-prysm
0266609bf6
bugfix : Eth-Consensus-Version header on response header (#12600) 
* adding in custom header

* adding in parsing for middleware

* fixing casing

* add handling on error as well

* changing how error is handled for header

* changing how error is handled

* fixing casing

* Update beacon-chain/rpc/eth/beacon/blocks.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update beacon-chain/rpc/eth/beacon/blinded_blocks.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update beacon-chain/rpc/eth/beacon/blinded_blocks.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update beacon-chain/rpc/eth/beacon/blocks.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* fixing unit tests and review comment

* making some constants consistent in 1 file

* fixing missed blinded blocks

* fixing constants in custom handler tests

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-07-11 13:27:23 -05:00
Potuz
58df1f1ba5
lock before saving the poststate to db (#12612) 2023-07-11 16:10:32 +00:00
Simon
cec32cb996
Append Dynamic Addinng Trusted Peer Apis (#12531) 
* Append Dynamic Addinng Trusted Peer Apis

* Append unit tests for Dynamic Addinng Trusted Peer Apis

* Update beacon-chain/p2p/peers/peerdata/store.go

* Update beacon-chain/p2p/peers/peerdata/store_test.go

* Update beacon-chain/p2p/peers/peerdata/store_test.go

* Update beacon-chain/p2p/peers/peerdata/store_test.go

* Update beacon-chain/p2p/peers/status.go

* Update beacon-chain/p2p/peers/status_test.go

* Update beacon-chain/p2p/peers/status_test.go

* Update beacon-chain/rpc/eth/node/handlers.go

* Update beacon-chain/rpc/eth/node/handlers.go

* Update beacon-chain/rpc/eth/node/handlers.go

* Update beacon-chain/rpc/eth/node/handlers.go

* Move trusted peer apis from rpc/eth/v1/node to rpc/prysm/node; move peersToWatch into ensurePeerConnections function;

* Update beacon-chain/rpc/prysm/node/server.go

* Update beacon-chain/rpc/prysm/node/server.go

* fix go lint problem

* p2p/watch_peers.go: trusted peer makes AddrInfo structure by itself instead of using MakePeer().

p2p/service.go: add connectWithAllTrustedPeers function, before connectWithPeer, add trusted peer info into peer status.

p2p/peers/status.go: trusted peers are not included, when pruning outdated and disconnected peers.

* use readlock for GetTrustedPeers and IsTrustedPeers

---------

Co-authored-by: simon <sunminghui2@huawei.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-07-11 09:26:08 +00:00
Nishant Das
0a68d2d302
Fix Context Cancellation (#12604) 2023-07-08 08:50:04 +00:00
Sammy Rosso
6a0db800b3
GetValidatorPerformance http endpoint (#12557) 
* Add http endpoint for GetValidatorPerformance

* Add tests

* fix up client usage

* Revert changes

* refactor to reuse code

* Move endpoint + move ComputeValidatorPerformance

* Radek's comment change

* Add Bazel file

* Change endpoint path

* Add server for http endpoints

* Fix server

* Create core package

* Gaz

* Add correct error code

* Fix error code in test

* Adding errors

* Fix errors

* Fix default GRPC error

* Change http errors to core ones

* Use error status without helper

* Fix

* Capitalize GRPC error messages

---------

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-07-07 14:49:44 +00:00
Nishant Das
085f90a4f1
Prune Pending Deposits on Finalization (#12598) 
* prune them

* Update beacon-chain/blockchain/process_block_helpers.go

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-07-07 11:20:14 +08:00
terencechain
f8408b9ec1
feat: add metric for ReceiveBlock (#12597) 2023-07-06 02:57:55 -07:00
Preston Van Loon
d6d5139d68
Clarify sync committee message validation (#12594) 
* Clarify sync committee validation and error message

* fix test
 2023-07-05 19:20:21 +00:00
terencechain
2e0e29ecbe
fix: prune invalid blocks during initial sync (#12591) 2023-07-05 08:33:33 -07:00
Potuz
e9b5e52ee2
Move consensus and execution validation outside of onBlock (#12589) 
* Move consensus and execution validation outside of onBlock

* reviews

* fix unit test

* revert version change

* fix tests

---------

Co-authored-by: terencechain <terence@prysmaticlabs.com>
 2023-07-05 21:12:21 +08:00
Nishant Das
2a4441762e
Handle Epoch Boundary Misses (#12579) 
* add changes

* fix tests

* fix edge case

* fix logging
 2023-07-05 09:23:51 +00:00
Nishant Das
401fccc723
Log Finalized Deposit Insertion (#12593) 
* add log

* update key

---------

Co-authored-by: terencechain <terence@prysmaticlabs.com>
 2023-07-05 08:07:38 +00:00
Radosław Kapka
c80f88fc07
Rename payloadHash to lastValidHash in setOptimisticToInvalid (#12592) 2023-07-04 17:03:45 +00:00
Kevin Wood
faa0a2c4cf
Correct log level for 'Could not send a chunked response' (#12562) 
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-07-02 22:58:12 +00:00
Nishant Das
c45cb7e188
Optimize Validator Roots Computation (#12585) 
* add changes

* change it
 2023-07-01 02:23:25 +00:00
james-prysm
d0c740f477
Registration Cache used by default and other UX changes for Proposer settings (#12456) 
* WIP

* WIP

* adding in migration function

* updating mock validator and gaz

* adding descriptive logs

* fixing mocking

* fixing tests

* fixing mock

* adding changes to handle enable builder settings

* fixing tests and edge case

* reduce cognative complexity of function

* further reducing cognative complexity on function

* WIP

* fixing unit test on migration

* adding more tests

* gaz and fix unit test

* fixing deepsource issues

* fixing more deesource issues missed previously

* removing unused reciever name

* WIP fix to migration logic

* fixing loging info

* reverting migration logic, converting logic to address issues discussed on slack, adding unit tests

* adding test for builder setting only not saved to db

* addressing comment

* fixing flag

* removing accidently missed deprecated flags

* rolling back mock on pr

* fixing fmt linting

* updating comments based on feedback

* Update config/features/flags.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* fixing based on feedback on PR

* Update config/validator/service/proposer_settings.go

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>

* Update validator/client/runner.go

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>

* Update validator/db/kv/proposer_settings.go

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>

* adding additional logs to clear up some steps based on feedback

* fixing log

* deepsource

* adding comments based on review feedback

---------

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-06-29 02:49:21 +00:00
Potuz
5bb482e5d6
Remove forkchoice call from notify new payload (#12560) 
* Remove forkchoice call from notify new payload

* add unit test
 2023-06-28 13:38:24 +00:00
terencechain
83494c5b23
fix: use diff context to update proposer cache background (#12571) 2023-06-27 20:31:54 +00:00
terencechain
a10ffa9c0e
Cache next epoch proposers at epoch boundary (#12484) 
* Cache next epoch proposers at epoch boundary

* Fix new lines

* Use UpdateProposerIndicesInCache

* dont set state slot

* Update beacon_committee.go

* dont set state slot

* genesis epoch check

* Rm check

* fix: rm logging ctx

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>

* feat: move update to background

---------

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-06-27 14:41:24 +00:00
Potuz
1ebef16196
use the incoming payload status instead of calling forkchoice (#12559) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-06-22 18:09:02 +00:00
terencechain
8af634a6a0
feat: aggregate atts using fixed pool of go routines (#12553) 
* feat: aggregate atts using fixed pool of go routines

* fix: deepsrc complains

* style: comment

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* feat: aggregate atts using fixed pool of go routines

* fix: deepsrc complains

* style: comment

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-06-22 17:48:42 +00:00
Potuz
884ba4959a
Remove unneded helper (#12558) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-06-22 16:54:52 +00:00
terencechain
75e94120b4
fix(aggregator): remove single bit aggregation (#12555) 2023-06-22 09:34:25 -07:00
Bryce T
c018981951
Add expected withdrawals API (#12519) 
* add structs for expected-withdrawals-api

* add server handler

* add tests

* add bazel file

* register api in service

* remove get prefix for endpoint

* fix review comments

* Update beacon-chain/rpc/eth/builder/handlers.go

* use goimports sorting type

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-06-21 14:36:47 +00:00
Radosław Kapka
b92226bedb
getAttestationRewards API endpoint (#12480) 
* handler

* very much work in progress

* remove Polish

* thinking

* working but differs from LH

* remove old stuff

* review from Potuz

* validator performance beacon server

* Revert "validator performance beacon server"

This reverts commit 42464cc6d375d7d27a4a781644c27f8b057212a5.

* reuse precompute calculations

* todos

* production quality

* add json tags to AttestationRewards

* Potuz's review

* extract vars

---------

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-06-21 13:16:53 +00:00
Potuz
57f97feb84
Track optimistic status on head (#12552) 2023-06-20 08:59:48 -07:00
Sanghee Choi
2bf0560dc7
fix typo (beacon-chain/node/node.go) (#12551) 2023-06-20 08:32:34 +00:00
Radosław Kapka
a40f903f76
Fix TestFieldTrie_NativeState_fieldConvertersNative (#12550) 2023-06-19 13:49:12 +00:00
Potuz
27aac105d7
disable nil payloadid log on relayers flags (#12465) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-06-16 17:01:57 +00:00
terencechain
115d565f49
fix: late block task wait for initial sync (#12526) 
* fix: late block task wait for initial sync

* fix: remove wait for clock
 2023-06-16 13:47:19 +00:00
Potuz
019e0b56e2
Do not validate merge transition block after Capella (#12459) 2023-06-16 13:11:07 +00:00
Nishant Das
0efb038984
Fix Fuzz Target For ExecutionPayload (#12541) 2023-06-16 12:41:28 +00:00
Nishant Das
63d81144e9
Fix Uint256 Json Parsing (#12540) 
* add stronger checks

* radek's review
 2023-06-16 09:43:20 +00:00
james-prysm
6edbfa3128
multiple validator status - optimization (#12487) 
* adding optmization

* addressing comments

* adding a test and fixing change in assignments.go

* making some changes based on review of the code

* removing irrelevant test

* changing formatting
 2023-06-15 17:20:00 -05:00
Nishant Das
c7b2c011d8
fix parsing (#12534) 2023-06-15 11:12:39 -04:00
Potuz
3e17dbb532
log the right blocknumber (#12529) 2023-06-14 19:55:33 +00:00
Nishant Das
a75e78ddb4
Ignore Late Message Logs (#12525) 2023-06-14 10:37:39 +00:00
Nishant Das
1862422db9
Remove Defer In ProposeGenericBlock (#12524) 2023-06-14 05:25:52 +00:00
terencechain
2b410893a0
optimization: epoch boundary uses next slot cache (#12515) 
* optimization: epoch boundary uses next slot cache

* test: fix

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-06-12 17:13:49 +00:00
Nishant Das
d5057cfb42
Add the Ability for Prysm To Handle Trusted Peers (#12492) 
* add all changes

* add to peers to watch

* add tests

* Update beacon-chain/p2p/peers/peerdata/store_test.go

* radek's review

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-06-12 14:47:52 +00:00
Potuz
e4e315da94
log validation time for blocks (#12514) 2023-06-12 22:06:57 +08:00
terencechain
0a4e42545e
Use next slot cache for sync committee (#12287) 
* Use next slot cache for sync committee

* RWMutex

* change mutex for last cached state

* feat: change mutex

* test: add db

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-06-12 04:30:06 +00:00
terencechain
6896b41963
optimization(proposer rpc): move htr to after broadcast (#12504) 2023-06-09 06:32:29 -07:00
Nishant Das
3bf6abe27c
Ignore Phase0 Blocks For Monitor (#12503) 2023-06-09 05:00:36 +00:00
Nishant Das
c1391f0de3
Always Favour Yamux for Multiplexing (#12502) 2023-06-08 04:02:46 +00:00
Nishant Das
0669050ffa
Add Appropriate Size for the Attestation Queue (#12485) 
* add tag

* fix off by 1
 2023-06-02 11:33:28 +00:00
zghh
ceff0c2024
Fix the bug that return 500 in /eth/v1/node/peers interface (#12483) 
* Fix the bug that return 500 in /eth/v1/node/peers interface

* Update node.go

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-06-02 03:27:17 +00:00
Radosław Kapka
c32b581e8e
Add broadcast_validation to block publishing (#12432) 
* day 1

* day 2

* day 2+

* day 3

* day 4

* making bazel happy

* PublishBlindedBlockV2

* remove file

* use lock in insertSeenProposerIndex

* remove EquivocationChecker interface

* update deps.bzl

* remove middleware json tags

* go mod tidy

* remove redundant return statements

* validate in handler

* improvements

* extract common code

* remove import

* sync test fix

* Update beacon-chain/rpc/eth/beacon/handlers.go

Co-authored-by: terencechain <terence@prysmaticlabs.com>

---------

Co-authored-by: terencechain <terence@prysmaticlabs.com>
 2023-06-01 11:22:49 +00:00
terencechain
e516a2004f
Update next slot cache correctly under late task (#12462) 2023-05-31 08:50:37 -07:00
terencechain
cb65d8af96
Proposer RPC: make setExecutionData better (#12466) 2023-05-31 06:06:32 -07:00
Nishant Das
70152bf476
Copy All Field Tries For Late Blocks (#12461) 
* add new thing

* only have it for late blocks

* comments

* change to lock

* add test

* Update beacon-chain/state/state-native/state_test.go

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-05-30 09:57:20 +00:00
Radosław Kapka
8aa688729d
Cleanup of ProposerPayloadIDsCache (#12474) 
* Cleanup of `ProposerPayloadIDsCache`

* one more comment

* Update beacon-chain/cache/payload_id.go

Co-authored-by: terencechain <terence@prysmaticlabs.com>

* Update beacon-chain/cache/payload_id.go

Co-authored-by: terencechain <terence@prysmaticlabs.com>

---------

Co-authored-by: terencechain <terence@prysmaticlabs.com>
 2023-05-29 16:10:28 +00:00
Preston Van Loon
1ffc92999f
p2p: Check peer threshold is met before giving up on ctx deadline (#12446) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-05-28 13:24:59 +00:00
terencechain
f4d3939b62
Add logs for build block times (#12452) 
Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-05-24 13:37:26 +00:00
Nishant Das
245d8a29e0
Optimize Zerohash Comparisons In Forkchoice (#12458) 2023-05-24 09:58:02 +00:00
Preston Van Loon
cfa64ae013
Restore disable-peer-scorer flag (#12386) 
* Revert "Make Peer Scorer Permanent Default (#12138)"

This reverts commit 4d28d69fd9.

* make peer scoring flag warning scary
 2023-05-23 13:53:02 +00:00
Potuz
cd0f814f2e
fixed erroneous panic (#12450) 2023-05-23 11:12:31 +00:00
Radosław Kapka
abc81e6dde
Merge all block unblinding code into a single unblinder struct (#12240) 
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-05-23 11:38:52 +02:00
terencechain
6b26183e73
Add missing config yamls for domains (#12442) 
* Add missing config yamls for domains

* Fix GetSpec test

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-05-22 18:02:41 +00:00
Preston Van Loon
7fe935e94d
Fix metric name from PR #12430 (#12445) 
* Fix metric name from PR #12430

* @potuz can't spell 'unknown'

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-05-22 17:43:21 +00:00
Potuz
e0e7c71eb5
Fix sandwich attack on honest reorgs (#12418) 
* Fix sandwich attack on honest reorgs

* fix test

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-05-22 17:23:20 +00:00
Potuz
c80019bd0b
remove trivial helper (#12443) 2023-05-22 15:59:16 +00:00
james-prysm
8dfb92c605
reverting expiration logic on validator while using --enable-registration-cache (#12436) 
* reverting expiration logic

* gaz
 2023-05-22 14:54:09 +00:00
Potuz
9d192a3608
Remove unused function (#12439) 
* Remove unused function

* gazelle
 2023-05-22 11:09:08 -03:00
Nishant Das
51bde7a845
disable it (#12438) 2023-05-22 19:18:13 +08:00
kasey
385a317902
Revert initsync revert (#12431) 
* Revert "Revert "BeaconBlocksByRange and BlobSidecarsByRange consistency (#123… (#12426)"

This reverts commit ddc1e48e05.

* fix metrics bug, add batch.next tests

---------

Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
 2023-05-19 16:59:13 +00:00
Potuz
b84dd40ba9
Use forkchoice to validate sync messages faster (#12430) 
* Use forkchoice to validate sync messages faster

* add metric
 2023-05-19 14:47:39 +00:00
kasey
aeaa72fdc2
fix deadlock between monitor service and init-sync (#12427) 
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
 2023-05-18 18:35:06 +00:00
kasey
ddc1e48e05
Revert "BeaconBlocksByRange and BlobSidecarsByRange consistency (#123… (#12426) 
This reverts commit 73e4bdccbb.

Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
 2023-05-18 18:01:26 +00:00
Nishant Das
f91159337b
Fix Migration Of State (#12423) 2023-05-18 13:18:56 +00:00
Potuz
537236e1c9
Add aggregation metrics (#12417) 2023-05-17 12:18:59 -07:00
kasey
73e4bdccbb
BeaconBlocksByRange and BlobSidecarsByRange consistency (#12383) 
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-05-17 12:16:10 +00:00
Potuz
be23773924
Don't use max cover on unaggregated atts nor check subgroup of validated signatures (#12350) 
* Don't use max cover on unnaggregated atts

* Do not validate signature on the attestation package

* separate nil error checks

* fix unit tests
 2023-05-16 17:06:26 +00:00
Potuz
955a21fea4
revert revert of f6764fe62b (#12399) 2023-05-16 11:50:02 +00:00
kasey
f1b88d005d
fix broken slasher service init (#12405) 
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
 2023-05-15 17:00:29 -05:00
terencechain
3b9e974a45
Add epoch and root to not a checkpt in forkchoice log (#12400) 
* Add epoch number and root in not a checkpt in forkchoice log

* Update beacon-chain/blockchain/process_attestation_helpers.go

Co-authored-by: Nishant Das <nishdas93@gmail.com>

* Fix test

* Fix typo

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-05-14 06:02:36 +00:00
Potuz
ad749a40b6
Save to checkpoint cache if the nsc hits (#12398) 
* Save to checkpoint cache if the nsc hits

Also move the head check before the checkpoint cache check

* add unit test
 2023-05-13 09:54:33 -03:00
terencechain
9b13454457
Metrics: Invert too late and too early att received count (#12392) 
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-05-12 19:45:43 +00:00
Potuz
b9917807d8
Ignore some untimely attestations (#12387) 
* Ignore some untimely attestations

* correct child slot check

* consider tips as viable for checkpoints

* deal with canonical blocks

* forkchoice unit tests

* blockchain readonly beacon state

* Ignore some untimely attestations

* correct child slot check

* consider tips as viable for checkpoints

* deal with canonical blocks

* forkchoice unit tests

* blockchain readonly beacon state

* Fix AttestationTargetState mock

* Fix ineffectual assignment lint

* Fix blockchain tests

* Fix build

* Add Nil check

* add comment on lock

---------

Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-05-12 16:55:33 +00:00
Preston Van Loon
2c3b3b802a
Revert "Add a new slot ticker and use it on attestation aggregation" (#12390) 
This reverts commit f6764fe62b.
 2023-05-12 14:49:37 +00:00
Simon
3ef3e1d13b
fix-subnets-oom (#12388) 
fix-subnets-oom, close iterator after using it
 2023-05-12 07:52:17 -05:00
Nick Sullivan
5c00fcb84f
Fix numerous spelling error and typos in the log messages, comments, and documentation. (#12385) 
* Minor typos and spelling fixes (comments, logs, & docs only, no code changes)

* Fix seplling in log message

* Additional spelling tweaks based on review from @prestonvanloon
 2023-05-11 20:45:43 +00:00
Nishant Das
aef22bf54e
Add In Support For Builder in E2E (#12343) 
* fix it up

* add gaz

* add changes in

* finally runs

* fix it

* add progress

* add capella support

* save progress

* remove debug logs

* cleanup

* remove log

* fix flag

* remove unused lock

* gaz

* change

* fix

* lint

* james review

---------

Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-05-11 11:10:29 -05:00
Potuz
f6764fe62b
Add a new slot ticker and use it on attestation aggregation (#12377) 
* Add slot ticker with intervals

* add flags for aggregation duration

* misspelling

* hide flags

* fix flags and default durations

* lint

* wait for initial sync

* deep source

* add log

* Preston's review

* fix error message

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-05-10 12:48:51 +00:00
Preston Van Loon
4b4e213a24
stategen: Pre-populate bls pubkey cache as part of stategen's Resume function (#11482) 
* Pre-populate bls pubkey cache as part of state gen's Resume function. This adds some helpers and a benchmark to blst

* Do it async

* fix missing import

* lint

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: rauljordan <raul@prysmaticlabs.com>
 2023-05-10 10:44:15 +00:00
kasey
7d9f36985e
Fix initialization race (#12374) 
* block all the sync startup code on init signal

* don't need chainStarted if everything blocks

* set empty clock by default to work around panics

* remove unused clock, zero-value for init-sync

---------

Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Nishant Das <nishdas93@gmail.com>
 2023-05-10 04:09:15 +00:00
james-prysm
98f8ca4e34
reverting version check on bid header (#12376) 
* adding reverting change

* adding additional tests and checks

* removing comment

* updating based on review suggestions

* fixing deepsource issues

* attempting to resolve dependencies

* removing dependency

* accidently flipped if statement with deepsource fix

* fixing unit test
 2023-05-10 08:45:09 +08:00
Raul Jordan
6f383f272a
Do Not Panic on Broadcasting Nil Object (#12369) 2023-05-07 05:00:30 +00:00
Radosław Kapka
bd833e1c12
Use v1alpha1 server in block production (#12336) 
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-05-04 19:52:41 +02:00
kasey
918129cf36
Replace statefeed Initialize (#12285) 
* refactor initialization to blocking startup method

* require genesisSetter in blockchain, fix tests

* work-around gazelle weirdness

* fix dep gazelle ignores

* only call SetGenesis once

* fix typo

* validator test setup and fix to return right error

* move waitForChainStart to Start

* wire up sync Service.genesisWaiter

* fix p2p genesisWaiter plumbing

* remove extra clock type, integrate into genesis

and rename

* use time.Now when no Nower is specified

* remove unused ClockSetter

* simplify rpc context checking

* fix typo

* use clock everywhere in sync; [32]byte val root

* don't use DeepEqual to compare [32]byte and []byte

* don't use clock in init sync, not wired up yet

* use clock waiter in blockchain as well

* use cancelable contexts in tests with goroutines

* missed a reference to WithClockSetter

* Update beacon-chain/startup/genesis.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update beacon-chain/blockchain/service_test.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* more clear docs

* doc for NewClock

* move clock typedef to more logical file name

* adding documentation

* gaz

* fixes for capella

* reducing test raciness

* fix races in committee cache tests

* lint

* add tests on Duration slot math helper

* startup package test coverage

* fix bad merge

* set non-zero genesis time in tests that call Start

* happy deepsource, happy me-epsource

* replace Synced event with channel

* remove unused error

* remove accidental wip commit

* gaz!

* remove unused event constants

* remove sync statefeed subscription to fix deadlock

* remove state notifier

* fix build

---------

Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: nisdas <nishdas93@gmail.com>
 2023-05-03 04:34:01 +00:00
terencechain
5b8084b829
Proposer builds block in parallel. (Consensus vs Execution) (#12297) 
* Proposer builds block in parallel. Cosensus vs Execution

* Update beacon-chain/rpc/prysm/v1alpha1/validator/proposer.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* Use feature flag

---------

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
 2023-05-01 14:37:26 +00:00
james-prysm
83416f31a5
Unregister validator - fix behind feature flag (#12316) 
* adding changes to blocks

* trying out expiration

* adding implementation, have WIP for tests

* adding unit tests for cache

* fixing bazel complaints

* fix linting

* adding safe check for unint type

* changing approach to safety check

* adding cache to bazel to test fixing build

* reverting bazel change and adding flag to usage

* implementing interface on mock to fix build error

* fixing unit tests

* fixing unit test

* fixing unit tests

* fixing linting

* fixing more unit tests

* fixing produce blinded block tests

* Update beacon-chain/cache/registration.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* resolving review comments

* fixing cache

* Update beacon-chain/cache/registration.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* Update beacon-chain/cache/registration.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* fixing time logic

* adding context to trace

* fix bazel lint

* fixing context dependency

* fix linting

* Update cmd/beacon-chain/flags/base.go

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* addressing review comments

* fixing deepsource issues

* improving the default settings

* fixing bazel

* removing irrelevant unit test

* updating name

---------

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
 2023-04-28 21:27:47 +00:00
Sammy Rosso
d382abe198
InsertFinalizedDeposits: return an error (#12342) 
* InsertFinalizedDeposits: return an error

* Remove logging

* Radek' Review

---------

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
 2023-04-28 20:59:09 +00:00
terencechain
8481a3e6ec
Beacon-api: save atts to pool (#12345) 
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-27 22:47:03 +02:00
Potuz
b56f3e70df
log correctly the head changed when it actually changes (#12324) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-27 17:13:58 +00:00
kasey
f962d13407
Fix committee test race (#12338) 
* fix races in committee cache tests

* lint

* gratuitous defer ClearCache if ClearCache

* log warning to avoid failed block processing

* gaz

* add Clear to cache stubs

* fix Clear mistakes

* last fake cache fix

---------

Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
 2023-04-27 00:50:04 +00:00
Radosław Kapka
34b6c8f333
Use mock v1alpha1 server in Beacon API's validator functions (#12319) 2023-04-26 18:59:29 +02:00
terencechain
73fea51398
Use next slot cache for payload attribute (#12286) 2023-04-25 16:13:24 -07:00
terencechain
fa7a2bd445
Move update next slot cache earlier (#12321) 
* Move next slot cache earlier

* update next slot cache if it's head
 2023-04-25 21:03:54 +00:00
Preston Van Loon
3894d60282
blockchain: add more spans to analyze block production timing (#12332) 
* blockchain: add more spans to analyze block production timing

* There is a reason that we do not use the incoming context for forkchoice updates
 2023-04-25 15:45:08 +00:00
Radosław Kapka
328e6fb074
Move some errors to separate consensus-types package (#12329) 
* move `ErrNilObjectWrapped` to separate package

* build fix

* move not supported

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-25 15:07:24 +00:00
Radosław Kapka
9e3598334d
Avoid double state copy in latestAncestor (#12326) 
* Avoid double state copy in `latestAncestor`

* remove trailing newline

---------

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
 2023-04-25 14:12:56 +00:00
Radosław Kapka
ebccdfadb5
Remove unused argument from field index (#12327) 
* Remove unused argument from field index

* bzl
 2023-04-25 13:03:55 +00:00
Cyyber Ttechno
efdda168c5
Corrected err return for GenesisState while calling db.View (#12325) 2023-04-25 02:57:07 +00:00
terencechain
08d6eccfb3
Change native execution value to Gwei Uint64 (#12291) 
* Default value to uint64

* Fix spectest

* Fix tests

* Fix tests

* Fix tests

* Fix test

* Fix test

* Fix build

* Potuz feedback

* Add test

* Fix test

* Fix test
 2023-04-22 00:44:28 +00:00
Nishant Das
97a32e1b72
Fix Status Checks For Double Deposits (#12318) 
* fix status

* fix test

---------

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
 2023-04-21 12:08:55 +00:00
Radosław Kapka
b7ef762701
Return errors from ProduceBlindedBlock (#12309) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
 2023-04-21 11:41:43 +02:00
Potuz
300a827027
Use same signature for unrealized justified hash and justified hash (#12314) 
* Use same signature for unrealized justified hash and justified hash

* fix build
 2023-04-20 15:59:12 +00:00
Preston Van Loon
9f886da1de
db: Deduplicate saveCheckpoint functionality (#12304) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-20 12:13:21 +00:00
james-prysm
7e7a2a2959
improve the blinded block error (#12310) 2023-04-19 18:27:00 -05:00
Justin Traglia
4c916403e9
Enable dupword linter & fix findings (#12271) 
* Enable dupword linter & fix findings

* Correct an incorrect fix

* Add nolint comment

* Add another nolint comment

* Revert unintended change to bazel version

---------

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-04-18 22:01:27 +00:00
Justin Traglia
b6181f8d1a
Enable nilerr linter & fix findings (#12270) 
* Enable nilerr linter & fix findings

* Deal with other findings

* Fix another finding that I missed somehow

* Fix another another issue

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>

* Update tests to expect error

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: terencechain <terence@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
 2023-04-18 20:53:16 +00:00
Preston Van Loon
00001c8628
builder: add more tracing data for builder code paths (#12302) 
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-18 19:20:42 +00:00
Justin Traglia
8428a79971
Enable whitespace linter & fix findings (#12273) 
* Enable whitespace linter & fix findings

* Fix new finding

* fix new violation

---------

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
 2023-04-18 18:58:27 +00:00
Nishant Das
e2386cfb11
Fix Attester Slashing Validation In Gossip (#12295) 
* fix slashing checks

* fix to make it more performant

* gaz

* fix up

* potuz's comment

* potuz's comment

* fix cache

* change index in test for better case

* gaz

---------

Co-authored-by: Potuz <potuz@prysmaticlabs.com>
 2023-04-17 15:35:38 +00:00
Sammy Rosso
6944d22ce3
Add support for engine_exchangeCapabilities (#12224) 
* Add call to engine_exchangeCapabilities

* Fix unused import

* Cleanup + tests

* Warning only when needed

* Add Radek' feedback
 2023-04-17 12:55:22 +00:00
Potuz
191b0c4652
Correctly use Gwei to compare builder bid value (#12290) 
* Correctly use Gwei to compare builder bid value

* Minimal 1gwei for TestProduceBlindedBlock

---------

Co-authored-by: terence tsao <terence@prysmaticlabs.com>
 2023-04-16 16:47:51 +08:00
Nishant Das
52d72c989e
Check that Builder Is Configured (#12279) 
* add configured check

* tests

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
 2023-04-14 10:21:46 +00:00
Justin Traglia
9f7711e74a
Enable misspell linter & fix findings (#12272) 
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
 2023-04-14 10:03:11 +00:00
Nishant Das
f376427add
fix panic (#12277) 2023-04-13 22:42:57 -07:00
kasey
ff1b03ab13
prysmctl using the same genesis func as e2e (#12268) 
* prysmctl using the same genesis func as e2e

* add whitespace to genesis.json for readability

* fix typo in fork name

* don't require validator count if deposits given

* add gosec exception

* the other nosec :(

* appease deepsource

* fix comments on renamed public value/func

---------

Co-authored-by: kasey <kasey@users.noreply.github.com>
 2023-04-13 17:19:06 +00:00