Potuz
e0e7c71eb5
Fix sandwich attack on honest reorgs ( #12418 )
...
* Fix sandwich attack on honest reorgs
* fix test
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-05-22 17:23:20 +00:00
Potuz
c80019bd0b
remove trivial helper ( #12443 )
2023-05-22 15:59:16 +00:00
james-prysm
8dfb92c605
reverting expiration logic on validator while using --enable-registration-cache ( #12436 )
...
* reverting expiration logic
* gaz
2023-05-22 14:54:09 +00:00
Potuz
9d192a3608
Remove unused function ( #12439 )
...
* Remove unused function
* gazelle
2023-05-22 11:09:08 -03:00
Nishant Das
51bde7a845
disable it ( #12438 )
2023-05-22 19:18:13 +08:00
kasey
385a317902
Revert initsync revert ( #12431 )
...
* Revert "Revert "BeaconBlocksByRange and BlobSidecarsByRange consistency (#123… (#12426 )"
This reverts commit ddc1e48e05
.
* fix metrics bug, add batch.next tests
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-05-19 16:59:13 +00:00
Potuz
b84dd40ba9
Use forkchoice to validate sync messages faster ( #12430 )
...
* Use forkchoice to validate sync messages faster
* add metric
2023-05-19 14:47:39 +00:00
kasey
aeaa72fdc2
fix deadlock between monitor service and init-sync ( #12427 )
...
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-05-18 18:35:06 +00:00
kasey
ddc1e48e05
Revert "BeaconBlocksByRange and BlobSidecarsByRange consistency (#123… ( #12426 )
...
This reverts commit 73e4bdccbb
.
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-05-18 18:01:26 +00:00
Nishant Das
f91159337b
Fix Migration Of State ( #12423 )
2023-05-18 13:18:56 +00:00
Potuz
537236e1c9
Add aggregation metrics ( #12417 )
2023-05-17 12:18:59 -07:00
kasey
73e4bdccbb
BeaconBlocksByRange and BlobSidecarsByRange consistency ( #12383 )
...
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
2023-05-17 12:16:10 +00:00
Potuz
be23773924
Don't use max cover on unaggregated atts nor check subgroup of validated signatures ( #12350 )
...
* Don't use max cover on unnaggregated atts
* Do not validate signature on the attestation package
* separate nil error checks
* fix unit tests
2023-05-16 17:06:26 +00:00
Potuz
955a21fea4
revert revert of f6764fe62b
( #12399 )
2023-05-16 11:50:02 +00:00
kasey
f1b88d005d
fix broken slasher service init ( #12405 )
...
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-05-15 17:00:29 -05:00
terencechain
3b9e974a45
Add epoch and root to not a checkpt in forkchoice
log ( #12400 )
...
* Add epoch number and root in not a checkpt in forkchoice log
* Update beacon-chain/blockchain/process_attestation_helpers.go
Co-authored-by: Nishant Das <nishdas93@gmail.com>
* Fix test
* Fix typo
---------
Co-authored-by: Nishant Das <nishdas93@gmail.com>
2023-05-14 06:02:36 +00:00
Potuz
ad749a40b6
Save to checkpoint cache if the nsc hits ( #12398 )
...
* Save to checkpoint cache if the nsc hits
Also move the head check before the checkpoint cache check
* add unit test
2023-05-13 09:54:33 -03:00
terencechain
9b13454457
Metrics: Invert too late and too early att received count ( #12392 )
...
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
2023-05-12 19:45:43 +00:00
Potuz
b9917807d8
Ignore some untimely attestations ( #12387 )
...
* Ignore some untimely attestations
* correct child slot check
* consider tips as viable for checkpoints
* deal with canonical blocks
* forkchoice unit tests
* blockchain readonly beacon state
* Ignore some untimely attestations
* correct child slot check
* consider tips as viable for checkpoints
* deal with canonical blocks
* forkchoice unit tests
* blockchain readonly beacon state
* Fix AttestationTargetState mock
* Fix ineffectual assignment lint
* Fix blockchain tests
* Fix build
* Add Nil check
* add comment on lock
---------
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
2023-05-12 16:55:33 +00:00
Preston Van Loon
2c3b3b802a
Revert "Add a new slot ticker and use it on attestation aggregation" ( #12390 )
...
This reverts commit f6764fe62b
.
2023-05-12 14:49:37 +00:00
Simon
3ef3e1d13b
fix-subnets-oom ( #12388 )
...
fix-subnets-oom, close iterator after using it
2023-05-12 07:52:17 -05:00
Nick Sullivan
5c00fcb84f
Fix numerous spelling error and typos in the log messages, comments, and documentation. ( #12385 )
...
* Minor typos and spelling fixes (comments, logs, & docs only, no code changes)
* Fix seplling in log message
* Additional spelling tweaks based on review from @prestonvanloon
2023-05-11 20:45:43 +00:00
Nishant Das
aef22bf54e
Add In Support For Builder in E2E ( #12343 )
...
* fix it up
* add gaz
* add changes in
* finally runs
* fix it
* add progress
* add capella support
* save progress
* remove debug logs
* cleanup
* remove log
* fix flag
* remove unused lock
* gaz
* change
* fix
* lint
* james review
---------
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
2023-05-11 11:10:29 -05:00
Potuz
f6764fe62b
Add a new slot ticker and use it on attestation aggregation ( #12377 )
...
* Add slot ticker with intervals
* add flags for aggregation duration
* misspelling
* hide flags
* fix flags and default durations
* lint
* wait for initial sync
* deep source
* add log
* Preston's review
* fix error message
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-05-10 12:48:51 +00:00
Preston Van Loon
4b4e213a24
stategen: Pre-populate bls pubkey cache as part of stategen's Resume function ( #11482 )
...
* Pre-populate bls pubkey cache as part of state gen's Resume function. This adds some helpers and a benchmark to blst
* Do it async
* fix missing import
* lint
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: rauljordan <raul@prysmaticlabs.com>
2023-05-10 10:44:15 +00:00
kasey
7d9f36985e
Fix initialization race ( #12374 )
...
* block all the sync startup code on init signal
* don't need chainStarted if everything blocks
* set empty clock by default to work around panics
* remove unused clock, zero-value for init-sync
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Nishant Das <nishdas93@gmail.com>
2023-05-10 04:09:15 +00:00
james-prysm
98f8ca4e34
reverting version check on bid header ( #12376 )
...
* adding reverting change
* adding additional tests and checks
* removing comment
* updating based on review suggestions
* fixing deepsource issues
* attempting to resolve dependencies
* removing dependency
* accidently flipped if statement with deepsource fix
* fixing unit test
2023-05-10 08:45:09 +08:00
Raul Jordan
6f383f272a
Do Not Panic on Broadcasting Nil Object ( #12369 )
2023-05-07 05:00:30 +00:00
Radosław Kapka
bd833e1c12
Use v1alpha1 server in block production ( #12336 )
...
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2023-05-04 19:52:41 +02:00
kasey
918129cf36
Replace statefeed Initialize ( #12285 )
...
* refactor initialization to blocking startup method
* require genesisSetter in blockchain, fix tests
* work-around gazelle weirdness
* fix dep gazelle ignores
* only call SetGenesis once
* fix typo
* validator test setup and fix to return right error
* move waitForChainStart to Start
* wire up sync Service.genesisWaiter
* fix p2p genesisWaiter plumbing
* remove extra clock type, integrate into genesis
and rename
* use time.Now when no Nower is specified
* remove unused ClockSetter
* simplify rpc context checking
* fix typo
* use clock everywhere in sync; [32]byte val root
* don't use DeepEqual to compare [32]byte and []byte
* don't use clock in init sync, not wired up yet
* use clock waiter in blockchain as well
* use cancelable contexts in tests with goroutines
* missed a reference to WithClockSetter
* Update beacon-chain/startup/genesis.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
* Update beacon-chain/blockchain/service_test.go
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
* more clear docs
* doc for NewClock
* move clock typedef to more logical file name
* adding documentation
* gaz
* fixes for capella
* reducing test raciness
* fix races in committee cache tests
* lint
* add tests on Duration slot math helper
* startup package test coverage
* fix bad merge
* set non-zero genesis time in tests that call Start
* happy deepsource, happy me-epsource
* replace Synced event with channel
* remove unused error
* remove accidental wip commit
* gaz!
* remove unused event constants
* remove sync statefeed subscription to fix deadlock
* remove state notifier
* fix build
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: nisdas <nishdas93@gmail.com>
2023-05-03 04:34:01 +00:00
terencechain
5b8084b829
Proposer builds block in parallel. (Consensus vs Execution) ( #12297 )
...
* Proposer builds block in parallel. Cosensus vs Execution
* Update beacon-chain/rpc/prysm/v1alpha1/validator/proposer.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* Use feature flag
---------
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2023-05-01 14:37:26 +00:00
james-prysm
83416f31a5
Unregister validator - fix behind feature flag ( #12316 )
...
* adding changes to blocks
* trying out expiration
* adding implementation, have WIP for tests
* adding unit tests for cache
* fixing bazel complaints
* fix linting
* adding safe check for unint type
* changing approach to safety check
* adding cache to bazel to test fixing build
* reverting bazel change and adding flag to usage
* implementing interface on mock to fix build error
* fixing unit tests
* fixing unit test
* fixing unit tests
* fixing linting
* fixing more unit tests
* fixing produce blinded block tests
* Update beacon-chain/cache/registration.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* resolving review comments
* fixing cache
* Update beacon-chain/cache/registration.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* Update beacon-chain/cache/registration.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* fixing time logic
* adding context to trace
* fix bazel lint
* fixing context dependency
* fix linting
* Update cmd/beacon-chain/flags/base.go
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
* addressing review comments
* fixing deepsource issues
* improving the default settings
* fixing bazel
* removing irrelevant unit test
* updating name
---------
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2023-04-28 21:27:47 +00:00
Sammy Rosso
d382abe198
InsertFinalizedDeposits: return an error ( #12342 )
...
* InsertFinalizedDeposits: return an error
* Remove logging
* Radek' Review
---------
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2023-04-28 20:59:09 +00:00
terencechain
8481a3e6ec
Beacon-api: save atts to pool ( #12345 )
...
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-04-27 22:47:03 +02:00
Potuz
b56f3e70df
log correctly the head changed when it actually changes ( #12324 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-04-27 17:13:58 +00:00
kasey
f962d13407
Fix committee test race ( #12338 )
...
* fix races in committee cache tests
* lint
* gratuitous defer ClearCache if ClearCache
* log warning to avoid failed block processing
* gaz
* add Clear to cache stubs
* fix Clear mistakes
* last fake cache fix
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-04-27 00:50:04 +00:00
Radosław Kapka
34b6c8f333
Use mock v1alpha1 server in Beacon API's validator functions ( #12319 )
2023-04-26 18:59:29 +02:00
terencechain
73fea51398
Use next slot cache for payload attribute ( #12286 )
2023-04-25 16:13:24 -07:00
terencechain
fa7a2bd445
Move update next slot cache earlier ( #12321 )
...
* Move next slot cache earlier
* update next slot cache if it's head
2023-04-25 21:03:54 +00:00
Preston Van Loon
3894d60282
blockchain: add more spans to analyze block production timing ( #12332 )
...
* blockchain: add more spans to analyze block production timing
* There is a reason that we do not use the incoming context for forkchoice updates
2023-04-25 15:45:08 +00:00
Radosław Kapka
328e6fb074
Move some errors to separate consensus-types
package ( #12329 )
...
* move `ErrNilObjectWrapped` to separate package
* build fix
* move not supported
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-04-25 15:07:24 +00:00
Radosław Kapka
9e3598334d
Avoid double state copy in latestAncestor
( #12326 )
...
* Avoid double state copy in `latestAncestor`
* remove trailing newline
---------
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2023-04-25 14:12:56 +00:00
Radosław Kapka
ebccdfadb5
Remove unused argument from field index ( #12327 )
...
* Remove unused argument from field index
* bzl
2023-04-25 13:03:55 +00:00
Cyyber Ttechno
efdda168c5
Corrected err return for GenesisState while calling db.View ( #12325 )
2023-04-25 02:57:07 +00:00
terencechain
08d6eccfb3
Change native execution value to Gwei Uint64 ( #12291 )
...
* Default value to uint64
* Fix spectest
* Fix tests
* Fix tests
* Fix tests
* Fix test
* Fix test
* Fix build
* Potuz feedback
* Add test
* Fix test
* Fix test
2023-04-22 00:44:28 +00:00
Nishant Das
97a32e1b72
Fix Status Checks For Double Deposits ( #12318 )
...
* fix status
* fix test
---------
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
2023-04-21 12:08:55 +00:00
Radosław Kapka
b7ef762701
Return errors from ProduceBlindedBlock
( #12309 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
2023-04-21 11:41:43 +02:00
Potuz
300a827027
Use same signature for unrealized justified hash and justified hash ( #12314 )
...
* Use same signature for unrealized justified hash and justified hash
* fix build
2023-04-20 15:59:12 +00:00
Preston Van Loon
9f886da1de
db: Deduplicate saveCheckpoint functionality ( #12304 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-04-20 12:13:21 +00:00
james-prysm
7e7a2a2959
improve the blinded block error ( #12310 )
2023-04-19 18:27:00 -05:00