Nishant Das
e776eb5409
Fix Powchain Error In Startup ( #7621 )
...
* fix error
* add test case
2020-10-23 03:57:19 +00:00
bidlocode
ff658ba641
Fix w3endpoint file relative path ( #7557 )
...
* add expandpath
* fix error description
* fix bazel & deepsource
* fix
* fix gofmt
* fix refactor
* add tests
* gofmt
* fix
Co-authored-by: Ivan Martinez <ivanthegreatdev@gmail.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-10-22 05:53:03 +00:00
Victor Farazdagi
a019a0db4c
Combines func params of the same type ( #7500 )
...
* combines func params
* update leftovers
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-10-12 15:43:19 +00:00
rkapka
1f21e196b6
Fix multiple anti-patterns from DeepSource analysis ( #6951 )
...
* Merge variable declaration and assignment
* Use result of type assertion to simplify cases
* Replace call to bytes.Compare with bytes.Equal
* Drop unnecessary use of the blank identifier
* Replace x.Sub(time.Now()) with time.Until(x)
* Function literal can be simplified
* Use a single append to concatenate two slices
* Replace time.Now().Sub(x) with time.Since(x)
* Omit comparison with boolean constant
* Omit redundant nil check on slices
* Nested if can be replaced with else-if
* Function call can be replaced with helper function
* Omit redundant control flow
* Use plain channel send or receive
* Simplify returning boolean expression
* Merge branch 'origin-master' into fix-antipatterns
* Merge branch 'master' into fix-antipatterns
2020-08-10 16:16:45 +00:00
Victor Farazdagi
a0bf8cba52
Removes redundant type conversions ( #6041 )
...
* removes redundant type conversions
* remove redundant type in struct decl
* removes redundant parens
* Merge refs/heads/master into redundant-type-conversions
2020-05-29 12:42:39 +00:00
Connor Stein
4242581f1e
Test EnterPassword function in shared/cmd ( #5822 )
...
* test
* fix golint
* more lint
* gazelle
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
2020-05-12 10:01:02 -05:00
Ivan Martinez
4d9da25d02
Add confirm password to validator accounts create ( #5762 )
...
* Add confirm password to accounts create
* Fix build
* Update shared/cmd/helpers.go
* Update shared/cmd/helpers.go
Co-authored-by: Shay Zluf <thezluf@gmail.com>
* Change to return empty ""
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Shay Zluf <thezluf@gmail.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-05-06 19:50:19 -04:00
Ivan Martinez
2b7865cb3b
Move "Enter a password" cmd instructions to shared/cmd ( #5724 )
...
* Move EnterPassword CMD to cmd package
* Add comment
* Add tracking issue and remove log.Fatal
* Add better error handling
* gaz
* Comment fix
* Update shared/cmd/helpers.go
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
2020-05-05 16:13:18 -04:00
Ivan Martinez
242e4bccbf
Move confirmDelete from beacon-chain to shared/cmd ( #4410 )
...
* Move confirmDelete to shared/cmd as ConfirmAction
* Finish moving function to shared/cmd
* Pass in both text
* Fix for comments
2020-01-04 23:32:09 -05:00
