package sync import ( "context" "testing" "time" "github.com/ethereum/go-ethereum/p2p/enr" "github.com/libp2p/go-libp2p-core/network" ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1" "github.com/prysmaticlabs/go-bitfield" mock "github.com/prysmaticlabs/prysm/beacon-chain/blockchain/testing" "github.com/prysmaticlabs/prysm/beacon-chain/cache" "github.com/prysmaticlabs/prysm/beacon-chain/core/helpers" dbtest "github.com/prysmaticlabs/prysm/beacon-chain/db/testing" "github.com/prysmaticlabs/prysm/beacon-chain/operations/attestations" "github.com/prysmaticlabs/prysm/beacon-chain/p2p/peers" p2ptest "github.com/prysmaticlabs/prysm/beacon-chain/p2p/testing" pb "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1" "github.com/prysmaticlabs/prysm/shared/attestationutil" "github.com/prysmaticlabs/prysm/shared/bls" "github.com/prysmaticlabs/prysm/shared/bytesutil" "github.com/prysmaticlabs/prysm/shared/params" "github.com/prysmaticlabs/prysm/shared/testutil" "github.com/prysmaticlabs/prysm/shared/testutil/assert" "github.com/prysmaticlabs/prysm/shared/testutil/require" "github.com/prysmaticlabs/prysm/shared/timeutils" logTest "github.com/sirupsen/logrus/hooks/test" ) func TestProcessPendingAtts_NoBlockRequestBlock(t *testing.T) { hook := logTest.NewGlobal() db, _ := dbtest.SetupDB(t) p1 := p2ptest.NewTestP2P(t) p2 := p2ptest.NewTestP2P(t) p1.Connect(p2) assert.Equal(t, 1, len(p1.BHost.Network().Peers()), "Expected peers to be connected") p1.Peers().Add(new(enr.Record), p2.PeerID(), nil, network.DirOutbound) p1.Peers().SetConnectionState(p2.PeerID(), peers.PeerConnected) p1.Peers().SetChainState(p2.PeerID(), &pb.Status{}) r := &Service{ p2p: p1, db: db, chain: &mock.ChainService{Genesis: timeutils.Now(), FinalizedCheckPoint: ðpb.Checkpoint{}}, blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), stateSummaryCache: cache.NewStateSummaryCache(), } a := ðpb.AggregateAttestationAndProof{Aggregate: ðpb.Attestation{Data: ðpb.AttestationData{Target: ðpb.Checkpoint{Root: make([]byte, 32)}}}} r.blkRootToPendingAtts[[32]byte{'A'}] = []*ethpb.SignedAggregateAttestationAndProof{{Message: a}} require.NoError(t, r.processPendingAtts(context.Background())) require.LogsContain(t, hook, "Requesting block for pending attestation") } func TestProcessPendingAtts_HasBlockSaveUnAggregatedAtt(t *testing.T) { hook := logTest.NewGlobal() db, _ := dbtest.SetupDB(t) p1 := p2ptest.NewTestP2P(t) r := &Service{ p2p: p1, db: db, chain: &mock.ChainService{Genesis: timeutils.Now()}, blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), attPool: attestations.NewPool(), stateSummaryCache: cache.NewStateSummaryCache(), } a := ðpb.AggregateAttestationAndProof{ Aggregate: ðpb.Attestation{ Signature: bls.RandKey().Sign([]byte("foo")).Marshal(), AggregationBits: bitfield.Bitlist{0x02}, Data: ðpb.AttestationData{ Target: ðpb.Checkpoint{Root: make([]byte, 32)}, Source: ðpb.Checkpoint{Root: make([]byte, 32)}, BeaconBlockRoot: make([]byte, 32), }, }, SelectionProof: make([]byte, 96), } b := testutil.NewBeaconBlock() r32, err := b.Block.HashTreeRoot() require.NoError(t, err) s := testutil.NewBeaconState() require.NoError(t, r.db.SaveBlock(context.Background(), b)) require.NoError(t, r.db.SaveState(context.Background(), s, r32)) r.blkRootToPendingAtts[r32] = []*ethpb.SignedAggregateAttestationAndProof{{Message: a, Signature: make([]byte, 96)}} require.NoError(t, r.processPendingAtts(context.Background())) atts, err := r.attPool.UnaggregatedAttestations() require.NoError(t, err) assert.Equal(t, 1, len(atts), "Did not save unaggregated att") assert.DeepEqual(t, a.Aggregate, atts[0], "Incorrect saved att") assert.Equal(t, 0, len(r.attPool.AggregatedAttestations()), "Did save aggregated att") require.LogsContain(t, hook, "Verified and saved pending attestations to pool") } func TestProcessPendingAtts_NoBroadcastWithBadSignature(t *testing.T) { db, _ := dbtest.SetupDB(t) p1 := p2ptest.NewTestP2P(t) r := &Service{ p2p: p1, db: db, chain: &mock.ChainService{Genesis: timeutils.Now()}, blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), attPool: attestations.NewPool(), stateSummaryCache: cache.NewStateSummaryCache(), } a := ðpb.AggregateAttestationAndProof{ Aggregate: ðpb.Attestation{ Signature: bls.RandKey().Sign([]byte("foo")).Marshal(), AggregationBits: bitfield.Bitlist{0x02}, Data: ðpb.AttestationData{ Target: ðpb.Checkpoint{Root: make([]byte, 32)}, Source: ðpb.Checkpoint{Root: make([]byte, 32)}, BeaconBlockRoot: make([]byte, 32), }, }, SelectionProof: make([]byte, 96), } b := testutil.NewBeaconBlock() r32, err := b.Block.HashTreeRoot() require.NoError(t, err) s := testutil.NewBeaconState() require.NoError(t, r.db.SaveBlock(context.Background(), b)) require.NoError(t, r.db.SaveState(context.Background(), s, r32)) r.blkRootToPendingAtts[r32] = []*ethpb.SignedAggregateAttestationAndProof{{Message: a, Signature: make([]byte, 96)}} require.NoError(t, r.processPendingAtts(context.Background())) assert.Equal(t, false, p1.BroadcastCalled, "Broadcasted bad aggregate") // Clear pool. err = r.attPool.DeleteUnaggregatedAttestation(a.Aggregate) require.NoError(t, err) r.blkRootToPendingAtts[r32] = []*ethpb.SignedAggregateAttestationAndProof{{Message: a, Signature: make([]byte, 96)}} // Make the signature a zero sig r.blkRootToPendingAtts[r32][0].Signature[0] = 0xC0 require.NoError(t, r.processPendingAtts(context.Background())) assert.Equal(t, true, p1.BroadcastCalled, "Could not broadcast the good aggregate") } func TestProcessPendingAtts_HasBlockSaveAggregatedAtt(t *testing.T) { hook := logTest.NewGlobal() db, _ := dbtest.SetupDB(t) p1 := p2ptest.NewTestP2P(t) validators := uint64(256) testutil.ResetCache() beaconState, privKeys := testutil.DeterministicGenesisState(t, validators) sb := testutil.NewBeaconBlock() require.NoError(t, db.SaveBlock(context.Background(), sb)) root, err := sb.Block.HashTreeRoot() require.NoError(t, err) aggBits := bitfield.NewBitlist(3) aggBits.SetBitAt(0, true) aggBits.SetBitAt(1, true) att := ðpb.Attestation{ Data: ðpb.AttestationData{ BeaconBlockRoot: root[:], Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)}, Target: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)}, }, AggregationBits: aggBits, } committee, err := helpers.BeaconCommitteeFromState(beaconState, att.Data.Slot, att.Data.CommitteeIndex) assert.NoError(t, err) attestingIndices := attestationutil.AttestingIndices(att.AggregationBits, committee) assert.NoError(t, err) attesterDomain, err := helpers.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorRoot()) require.NoError(t, err) hashTreeRoot, err := helpers.ComputeSigningRoot(att.Data, attesterDomain) assert.NoError(t, err) sigs := make([]bls.Signature, len(attestingIndices)) for i, indice := range attestingIndices { sig := privKeys[indice].Sign(hashTreeRoot[:]) sigs[i] = sig } att.Signature = bls.AggregateSignatures(sigs).Marshal() // Arbitrary aggregator index for testing purposes. aggregatorIndex := committee[0] sig, err := helpers.ComputeDomainAndSign(beaconState, 0, att.Data.Slot, params.BeaconConfig().DomainSelectionProof, privKeys[aggregatorIndex]) require.NoError(t, err) aggregateAndProof := ðpb.AggregateAttestationAndProof{ SelectionProof: sig, Aggregate: att, AggregatorIndex: aggregatorIndex, } aggreSig, err := helpers.ComputeDomainAndSign(beaconState, 0, aggregateAndProof, params.BeaconConfig().DomainAggregateAndProof, privKeys[aggregatorIndex]) require.NoError(t, err) require.NoError(t, beaconState.SetGenesisTime(uint64(time.Now().Unix()))) r := &Service{ p2p: p1, db: db, chain: &mock.ChainService{Genesis: time.Now(), State: beaconState, FinalizedCheckPoint: ðpb.Checkpoint{ Epoch: 0, }}, blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), attPool: attestations.NewPool(), stateSummaryCache: cache.NewStateSummaryCache(), } sb = testutil.NewBeaconBlock() r32, err := sb.Block.HashTreeRoot() require.NoError(t, err) require.NoError(t, r.db.SaveBlock(context.Background(), sb)) s := testutil.NewBeaconState() require.NoError(t, r.db.SaveState(context.Background(), s, r32)) r.blkRootToPendingAtts[r32] = []*ethpb.SignedAggregateAttestationAndProof{{Message: aggregateAndProof, Signature: aggreSig}} require.NoError(t, r.processPendingAtts(context.Background())) assert.Equal(t, 1, len(r.attPool.AggregatedAttestations()), "Did not save aggregated att") assert.DeepEqual(t, att, r.attPool.AggregatedAttestations()[0], "Incorrect saved att") atts, err := r.attPool.UnaggregatedAttestations() require.NoError(t, err) assert.Equal(t, 0, len(atts), "Did save unaggregated att") require.LogsContain(t, hook, "Verified and saved pending attestations to pool") } func TestValidatePendingAtts_CanPruneOldAtts(t *testing.T) { s := &Service{ blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), } // 100 Attestations per block root. r1 := [32]byte{'A'} r2 := [32]byte{'B'} r3 := [32]byte{'C'} for i := 0; i < 100; i++ { s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: uint64(i), Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(i), BeaconBlockRoot: r1[:]}}}}) s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: uint64(i*2 + i), Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(i), BeaconBlockRoot: r2[:]}}}}) s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: uint64(i*3 + i), Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(i), BeaconBlockRoot: r3[:]}}}}) } assert.Equal(t, 100, len(s.blkRootToPendingAtts[r1]), "Did not save pending atts") assert.Equal(t, 100, len(s.blkRootToPendingAtts[r2]), "Did not save pending atts") assert.Equal(t, 100, len(s.blkRootToPendingAtts[r3]), "Did not save pending atts") // Set current slot to 50, it should prune 19 attestations. (50 - 31) s.validatePendingAtts(context.Background(), 50) assert.Equal(t, 81, len(s.blkRootToPendingAtts[r1]), "Did not delete pending atts") assert.Equal(t, 81, len(s.blkRootToPendingAtts[r2]), "Did not delete pending atts") assert.Equal(t, 81, len(s.blkRootToPendingAtts[r3]), "Did not delete pending atts") // Set current slot to 100 + slot_duration, it should prune all the attestations. s.validatePendingAtts(context.Background(), 100+params.BeaconConfig().SlotsPerEpoch) assert.Equal(t, 0, len(s.blkRootToPendingAtts[r1]), "Did not delete pending atts") assert.Equal(t, 0, len(s.blkRootToPendingAtts[r2]), "Did not delete pending atts") assert.Equal(t, 0, len(s.blkRootToPendingAtts[r3]), "Did not delete pending atts") // Verify the keys are deleted. assert.Equal(t, 0, len(s.blkRootToPendingAtts), "Did not delete block keys") } func TestValidatePendingAtts_NoDuplicatingAggregatorIndex(t *testing.T) { s := &Service{ blkRootToPendingAtts: make(map[[32]byte][]*ethpb.SignedAggregateAttestationAndProof), } r1 := [32]byte{'A'} r2 := [32]byte{'B'} s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: 1, Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(1), BeaconBlockRoot: r1[:]}}}}) s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: 2, Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(2), BeaconBlockRoot: r2[:]}}}}) s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{ AggregatorIndex: 2, Aggregate: ðpb.Attestation{ Data: ðpb.AttestationData{Slot: uint64(3), BeaconBlockRoot: r2[:]}}}}) assert.Equal(t, 1, len(s.blkRootToPendingAtts[r1]), "Did not save pending atts") assert.Equal(t, 1, len(s.blkRootToPendingAtts[r2]), "Did not save pending atts") }