mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2025-01-05 09:14:28 +00:00
af203efa0c
* `helpers.go`: Improve naming consistency. * `detect_attestations.go`: Improve readability. * `receive.go`: Add `attsQueueSize` in log message. * `checkSlashableAttestations`: Improve logging. `avgBatchProcessingTime` is not displayed any more if not batch is processed. * `loadChunks`: Use explicit `chunkKind` and `chunkIndices`. * `getChunk`: Use specific `chunkIndex` and `chunkKind`. * `validatorIndicesInChunk` -> `validatorIndexesInChunk`. * `epochUpdateForValidator`: Use explicit arguments. * `getChunk`: Change order of arguments. * `latestEpochWrittenForValidator`: Use `ok` parameter. So the default value is not any more considered as the absence of value. * `applyAttestationForValidator`: Use explicit arguments. * `updateSpans`: Use explicit arguments. * `saveUpdatedChunks`: Use explicit arguments. * `checkSurrounds`: Use explicit arguments. We see here that, previously, in `checkSlashableAttestations`, `checkSurrounds` was called with the default value of `slashertypes`: `MinSpan`. Now, we set it expliciterly at `MinSpan`, which may explicit a bug. * `epochUpdateForValidator`: Set modified by the function argument first. * `applyAttestationForValidator`: Set mutated argument `chunksByChunkIdx`first. * `applyAttestationForValidator`: Rename variables. * `Test_processQueuedAttestations`: Fix test. Two tests were actually exactly the same. * `updateSpans`: Keep happy path in the outer scope. Even if in this case the "happy" path means slashing. * `checkSurrounds`: Rename variable. * `getChunk`: Avoid side effects. It adds a few lines for callers, but it does not modify any more arguments and it does what it says: getting a chunk. * `CheckSlashable`: Flatten. * `detect_attestations_test.go`: Simplify. * `CheckSlashable`: Add error log in case of missing attestation. * `processQueuedAttestations`: Extract a sub function. So testing will be easier. * `processAttesterSlashings` and `processProposerSlashings`: Improve. * `processAttesterSlashings`: Return processed slashings. * `createAttestationWrapper`: Rename variables. * `signingRoot` ==> `headerRoot` or `dataRoot`. Before this commit, there is two typse of `signing root`s floating around. - The first one is a real signing root, aka a hash tree root computed from an object root and a domain. This real signing root is the object ready to be signed. - The second one is a "false" signing root, which is actually just the hash tree root of an object. This object is either the `Data` field of an attestation, or the `Header` field of a block. Having 2 differents objects with the same name `signing root` is quite confusing. This commit renames wrongly named `signing root` objects. * `createAttestationWrapper` => `createAttestationWrapperEmptySig`. So it's clear for the user that the created attestation wrapper has an empty signature. * Implement `createAttestationWrapper`. * `processAttestations`: Return processed attester slashings. * Test `processAttestations` instead of `processQueuedAttestations`. By testing `processAttestations` instead of `processQueuedAttestations`, we get rid of a lot of tests fixtures, including the 200 ms sleep. The whole testing duration is shorter. * `Test_processAttestations`: Allow multiple steps. * `Test_processAttestations`: Add double steps tests. Some new failing tests are commented with a corresponding github issue. * `NextChunkStartEpoch`: Fix function comment. Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> * `chunks.go`: Avoid templating log messages. * `checkSlashableAttestations`: Simplify duration computation. --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
92 lines
3.6 KiB
Python
92 lines
3.6 KiB
Python
load("@prysm//tools/go:def.bzl", "go_library", "go_test")
|
|
|
|
go_library(
|
|
name = "go_default_library",
|
|
srcs = [
|
|
"chunks.go",
|
|
"detect_attestations.go",
|
|
"detect_blocks.go",
|
|
"doc.go",
|
|
"helpers.go",
|
|
"log.go",
|
|
"metrics.go",
|
|
"params.go",
|
|
"process_slashings.go",
|
|
"queue.go",
|
|
"receive.go",
|
|
"service.go",
|
|
],
|
|
importpath = "github.com/prysmaticlabs/prysm/v4/beacon-chain/slasher",
|
|
visibility = [
|
|
"//beacon-chain:__subpackages__",
|
|
"//testing/slasher/simulator:__subpackages__",
|
|
],
|
|
deps = [
|
|
"//async/event:go_default_library",
|
|
"//beacon-chain/blockchain:go_default_library",
|
|
"//beacon-chain/core/blocks:go_default_library",
|
|
"//beacon-chain/core/feed/state:go_default_library",
|
|
"//beacon-chain/db:go_default_library",
|
|
"//beacon-chain/operations/slashings:go_default_library",
|
|
"//beacon-chain/slasher/types:go_default_library",
|
|
"//beacon-chain/startup:go_default_library",
|
|
"//beacon-chain/state/stategen:go_default_library",
|
|
"//beacon-chain/sync:go_default_library",
|
|
"//config/fieldparams:go_default_library",
|
|
"//config/params:go_default_library",
|
|
"//consensus-types/primitives:go_default_library",
|
|
"//container/slice:go_default_library",
|
|
"//encoding/bytesutil:go_default_library",
|
|
"//proto/prysm/v1alpha1:go_default_library",
|
|
"//time/slots:go_default_library",
|
|
"@com_github_pkg_errors//:go_default_library",
|
|
"@com_github_prometheus_client_golang//prometheus:go_default_library",
|
|
"@com_github_prometheus_client_golang//prometheus/promauto:go_default_library",
|
|
"@com_github_prysmaticlabs_fastssz//:go_default_library",
|
|
"@com_github_sirupsen_logrus//:go_default_library",
|
|
"@io_opencensus_go//trace:go_default_library",
|
|
],
|
|
)
|
|
|
|
go_test(
|
|
name = "go_default_test",
|
|
srcs = [
|
|
"chunks_test.go",
|
|
"detect_attestations_test.go",
|
|
"detect_blocks_test.go",
|
|
"helpers_test.go",
|
|
"params_test.go",
|
|
"process_slashings_test.go",
|
|
"queue_test.go",
|
|
"receive_test.go",
|
|
"service_test.go",
|
|
],
|
|
embed = [":go_default_library"],
|
|
deps = [
|
|
"//async/event:go_default_library",
|
|
"//beacon-chain/blockchain/testing:go_default_library",
|
|
"//beacon-chain/core/signing:go_default_library",
|
|
"//beacon-chain/db/testing:go_default_library",
|
|
"//beacon-chain/forkchoice/doubly-linked-tree:go_default_library",
|
|
"//beacon-chain/operations/slashings/mock:go_default_library",
|
|
"//beacon-chain/slasher/types:go_default_library",
|
|
"//beacon-chain/startup:go_default_library",
|
|
"//beacon-chain/state/stategen:go_default_library",
|
|
"//beacon-chain/sync/initial-sync/testing:go_default_library",
|
|
"//config/fieldparams:go_default_library",
|
|
"//config/params:go_default_library",
|
|
"//consensus-types/primitives:go_default_library",
|
|
"//crypto/bls:go_default_library",
|
|
"//crypto/bls/common:go_default_library",
|
|
"//encoding/bytesutil:go_default_library",
|
|
"//proto/prysm/v1alpha1:go_default_library",
|
|
"//testing/assert:go_default_library",
|
|
"//testing/require:go_default_library",
|
|
"//testing/util:go_default_library",
|
|
"//time/slots:go_default_library",
|
|
"@com_github_prysmaticlabs_fastssz//:go_default_library",
|
|
"@com_github_sirupsen_logrus//:go_default_library",
|
|
"@com_github_sirupsen_logrus//hooks/test:go_default_library",
|
|
],
|
|
)
|