mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-26 05:17:22 +00:00
7b0ee3adfe
* Use new attestation protection * tests fixes * fix tests * fix comment * fix TestSetTargetData * fix tests * empty history handling * fix another test * mock domain request * fix empty handling * use far future epoch * use far future epoch * migrate data * copy byte array to resolve sigbus error * init validator protection on pre validation * raul feedback * rename fixes * nishant feedback * map with values * fix tests * lock and add test * add and fix concurrency tests * added tests error msg Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
192 lines
7.2 KiB
Go
192 lines
7.2 KiB
Go
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/pkg/errors"
|
|
ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
|
|
"github.com/prysmaticlabs/prysm/shared/featureconfig"
|
|
"github.com/prysmaticlabs/prysm/shared/params"
|
|
"github.com/prysmaticlabs/prysm/validator/db/kv"
|
|
)
|
|
|
|
var failedAttLocalProtectionErr = "attempted to make slashable attestation, rejected by local slashing protection"
|
|
var failedPreAttSignExternalErr = "attempted to make slashable attestation, rejected by external slasher service"
|
|
var failedPostAttSignExternalErr = "external slasher service detected a submitted slashable attestation"
|
|
|
|
func (v *validator) preAttSignValidations(ctx context.Context, indexedAtt *ethpb.IndexedAttestation, pubKey [48]byte) error {
|
|
fmtKey := fmt.Sprintf("%#x", pubKey[:])
|
|
|
|
v.attesterHistoryByPubKeyLock.RLock()
|
|
attesterHistory, ok := v.attesterHistoryByPubKey[pubKey]
|
|
v.attesterHistoryByPubKeyLock.RUnlock()
|
|
_, sr, err := v.getDomainAndSigningRoot(ctx, indexedAtt.Data)
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not get domain and signing root from attestation")
|
|
return err
|
|
}
|
|
if ok && isNewAttSlashable(ctx, attesterHistory, indexedAtt.Data.Source.Epoch, indexedAtt.Data.Target.Epoch, sr) {
|
|
if v.emitAccountMetrics {
|
|
ValidatorAttestFailVec.WithLabelValues(fmtKey).Inc()
|
|
}
|
|
return errors.New(failedAttLocalProtectionErr)
|
|
} else if !ok {
|
|
log.WithField("publicKey", fmtKey).Debug("Could not get local slashing protection data for validator in pre validation")
|
|
}
|
|
|
|
if featureconfig.Get().SlasherProtection && v.protector != nil {
|
|
if !v.protector.CheckAttestationSafety(ctx, indexedAtt) {
|
|
if v.emitAccountMetrics {
|
|
ValidatorAttestFailVecSlasher.WithLabelValues(fmtKey).Inc()
|
|
}
|
|
return errors.New(failedPreAttSignExternalErr)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (v *validator) postAttSignUpdate(ctx context.Context, indexedAtt *ethpb.IndexedAttestation, pubKey [48]byte, signingRoot [32]byte) error {
|
|
fmtKey := fmt.Sprintf("%#x", pubKey[:])
|
|
v.attesterHistoryByPubKeyLock.Lock()
|
|
defer v.attesterHistoryByPubKeyLock.Unlock()
|
|
attesterHistory, ok := v.attesterHistoryByPubKey[pubKey]
|
|
if ok {
|
|
if isNewAttSlashable(ctx, attesterHistory, indexedAtt.Data.Source.Epoch, indexedAtt.Data.Target.Epoch, signingRoot) {
|
|
if v.emitAccountMetrics {
|
|
ValidatorAttestFailVec.WithLabelValues(fmtKey).Inc()
|
|
}
|
|
return errors.New(failedAttLocalProtectionErr)
|
|
}
|
|
attesterHistory = markAttestationForTargetEpoch(ctx, attesterHistory, indexedAtt.Data.Source.Epoch, indexedAtt.Data.Target.Epoch, signingRoot)
|
|
v.attesterHistoryByPubKey[pubKey] = attesterHistory
|
|
} else {
|
|
log.WithField("publicKey", fmtKey).Debug("Could not get local slashing protection data for validator in post validation")
|
|
}
|
|
|
|
if featureconfig.Get().SlasherProtection && v.protector != nil {
|
|
if !v.protector.CommitAttestation(ctx, indexedAtt) {
|
|
if v.emitAccountMetrics {
|
|
ValidatorAttestFailVecSlasher.WithLabelValues(fmtKey).Inc()
|
|
}
|
|
return errors.New(failedPostAttSignExternalErr)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// isNewAttSlashable uses the attestation history to determine if an attestation of sourceEpoch
|
|
// and targetEpoch would be slashable. It can detect double, surrounding, and surrounded votes.
|
|
func isNewAttSlashable(ctx context.Context, history kv.EncHistoryData, sourceEpoch, targetEpoch uint64, signingRoot [32]byte) bool {
|
|
if history == nil {
|
|
return false
|
|
}
|
|
wsPeriod := params.BeaconConfig().WeakSubjectivityPeriod
|
|
// Previously pruned, we should return false.
|
|
latestEpochWritten, err := history.GetLatestEpochWritten(ctx)
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not get latest epoch written from encapsulated data")
|
|
return false
|
|
}
|
|
|
|
if latestEpochWritten >= wsPeriod && targetEpoch <= latestEpochWritten-wsPeriod { //Underflow protected older then weak subjectivity check.
|
|
return false
|
|
}
|
|
|
|
// Check if there has already been a vote for this target epoch.
|
|
hd, err := history.GetTargetData(ctx, targetEpoch)
|
|
if err != nil {
|
|
log.WithError(err).Errorf("Could not get target data for target epoch: %d", targetEpoch)
|
|
return false
|
|
}
|
|
if !hd.IsEmpty() && !bytes.Equal(signingRoot[:], hd.SigningRoot) {
|
|
return true
|
|
}
|
|
|
|
// Check if the new attestation would be surrounding another attestation.
|
|
for i := sourceEpoch; i <= targetEpoch; i++ {
|
|
// Unattested for epochs are marked as (*kv.HistoryData)(nil).
|
|
historyBoundary := safeTargetToSource(ctx, history, i)
|
|
if historyBoundary.IsEmpty() {
|
|
continue
|
|
}
|
|
if historyBoundary.Source > sourceEpoch {
|
|
return true
|
|
}
|
|
}
|
|
|
|
// Check if the new attestation is being surrounded.
|
|
for i := targetEpoch; i <= latestEpochWritten; i++ {
|
|
h := safeTargetToSource(ctx, history, i)
|
|
if h.IsEmpty() {
|
|
continue
|
|
}
|
|
if h.Source < sourceEpoch {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// markAttestationForTargetEpoch returns the modified attestation history with the passed-in epochs marked
|
|
// as attested for. This is done to prevent the validator client from signing any slashable attestations.
|
|
func markAttestationForTargetEpoch(ctx context.Context, history kv.EncHistoryData, sourceEpoch, targetEpoch uint64, signingRoot [32]byte) kv.EncHistoryData {
|
|
if history == nil {
|
|
return nil
|
|
}
|
|
wsPeriod := params.BeaconConfig().WeakSubjectivityPeriod
|
|
latestEpochWritten, err := history.GetLatestEpochWritten(ctx)
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not get latest epoch written from encapsulated data")
|
|
return nil
|
|
}
|
|
if targetEpoch > latestEpochWritten {
|
|
// If the target epoch to mark is ahead of latest written epoch, override the old targets and mark the requested epoch.
|
|
// Limit the overwriting to one weak subjectivity period as further is not needed.
|
|
maxToWrite := latestEpochWritten + wsPeriod
|
|
for i := latestEpochWritten + 1; i < targetEpoch && i <= maxToWrite; i++ {
|
|
history, err = history.SetTargetData(ctx, i%wsPeriod, &kv.HistoryData{Source: params.BeaconConfig().FarFutureEpoch})
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not set target to the encapsulated data")
|
|
return nil
|
|
}
|
|
}
|
|
history, err = history.SetLatestEpochWritten(ctx, targetEpoch)
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not set latest epoch written to the encapsulated data")
|
|
return nil
|
|
}
|
|
}
|
|
history, err = history.SetTargetData(ctx, targetEpoch%wsPeriod, &kv.HistoryData{Source: sourceEpoch, SigningRoot: signingRoot[:]})
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not set target to the encapsulated data")
|
|
return nil
|
|
}
|
|
return history
|
|
}
|
|
|
|
// safeTargetToSource makes sure the epoch accessed is within bounds, and if it's not it at
|
|
// returns the "default" nil value.
|
|
func safeTargetToSource(ctx context.Context, history kv.EncHistoryData, targetEpoch uint64) *kv.HistoryData {
|
|
wsPeriod := params.BeaconConfig().WeakSubjectivityPeriod
|
|
latestEpochWritten, err := history.GetLatestEpochWritten(ctx)
|
|
if err != nil {
|
|
log.WithError(err).Error("Could not get latest epoch written from encapsulated data")
|
|
return nil
|
|
}
|
|
if targetEpoch > latestEpochWritten {
|
|
return nil
|
|
}
|
|
if latestEpochWritten >= wsPeriod && targetEpoch < latestEpochWritten-wsPeriod { //Underflow protected older then weak subjectivity check.
|
|
return nil
|
|
}
|
|
hd, err := history.GetTargetData(ctx, targetEpoch%wsPeriod)
|
|
if err != nil {
|
|
log.WithError(err).Errorf("Could not get target data for target epoch: %d", targetEpoch)
|
|
return nil
|
|
}
|
|
return hd
|
|
}
|