mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-22 11:32:09 +00:00
4beb352e6f
* Move Slot and Epoch functions from helpers to core * limited viz * goimports * fix fuzz build * fix fuzz build * fix * fix Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
198 lines
8.1 KiB
Go
198 lines
8.1 KiB
Go
package sync
|
|
|
|
import (
|
|
"context"
|
|
"encoding/hex"
|
|
"sync"
|
|
|
|
pubsub "github.com/libp2p/go-libp2p-pubsub"
|
|
types "github.com/prysmaticlabs/eth2-types"
|
|
"github.com/prysmaticlabs/prysm/beacon-chain/core"
|
|
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
|
|
ethpb "github.com/prysmaticlabs/prysm/proto/prysm/v1alpha1"
|
|
"github.com/prysmaticlabs/prysm/shared/bytesutil"
|
|
"github.com/prysmaticlabs/prysm/shared/params"
|
|
"github.com/prysmaticlabs/prysm/shared/rand"
|
|
"github.com/prysmaticlabs/prysm/shared/runutil"
|
|
"github.com/prysmaticlabs/prysm/shared/slotutil"
|
|
"github.com/sirupsen/logrus"
|
|
"go.opencensus.io/trace"
|
|
)
|
|
|
|
// This defines how often a node cleans up and processes pending attestations in the queue.
|
|
var processPendingAttsPeriod = slotutil.DivideSlotBy(2 /* twice per slot */)
|
|
|
|
// This processes pending attestation queues on every `processPendingAttsPeriod`.
|
|
func (s *Service) processPendingAttsQueue() {
|
|
// Prevents multiple queue processing goroutines (invoked by RunEvery) from contending for data.
|
|
mutex := new(sync.Mutex)
|
|
runutil.RunEvery(s.ctx, processPendingAttsPeriod, func() {
|
|
mutex.Lock()
|
|
if err := s.processPendingAtts(s.ctx); err != nil {
|
|
log.WithError(err).Debugf("Could not process pending attestation: %v", err)
|
|
}
|
|
mutex.Unlock()
|
|
})
|
|
}
|
|
|
|
// This defines how pending attestations are processed. It contains features:
|
|
// 1. Clean up invalid pending attestations from the queue.
|
|
// 2. Check if pending attestations can be processed when the block has arrived.
|
|
// 3. Request block from a random peer if unable to proceed step 2.
|
|
func (s *Service) processPendingAtts(ctx context.Context) error {
|
|
ctx, span := trace.StartSpan(ctx, "processPendingAtts")
|
|
defer span.End()
|
|
|
|
// Before a node processes pending attestations queue, it verifies
|
|
// the attestations in the queue are still valid. Attestations will
|
|
// be deleted from the queue if invalid (ie. getting staled from falling too many slots behind).
|
|
s.validatePendingAtts(ctx, s.cfg.Chain.CurrentSlot())
|
|
|
|
s.pendingAttsLock.RLock()
|
|
roots := make([][32]byte, 0, len(s.blkRootToPendingAtts))
|
|
for br := range s.blkRootToPendingAtts {
|
|
roots = append(roots, br)
|
|
}
|
|
s.pendingAttsLock.RUnlock()
|
|
|
|
var pendingRoots [][32]byte
|
|
randGen := rand.NewGenerator()
|
|
for _, bRoot := range roots {
|
|
s.pendingAttsLock.RLock()
|
|
attestations := s.blkRootToPendingAtts[bRoot]
|
|
s.pendingAttsLock.RUnlock()
|
|
// has the pending attestation's missing block arrived and the node processed block yet?
|
|
if s.cfg.DB.HasBlock(ctx, bRoot) && (s.cfg.DB.HasState(ctx, bRoot) || s.cfg.DB.HasStateSummary(ctx, bRoot)) {
|
|
for _, signedAtt := range attestations {
|
|
att := signedAtt.Message
|
|
// The pending attestations can arrive in both aggregated and unaggregated forms,
|
|
// each from has distinct validation steps.
|
|
if helpers.IsAggregated(att.Aggregate) {
|
|
// Save the pending aggregated attestation to the pool if it passes the aggregated
|
|
// validation steps.
|
|
aggValid := s.validateAggregatedAtt(ctx, signedAtt) == pubsub.ValidationAccept
|
|
if s.validateBlockInAttestation(ctx, signedAtt) && aggValid {
|
|
if err := s.cfg.AttPool.SaveAggregatedAttestation(att.Aggregate); err != nil {
|
|
log.WithError(err).Debug("Could not save aggregate attestation")
|
|
continue
|
|
}
|
|
s.setAggregatorIndexEpochSeen(att.Aggregate.Data.Target.Epoch, att.AggregatorIndex)
|
|
|
|
// Broadcasting the signed attestation again once a node is able to process it.
|
|
if err := s.cfg.P2P.Broadcast(ctx, signedAtt); err != nil {
|
|
log.WithError(err).Debug("Could not broadcast")
|
|
}
|
|
}
|
|
} else {
|
|
// This is an important validation before retrieving attestation pre state to defend against
|
|
// attestation's target intentionally reference checkpoint that's long ago.
|
|
// Verify current finalized checkpoint is an ancestor of the block defined by the attestation's beacon block root.
|
|
if err := s.cfg.Chain.VerifyFinalizedConsistency(ctx, att.Aggregate.Data.BeaconBlockRoot); err != nil {
|
|
log.WithError(err).Debug("Could not verify finalized consistency")
|
|
continue
|
|
}
|
|
if err := s.cfg.Chain.VerifyLmdFfgConsistency(ctx, att.Aggregate); err != nil {
|
|
log.WithError(err).Debug("Could not verify FFG consistency")
|
|
continue
|
|
}
|
|
preState, err := s.cfg.Chain.AttestationPreState(ctx, att.Aggregate)
|
|
if err != nil {
|
|
log.WithError(err).Debug("Could not retrieve attestation prestate")
|
|
continue
|
|
}
|
|
|
|
valid := s.validateUnaggregatedAttWithState(ctx, att.Aggregate, preState)
|
|
if valid == pubsub.ValidationAccept {
|
|
if err := s.cfg.AttPool.SaveUnaggregatedAttestation(att.Aggregate); err != nil {
|
|
log.WithError(err).Debug("Could not save unaggregated attestation")
|
|
continue
|
|
}
|
|
s.setSeenCommitteeIndicesSlot(att.Aggregate.Data.Slot, att.Aggregate.Data.CommitteeIndex, att.Aggregate.AggregationBits)
|
|
|
|
valCount, err := helpers.ActiveValidatorCount(preState, core.SlotToEpoch(att.Aggregate.Data.Slot))
|
|
if err != nil {
|
|
log.WithError(err).Debug("Could not retrieve active validator count")
|
|
continue
|
|
}
|
|
// Broadcasting the signed attestation again once a node is able to process it.
|
|
if err := s.cfg.P2P.BroadcastAttestation(ctx, helpers.ComputeSubnetForAttestation(valCount, signedAtt.Message.Aggregate), signedAtt.Message.Aggregate); err != nil {
|
|
log.WithError(err).Debug("Could not broadcast")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
log.WithFields(logrus.Fields{
|
|
"blockRoot": hex.EncodeToString(bytesutil.Trunc(bRoot[:])),
|
|
"pendingAttsCount": len(attestations),
|
|
}).Debug("Verified and saved pending attestations to pool")
|
|
|
|
// Delete the missing block root key from pending attestation queue so a node will not request for the block again.
|
|
s.pendingAttsLock.Lock()
|
|
delete(s.blkRootToPendingAtts, bRoot)
|
|
s.pendingAttsLock.Unlock()
|
|
} else {
|
|
// Pending attestation's missing block has not arrived yet.
|
|
log.WithFields(logrus.Fields{
|
|
"currentSlot": s.cfg.Chain.CurrentSlot(),
|
|
"attSlot": attestations[0].Message.Aggregate.Data.Slot,
|
|
"attCount": len(attestations),
|
|
"blockRoot": hex.EncodeToString(bytesutil.Trunc(bRoot[:])),
|
|
}).Debug("Requesting block for pending attestation")
|
|
pendingRoots = append(pendingRoots, bRoot)
|
|
}
|
|
}
|
|
return s.sendBatchRootRequest(ctx, pendingRoots, randGen)
|
|
}
|
|
|
|
// This defines how pending attestations is saved in the map. The key is the
|
|
// root of the missing block. The value is the list of pending attestations
|
|
// that voted for that block root.
|
|
func (s *Service) savePendingAtt(att *ethpb.SignedAggregateAttestationAndProof) {
|
|
root := bytesutil.ToBytes32(att.Message.Aggregate.Data.BeaconBlockRoot)
|
|
|
|
s.pendingAttsLock.Lock()
|
|
defer s.pendingAttsLock.Unlock()
|
|
_, ok := s.blkRootToPendingAtts[root]
|
|
if !ok {
|
|
s.blkRootToPendingAtts[root] = []*ethpb.SignedAggregateAttestationAndProof{att}
|
|
return
|
|
}
|
|
|
|
// Skip if the attestation from the same aggregator already exists in the pending queue.
|
|
for _, a := range s.blkRootToPendingAtts[root] {
|
|
if a.Message.AggregatorIndex == att.Message.AggregatorIndex {
|
|
return
|
|
}
|
|
}
|
|
|
|
s.blkRootToPendingAtts[root] = append(s.blkRootToPendingAtts[root], att)
|
|
}
|
|
|
|
// This validates the pending attestations in the queue are still valid.
|
|
// If not valid, a node will remove it in the queue in place. The validity
|
|
// check specifies the pending attestation could not fall one epoch behind
|
|
// of the current slot.
|
|
func (s *Service) validatePendingAtts(ctx context.Context, slot types.Slot) {
|
|
ctx, span := trace.StartSpan(ctx, "validatePendingAtts")
|
|
defer span.End()
|
|
|
|
s.pendingAttsLock.Lock()
|
|
defer s.pendingAttsLock.Unlock()
|
|
|
|
for bRoot, atts := range s.blkRootToPendingAtts {
|
|
for i := len(atts) - 1; i >= 0; i-- {
|
|
if slot >= atts[i].Message.Aggregate.Data.Slot+params.BeaconConfig().SlotsPerEpoch {
|
|
// Remove the pending attestation from the list in place.
|
|
atts = append(atts[:i], atts[i+1:]...)
|
|
}
|
|
}
|
|
s.blkRootToPendingAtts[bRoot] = atts
|
|
|
|
// If the pending attestations list of a given block root is empty,
|
|
// a node will remove the key from the map to avoid dangling keys.
|
|
if len(s.blkRootToPendingAtts[bRoot]) == 0 {
|
|
delete(s.blkRootToPendingAtts, bRoot)
|
|
}
|
|
}
|
|
}
|