prysm-pulse/beacon-chain/sync/rpc_ping.go
Nishant Das eb7ab16f92
Change Back Metadata Error Check (#7852)
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-11-19 04:17:26 +00:00

161 lines
4.9 KiB
Go

package sync
import (
"context"
"errors"
"fmt"
"strings"
libp2pcore "github.com/libp2p/go-libp2p-core"
"github.com/libp2p/go-libp2p-core/helpers"
"github.com/libp2p/go-libp2p-core/mux"
"github.com/libp2p/go-libp2p-core/peer"
"github.com/prysmaticlabs/prysm/beacon-chain/p2p"
"github.com/prysmaticlabs/prysm/beacon-chain/p2p/types"
"github.com/prysmaticlabs/prysm/shared/timeutils"
)
// pingHandler reads the incoming ping rpc message from the peer.
func (s *Service) pingHandler(_ context.Context, msg interface{}, stream libp2pcore.Stream) error {
SetRPCStreamDeadlines(stream)
m, ok := msg.(*types.SSZUint64)
if !ok {
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
return fmt.Errorf("wrong message type for ping, got %T, wanted *uint64", msg)
}
if err := s.rateLimiter.validateRequest(stream, 1); err != nil {
return err
}
s.rateLimiter.add(stream, 1)
valid, err := s.validateSequenceNum(*m, stream.Conn().RemotePeer())
if err != nil {
// Descore peer for giving us a bad sequence number.
if errors.Is(err, types.ErrInvalidSequenceNum) {
s.p2p.Peers().Scorers().BadResponsesScorer().Increment(stream.Conn().RemotePeer())
s.writeErrorResponseToStream(responseCodeInvalidRequest, types.ErrInvalidSequenceNum.Error(), stream)
}
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
return err
}
if _, err := stream.Write([]byte{responseCodeSuccess}); err != nil {
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
return err
}
sq := types.SSZUint64(s.p2p.MetadataSeq())
if _, err := s.p2p.Encoding().EncodeWithMaxLength(stream, &sq); err != nil {
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
return err
}
if valid {
// If the sequence number was valid we're done.
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
return nil
}
// The sequence number was not valid. Start our own ping back to the peer.
go func() {
defer func() {
if err := stream.Close(); err != nil {
log.WithError(err).Debug("Failed to close stream")
}
}()
// New context so the calling function doesn't cancel on us.
ctx, cancel := context.WithTimeout(context.Background(), ttfbTimeout)
defer cancel()
md, err := s.sendMetaDataRequest(ctx, stream.Conn().RemotePeer())
if err != nil {
// We cannot compare errors directly as the stream muxer error
// type isn't compatible with the error we have, so a direct
// equality checks fails.
if !strings.Contains(err.Error(), types.ErrIODeadline.Error()) {
log.WithField("peer", stream.Conn().RemotePeer()).WithError(err).Debug("Failed to send metadata request")
}
return
}
// update metadata if there is no error
s.p2p.Peers().SetMetadata(stream.Conn().RemotePeer(), md)
}()
return nil
}
func (s *Service) sendPingRequest(ctx context.Context, id peer.ID) error {
ctx, cancel := context.WithTimeout(ctx, respTimeout)
defer cancel()
metadataSeq := types.SSZUint64(s.p2p.MetadataSeq())
stream, err := s.p2p.Send(ctx, &metadataSeq, p2p.RPCPingTopic, id)
if err != nil {
return err
}
currentTime := timeutils.Now()
defer func() {
if err := helpers.FullClose(stream); err != nil && err.Error() != mux.ErrReset.Error() {
log.WithError(err).Debugf("Failed to reset stream with protocol %s", stream.Protocol())
}
}()
code, errMsg, err := ReadStatusCode(stream, s.p2p.Encoding())
if err != nil {
return err
}
// Records the latency of the ping request for that peer.
s.p2p.Host().Peerstore().RecordLatency(id, timeutils.Now().Sub(currentTime))
if code != 0 {
s.p2p.Peers().Scorers().BadResponsesScorer().Increment(stream.Conn().RemotePeer())
return errors.New(errMsg)
}
msg := new(types.SSZUint64)
if err := s.p2p.Encoding().DecodeWithMaxLength(stream, msg); err != nil {
return err
}
valid, err := s.validateSequenceNum(*msg, stream.Conn().RemotePeer())
if err != nil {
// Descore peer for giving us a bad sequence number.
if errors.Is(err, types.ErrInvalidSequenceNum) {
s.p2p.Peers().Scorers().BadResponsesScorer().Increment(stream.Conn().RemotePeer())
}
return err
}
if valid {
return nil
}
md, err := s.sendMetaDataRequest(ctx, stream.Conn().RemotePeer())
if err != nil {
// do not increment bad responses, as its
// already done in the request method.
return err
}
s.p2p.Peers().SetMetadata(stream.Conn().RemotePeer(), md)
return nil
}
// validates the peer's sequence number.
func (s *Service) validateSequenceNum(seq types.SSZUint64, id peer.ID) (bool, error) {
md, err := s.p2p.Peers().Metadata(id)
if err != nil {
return false, err
}
if md == nil {
return false, nil
}
// Return error on invalid sequence number.
if md.SeqNumber > uint64(seq) {
return false, types.ErrInvalidSequenceNum
}
return md.SeqNumber == uint64(seq), nil
}