mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2025-01-05 09:14:28 +00:00
1112e01c06
* `TestStore_GenesisValidatorsRoot_ReadAndWrite`: Make all test cases independents. In a test with multiple test cases, each test case should be independents. (aka: Removing test case `A` should not impact test case `B`) * `SaveGenesisValidatorsRoot`: Allow to overwrite the genesis validator root if the root is the same. * `ProposalHistoryForSlot`: Add `signingRootExists` Currently, it is not possible with `ProposalHistoryForSlot` to know if a proposal is stored with and `0x00000....` signing root or with an empty signing root. Both cases result to `proposalExists == true` and `signingRoot == 0x00000`. This commit adds a new return boolean: `signingRootExists`. If a proposal has been saved with a `0x00000...` signing root, then: - `proposalExists` is set to `true`, and - `signingRootExists` is set to `true`, and - `signingRoot` is set to `0x00000...` If a proposal has been saved with an empty signing root, then: - `proposalExists` is set to `true`, and - `signingRootExists` is set to `false`, and - (`signingRoot` is set to `0x00000...`) * `ImportStandardProtectionJSON`: When importing EIP-3076 Slashing Protection Interchange Format, do not filter any more slashable keys. Note: Those keys are still saved into the black-listed public keys list. There is two reason not to do so: - The EIP-3076 test cases do not know about Prysm's internal black-listed public keys list. Tests will expect, without looking into this internal black-listed public keys list, to deny a further signature. If we filter these keys from the DB (even if we keep them into the black-listed keys list), then some tests will fail. - If we import a interchange file containing slashable keys and we filter them, then, if we re-export the DB, those slashing offences won't appear in the exported interchange file. * `transformSignedBlocks`: Store an 0-len byte slice When importing an EIP-3076 interchange format, and when no signing root is specified into the file, we currently store a `0x00000.....` signing root. In such a case, instead storing `0x00000...`, this commit stores a 0-len byte array, so we can differentiate real `0x000.....` signing root and no signing-root at all. * `slashableProposalCheck`: Manage lack of sign root Currently, `slashableProposalCheck` does not really make a difference between a `0x0000.....` signing root and a missing signing root. (Signing roots can be missing when importing an EIP-3076 interchange file.) This commit differentiate, for `slashableProposalCheck`, `0x0000....` signing root and a missing signing root. * `AttestationRecord.SigningRoot`: ==> `[]byte` When importing attestations from EIP-3076 interchange format, the signing root of an attestation may be missing. Currently, Prysm consider any missing attestation signing root as `0x000...`. However, it may conflict with signing root which really are equal to `0x000...`. This commit transforms `AttestationRecord.SigningRoot` from `[32]byte` to `[]byte`, and change the minimal set of functions (sic) to support this new type. * `CheckSlashableAttestation`: Empty signing root Regarding slashing roots, 2 attestations are slashable, if: - both signing roots are defined and differs, or - one attestation exists, but without a signing root * `filterSlashablePubKeysFromAttestations`: Err sort Rergarding `CheckSlashableAttestation`, we consider that: - If slashable == NotSlashable and err != nil, then CheckSlashableAttestation failed. - If slashable != NotSlashable, then err contains the reason why the attestation is slashable. * `setupEIP3076SpecTests`: Update to `v5.3.0` This commit: - Updates the version of EIP-3076 tests to `v.5.2.1`. - Setups on anti-slashing DB per test case, instead per step. * `ImportStandardProtectionJSON`: Reduce cycl cmplxt * `AttestationHistoryForPubKey`: copy signing root BoltDB documentation specifies: | Byte slices returned from Bolt are only valid during a transaction. | Once the transaction has been committed or rolled back then the memory | they point to can be reused by a new page or can be unmapped | from virtual memory and you'll see an unexpected fault address panic | when accessing it.
303 lines
10 KiB
Go
303 lines
10 KiB
Go
package kv
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
fieldparams "github.com/prysmaticlabs/prysm/v4/config/fieldparams"
|
|
"github.com/prysmaticlabs/prysm/v4/config/params"
|
|
"github.com/prysmaticlabs/prysm/v4/consensus-types/primitives"
|
|
"github.com/prysmaticlabs/prysm/v4/encoding/bytesutil"
|
|
"github.com/prysmaticlabs/prysm/v4/testing/assert"
|
|
"github.com/prysmaticlabs/prysm/v4/testing/require"
|
|
)
|
|
|
|
func TestNewProposalHistoryForSlot_ReturnsNilIfNoHistory(t *testing.T) {
|
|
valPubkey := [fieldparams.BLSPubkeyLength]byte{1, 2, 3}
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{})
|
|
|
|
_, proposalExists, signingRootExists, err := db.ProposalHistoryForSlot(context.Background(), valPubkey, 0)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, false, proposalExists)
|
|
assert.Equal(t, false, signingRootExists)
|
|
}
|
|
|
|
func TestProposalHistoryForSlot_InitializesNewPubKeys(t *testing.T) {
|
|
pubkeys := [][fieldparams.BLSPubkeyLength]byte{{30}, {25}, {20}}
|
|
db := setupDB(t, pubkeys)
|
|
|
|
for _, pub := range pubkeys {
|
|
_, proposalExists, signingRootExists, err := db.ProposalHistoryForSlot(context.Background(), pub, 0)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, false, proposalExists)
|
|
assert.Equal(t, false, signingRootExists)
|
|
}
|
|
}
|
|
|
|
func TestNewProposalHistoryForSlot_SigningRootNil(t *testing.T) {
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{1, 2, 3}
|
|
slot := primitives.Slot(2)
|
|
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{})
|
|
|
|
err := db.SaveProposalHistoryForSlot(context.Background(), pubkey, slot, nil)
|
|
require.NoError(t, err, "Saving proposal history failed: %v")
|
|
|
|
_, proposalExists, signingRootExists, err := db.ProposalHistoryForSlot(context.Background(), pubkey, slot)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, true, proposalExists)
|
|
assert.Equal(t, false, signingRootExists)
|
|
}
|
|
|
|
func TestSaveProposalHistoryForSlot_OK(t *testing.T) {
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{3}
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubkey})
|
|
|
|
slot := primitives.Slot(2)
|
|
|
|
err := db.SaveProposalHistoryForSlot(context.Background(), pubkey, slot, []byte{1})
|
|
require.NoError(t, err, "Saving proposal history failed: %v")
|
|
signingRoot, proposalExists, signingRootExists, err := db.ProposalHistoryForSlot(context.Background(), pubkey, slot)
|
|
require.NoError(t, err, "Failed to get proposal history")
|
|
assert.Equal(t, true, proposalExists)
|
|
assert.Equal(t, true, signingRootExists)
|
|
|
|
require.NotNil(t, signingRoot)
|
|
require.DeepEqual(t, bytesutil.PadTo([]byte{1}, 32), signingRoot[:], "Expected DB to keep object the same")
|
|
}
|
|
|
|
func TestNewProposalHistoryForPubKey_ReturnsEmptyIfNoHistory(t *testing.T) {
|
|
valPubkey := [fieldparams.BLSPubkeyLength]byte{1, 2, 3}
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{})
|
|
|
|
proposalHistory, err := db.ProposalHistoryForPubKey(context.Background(), valPubkey)
|
|
require.NoError(t, err)
|
|
assert.DeepEqual(t, make([]*Proposal, 0), proposalHistory)
|
|
}
|
|
|
|
func TestSaveProposalHistoryForPubKey_OK(t *testing.T) {
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{3}
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubkey})
|
|
|
|
slot := primitives.Slot(2)
|
|
|
|
root := [32]byte{1}
|
|
err := db.SaveProposalHistoryForSlot(context.Background(), pubkey, slot, root[:])
|
|
require.NoError(t, err, "Saving proposal history failed: %v")
|
|
proposalHistory, err := db.ProposalHistoryForPubKey(context.Background(), pubkey)
|
|
require.NoError(t, err, "Failed to get proposal history")
|
|
|
|
require.NotNil(t, proposalHistory)
|
|
want := []*Proposal{
|
|
{
|
|
Slot: slot,
|
|
SigningRoot: root[:],
|
|
},
|
|
}
|
|
require.DeepEqual(t, want[0], proposalHistory[0])
|
|
}
|
|
|
|
func TestSaveProposalHistoryForSlot_Overwrites(t *testing.T) {
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{0}
|
|
tests := []struct {
|
|
signingRoot []byte
|
|
}{
|
|
{
|
|
signingRoot: bytesutil.PadTo([]byte{1}, 32),
|
|
},
|
|
{
|
|
signingRoot: bytesutil.PadTo([]byte{2}, 32),
|
|
},
|
|
{
|
|
signingRoot: bytesutil.PadTo([]byte{3}, 32),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubkey})
|
|
err := db.SaveProposalHistoryForSlot(context.Background(), pubkey, 0, tt.signingRoot)
|
|
require.NoError(t, err, "Saving proposal history failed")
|
|
proposalHistory, err := db.ProposalHistoryForPubKey(context.Background(), pubkey)
|
|
require.NoError(t, err, "Failed to get proposal history")
|
|
|
|
require.NotNil(t, proposalHistory)
|
|
require.DeepEqual(t, tt.signingRoot, proposalHistory[0].SigningRoot, "Expected DB to keep object the same")
|
|
require.NoError(t, db.Close(), "Failed to close database")
|
|
}
|
|
}
|
|
|
|
func TestPruneProposalHistoryBySlot_OK(t *testing.T) {
|
|
slotsPerEpoch := params.BeaconConfig().SlotsPerEpoch
|
|
wsPeriod := params.BeaconConfig().WeakSubjectivityPeriod
|
|
pubKey := [fieldparams.BLSPubkeyLength]byte{0}
|
|
tests := []struct {
|
|
slots []primitives.Slot
|
|
storedSlots []primitives.Slot
|
|
removedSlots []primitives.Slot
|
|
}{
|
|
{
|
|
// Go 2 epochs past pruning point.
|
|
slots: []primitives.Slot{slotsPerEpoch / 2, slotsPerEpoch*5 + 6, slotsPerEpoch.Mul(uint64(wsPeriod+3)) + 8},
|
|
storedSlots: []primitives.Slot{slotsPerEpoch*5 + 6, slotsPerEpoch.Mul(uint64(wsPeriod+3)) + 8},
|
|
removedSlots: []primitives.Slot{slotsPerEpoch / 2},
|
|
},
|
|
{
|
|
// Go 10 epochs past pruning point.
|
|
slots: []primitives.Slot{
|
|
slotsPerEpoch + 4,
|
|
slotsPerEpoch * 2,
|
|
slotsPerEpoch * 3,
|
|
slotsPerEpoch * 4,
|
|
slotsPerEpoch * 5,
|
|
slotsPerEpoch.Mul(uint64(wsPeriod+10)) + 8,
|
|
},
|
|
storedSlots: []primitives.Slot{slotsPerEpoch.Mul(uint64(wsPeriod+10)) + 8},
|
|
removedSlots: []primitives.Slot{
|
|
slotsPerEpoch + 4,
|
|
slotsPerEpoch * 2,
|
|
slotsPerEpoch * 3,
|
|
slotsPerEpoch * 4,
|
|
slotsPerEpoch * 5,
|
|
},
|
|
},
|
|
{
|
|
// Prune none.
|
|
slots: []primitives.Slot{slotsPerEpoch + 4, slotsPerEpoch*2 + 3, slotsPerEpoch*3 + 4, slotsPerEpoch*4 + 3, slotsPerEpoch*5 + 3},
|
|
storedSlots: []primitives.Slot{slotsPerEpoch + 4, slotsPerEpoch*2 + 3, slotsPerEpoch*3 + 4, slotsPerEpoch*4 + 3, slotsPerEpoch*5 + 3},
|
|
},
|
|
}
|
|
signedRoot := bytesutil.PadTo([]byte{1}, 32)
|
|
|
|
for _, tt := range tests {
|
|
db := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubKey})
|
|
for _, slot := range tt.slots {
|
|
err := db.SaveProposalHistoryForSlot(context.Background(), pubKey, slot, signedRoot)
|
|
require.NoError(t, err, "Saving proposal history failed")
|
|
}
|
|
|
|
signingRootsBySlot := make(map[primitives.Slot][]byte)
|
|
proposalHistory, err := db.ProposalHistoryForPubKey(context.Background(), pubKey)
|
|
require.NoError(t, err)
|
|
|
|
for _, hist := range proposalHistory {
|
|
signingRootsBySlot[hist.Slot] = hist.SigningRoot
|
|
}
|
|
|
|
for _, slot := range tt.removedSlots {
|
|
_, ok := signingRootsBySlot[slot]
|
|
require.Equal(t, false, ok)
|
|
}
|
|
for _, slot := range tt.storedSlots {
|
|
root, ok := signingRootsBySlot[slot]
|
|
require.Equal(t, true, ok)
|
|
require.DeepEqual(t, signedRoot, root, "Unexpected difference in bytes for epoch %d", slot)
|
|
}
|
|
require.NoError(t, db.Close(), "Failed to close database")
|
|
}
|
|
}
|
|
|
|
func TestStore_ProposedPublicKeys(t *testing.T) {
|
|
ctx := context.Background()
|
|
validatorDB, err := NewKVStore(ctx, t.TempDir(), &Config{})
|
|
require.NoError(t, err, "Failed to instantiate DB")
|
|
t.Cleanup(func() {
|
|
require.NoError(t, validatorDB.Close(), "Failed to close database")
|
|
require.NoError(t, validatorDB.ClearDB(), "Failed to clear database")
|
|
})
|
|
|
|
keys, err := validatorDB.ProposedPublicKeys(ctx)
|
|
require.NoError(t, err)
|
|
assert.DeepEqual(t, make([][fieldparams.BLSPubkeyLength]byte, 0), keys)
|
|
|
|
pubKey := [fieldparams.BLSPubkeyLength]byte{1}
|
|
var dummyRoot [32]byte
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubKey, 1, dummyRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
keys, err = validatorDB.ProposedPublicKeys(ctx)
|
|
require.NoError(t, err)
|
|
assert.DeepEqual(t, [][fieldparams.BLSPubkeyLength]byte{pubKey}, keys)
|
|
}
|
|
|
|
func TestStore_LowestSignedProposal(t *testing.T) {
|
|
ctx := context.Background()
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{3}
|
|
var dummySigningRoot [32]byte
|
|
validatorDB := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubkey})
|
|
|
|
_, exists, err := validatorDB.LowestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, false, exists)
|
|
|
|
// We save our first proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 2 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the lowest signed slot is what we just saved.
|
|
slot, exists, err := validatorDB.LowestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(2), slot)
|
|
|
|
// We save a higher proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 3 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the lowest signed slot did not change.
|
|
slot, exists, err = validatorDB.LowestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(2), slot)
|
|
|
|
// We save a lower proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 1 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the lowest signed slot indeed changed.
|
|
slot, exists, err = validatorDB.LowestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(1), slot)
|
|
}
|
|
|
|
func TestStore_HighestSignedProposal(t *testing.T) {
|
|
ctx := context.Background()
|
|
pubkey := [fieldparams.BLSPubkeyLength]byte{3}
|
|
var dummySigningRoot [32]byte
|
|
validatorDB := setupDB(t, [][fieldparams.BLSPubkeyLength]byte{pubkey})
|
|
|
|
_, exists, err := validatorDB.HighestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, false, exists)
|
|
|
|
// We save our first proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 2 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the highest signed slot is what we just saved.
|
|
slot, exists, err := validatorDB.HighestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(2), slot)
|
|
|
|
// We save a lower proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 1 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the lowest signed slot did not change.
|
|
slot, exists, err = validatorDB.HighestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(2), slot)
|
|
|
|
// We save a higher proposal history.
|
|
err = validatorDB.SaveProposalHistoryForSlot(ctx, pubkey, 3 /* slot */, dummySigningRoot[:])
|
|
require.NoError(t, err)
|
|
|
|
// We expect the highest signed slot indeed changed.
|
|
slot, exists, err = validatorDB.HighestSignedProposal(ctx, pubkey)
|
|
require.NoError(t, err)
|
|
require.Equal(t, true, exists)
|
|
assert.Equal(t, primitives.Slot(3), slot)
|
|
}
|