mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-28 14:17:17 +00:00
774b4b7eef
* SubmitAggregateAndProof now prefers its own validator attestations * only do aggregate bits count comparsion when best also contains the validator index * gofmt * better test * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * @terencechain feedback * Merge refs/heads/master into prefer-own-attestation * update comment * Merge branch 'prefer-own-attestation' of github.com:prysmaticlabs/prysm into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation * Merge refs/heads/master into prefer-own-attestation
129 lines
5.3 KiB
Go
129 lines
5.3 KiB
Go
package validator
|
|
|
|
import (
|
|
"context"
|
|
|
|
ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
|
|
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
|
|
"github.com/prysmaticlabs/prysm/shared/bytesutil"
|
|
"github.com/prysmaticlabs/prysm/shared/params"
|
|
"github.com/sirupsen/logrus"
|
|
"go.opencensus.io/trace"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
// SubmitAggregateSelectionProof is called by a validator when its assigned to be an aggregator.
|
|
// The aggregator submits the selection proof to obtain the aggregated attestation
|
|
// object to sign over.
|
|
func (as *Server) SubmitAggregateSelectionProof(ctx context.Context, req *ethpb.AggregateSelectionRequest) (*ethpb.AggregateSelectionResponse, error) {
|
|
ctx, span := trace.StartSpan(ctx, "AggregatorServer.SubmitAggregateSelectionProof")
|
|
defer span.End()
|
|
span.AddAttributes(trace.Int64Attribute("slot", int64(req.Slot)))
|
|
|
|
if as.SyncChecker.Syncing() {
|
|
return nil, status.Errorf(codes.Unavailable, "Syncing to latest head, not ready to respond")
|
|
}
|
|
|
|
st, err := as.HeadFetcher.HeadState(ctx)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not determine head state: %v", err)
|
|
}
|
|
|
|
validatorIndex, exists := st.ValidatorIndexByPubkey(bytesutil.ToBytes48(req.PublicKey))
|
|
if !exists {
|
|
return nil, status.Error(codes.Internal, "Could not locate validator index in DB")
|
|
}
|
|
|
|
epoch := helpers.SlotToEpoch(req.Slot)
|
|
activeValidatorIndices, err := helpers.ActiveValidatorIndices(st, epoch)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not get validators: %v", err)
|
|
}
|
|
seed, err := helpers.Seed(st, epoch, params.BeaconConfig().DomainBeaconAttester)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not get seed: %v", err)
|
|
}
|
|
committee, err := helpers.BeaconCommittee(activeValidatorIndices, seed, req.Slot, req.CommitteeIndex)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Check if the validator is an aggregator
|
|
isAggregator, err := helpers.IsAggregator(uint64(len(committee)), req.SlotSignature)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not get aggregator status: %v", err)
|
|
}
|
|
if !isAggregator {
|
|
return nil, status.Errorf(codes.InvalidArgument, "Validator is not an aggregator")
|
|
}
|
|
|
|
if err := as.AttPool.AggregateUnaggregatedAttestations(); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not aggregate unaggregated attestations")
|
|
}
|
|
aggregatedAtts := as.AttPool.AggregatedAttestationsBySlotIndex(req.Slot, req.CommitteeIndex)
|
|
|
|
// Filter out the best aggregated attestation (ie. the one with the most aggregated bits).
|
|
if len(aggregatedAtts) == 0 {
|
|
aggregatedAtts = as.AttPool.UnaggregatedAttestationsBySlotIndex(req.Slot, req.CommitteeIndex)
|
|
if len(aggregatedAtts) == 0 {
|
|
return nil, status.Errorf(codes.Internal, "Could not find attestation for slot and committee in pool")
|
|
}
|
|
}
|
|
|
|
var indexInCommittee uint64
|
|
for i, idx := range committee {
|
|
if idx == validatorIndex {
|
|
indexInCommittee = uint64(i)
|
|
}
|
|
}
|
|
|
|
best := aggregatedAtts[0]
|
|
for _, aggregatedAtt := range aggregatedAtts[1:] {
|
|
// The aggregator should prefer an attestation that they have signed. We check this by
|
|
// looking at the attestation's committee index against the validator's committee index
|
|
// and check the aggregate bits to ensure the validator's index is set.
|
|
if aggregatedAtt.Data.CommitteeIndex == req.CommitteeIndex &&
|
|
aggregatedAtt.AggregationBits.BitAt(indexInCommittee) &&
|
|
(!best.AggregationBits.BitAt(indexInCommittee) ||
|
|
aggregatedAtt.AggregationBits.Count() > best.AggregationBits.Count()) {
|
|
best = aggregatedAtt
|
|
}
|
|
|
|
// If the "best" still doesn't contain the validator's index, check the aggregation bits to
|
|
// choose the attestation with the most bits set.
|
|
if !best.AggregationBits.BitAt(indexInCommittee) &&
|
|
aggregatedAtt.AggregationBits.Count() > best.AggregationBits.Count() {
|
|
best = aggregatedAtt
|
|
}
|
|
}
|
|
a := ðpb.AggregateAttestationAndProof{
|
|
Aggregate: best,
|
|
SelectionProof: req.SlotSignature,
|
|
AggregatorIndex: validatorIndex,
|
|
}
|
|
return ðpb.AggregateSelectionResponse{AggregateAndProof: a}, nil
|
|
}
|
|
|
|
// SubmitSignedAggregateSelectionProof is called by a validator to broadcast a signed
|
|
// aggregated and proof object.
|
|
func (as *Server) SubmitSignedAggregateSelectionProof(ctx context.Context, req *ethpb.SignedAggregateSubmitRequest) (*ethpb.SignedAggregateSubmitResponse, error) {
|
|
if req.SignedAggregateAndProof == nil || req.SignedAggregateAndProof.Message == nil ||
|
|
req.SignedAggregateAndProof.Message.Aggregate == nil || req.SignedAggregateAndProof.Message.Aggregate.Data == nil {
|
|
return nil, status.Error(codes.InvalidArgument, "Signed aggregate request can't be nil")
|
|
}
|
|
|
|
if err := as.P2P.Broadcast(ctx, req.SignedAggregateAndProof); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "Could not broadcast signed aggregated attestation: %v", err)
|
|
}
|
|
|
|
log.WithFields(logrus.Fields{
|
|
"slot": req.SignedAggregateAndProof.Message.Aggregate.Data.Slot,
|
|
"committeeIndex": req.SignedAggregateAndProof.Message.Aggregate.Data.CommitteeIndex,
|
|
"validatorIndex": req.SignedAggregateAndProof.Message.AggregatorIndex,
|
|
"aggregatedCount": req.SignedAggregateAndProof.Message.Aggregate.AggregationBits.Count(),
|
|
}).Debug("Broadcasting aggregated attestation and proof")
|
|
|
|
return ðpb.SignedAggregateSubmitResponse{}, nil
|
|
}
|