mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-22 19:40:37 +00:00
f962d13407
* fix races in committee cache tests * lint * gratuitous defer ClearCache if ClearCache * log warning to avoid failed block processing * gaz * add Clear to cache stubs * fix Clear mistakes * last fake cache fix --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
207 lines
7.5 KiB
Go
207 lines
7.5 KiB
Go
//go:build !fuzz
|
|
|
|
package cache
|
|
|
|
import (
|
|
"sync"
|
|
"sync/atomic"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/client_golang/prometheus/promauto"
|
|
"github.com/prysmaticlabs/prysm/v4/beacon-chain/state"
|
|
"github.com/prysmaticlabs/prysm/v4/consensus-types/primitives"
|
|
"github.com/prysmaticlabs/prysm/v4/encoding/bytesutil"
|
|
log "github.com/sirupsen/logrus"
|
|
"k8s.io/client-go/tools/cache"
|
|
)
|
|
|
|
var (
|
|
maxSyncCommitteeSize = uint64(3) // Allows 3 forks to happen around `EPOCHS_PER_SYNC_COMMITTEE_PERIOD` boundary.
|
|
|
|
// SyncCommitteeCacheMiss tracks the number of committee requests that aren't present in the cache.
|
|
SyncCommitteeCacheMiss = promauto.NewCounter(prometheus.CounterOpts{
|
|
Name: "sync_committee_index_cache_miss_total",
|
|
Help: "The number of committee requests that aren't present in the sync committee index cache.",
|
|
})
|
|
// SyncCommitteeCacheHit tracks the number of committee requests that are in the cache.
|
|
SyncCommitteeCacheHit = promauto.NewCounter(prometheus.CounterOpts{
|
|
Name: "sync_committee_index_cache_hit_total",
|
|
Help: "The number of committee requests that are present in the sync committee index cache.",
|
|
})
|
|
)
|
|
|
|
// SyncCommitteeCache utilizes a FIFO cache to sufficiently cache validator position within sync committee.
|
|
// It is thread safe with concurrent read write.
|
|
type SyncCommitteeCache struct {
|
|
cache *cache.FIFO
|
|
lock sync.RWMutex
|
|
cleared *atomic.Uint64
|
|
}
|
|
|
|
// Index position of all validators in sync committee where `currentSyncCommitteeRoot` is the
|
|
// key and `vIndexToPositionMap` is value. Inside `vIndexToPositionMap`, validator positions
|
|
// are cached where key is the validator index and the value is the `positionInCommittee` struct.
|
|
type syncCommitteeIndexPosition struct {
|
|
currentSyncCommitteeRoot [32]byte
|
|
vIndexToPositionMap map[primitives.ValidatorIndex]*positionInCommittee
|
|
}
|
|
|
|
// Index position of individual validator of current period and next period sync committee.
|
|
type positionInCommittee struct {
|
|
currentPeriod []primitives.CommitteeIndex
|
|
nextPeriod []primitives.CommitteeIndex
|
|
}
|
|
|
|
// NewSyncCommittee initializes and returns a new SyncCommitteeCache.
|
|
func NewSyncCommittee() *SyncCommitteeCache {
|
|
c := &SyncCommitteeCache{cleared: &atomic.Uint64{}}
|
|
c.Clear()
|
|
return c
|
|
}
|
|
|
|
// Clear resets the SyncCommitteeCache to its initial state
|
|
func (s *SyncCommitteeCache) Clear() {
|
|
s.lock.Lock()
|
|
defer s.lock.Unlock()
|
|
s.cleared.Add(1)
|
|
s.cache = cache.NewFIFO(keyFn)
|
|
}
|
|
|
|
// CurrentPeriodIndexPosition returns current period index position of a validator index with respect with
|
|
// sync committee. If the input validator index has no assignment, an empty list will be returned.
|
|
// If the input root does not exist in cache, `ErrNonExistingSyncCommitteeKey` is returned.
|
|
// Manual checking of state for index position in state is recommended when `ErrNonExistingSyncCommitteeKey` is returned.
|
|
func (s *SyncCommitteeCache) CurrentPeriodIndexPosition(root [32]byte, valIdx primitives.ValidatorIndex) ([]primitives.CommitteeIndex, error) {
|
|
s.lock.RLock()
|
|
defer s.lock.RUnlock()
|
|
|
|
pos, err := s.idxPositionInCommittee(root, valIdx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if pos == nil {
|
|
return []primitives.CommitteeIndex{}, nil
|
|
}
|
|
|
|
return pos.currentPeriod, nil
|
|
}
|
|
|
|
// NextPeriodIndexPosition returns next period index position of a validator index in respect with sync committee.
|
|
// If the input validator index has no assignment, an empty list will be returned.
|
|
// If the input root does not exist in cache, `ErrNonExistingSyncCommitteeKey` is returned.
|
|
// Manual checking of state for index position in state is recommended when `ErrNonExistingSyncCommitteeKey` is returned.
|
|
func (s *SyncCommitteeCache) NextPeriodIndexPosition(root [32]byte, valIdx primitives.ValidatorIndex) ([]primitives.CommitteeIndex, error) {
|
|
s.lock.RLock()
|
|
defer s.lock.RUnlock()
|
|
|
|
pos, err := s.idxPositionInCommittee(root, valIdx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if pos == nil {
|
|
return []primitives.CommitteeIndex{}, nil
|
|
}
|
|
return pos.nextPeriod, nil
|
|
}
|
|
|
|
// Helper function for `CurrentPeriodIndexPosition` and `NextPeriodIndexPosition` to return a mapping
|
|
// of validator index to its index(s) position in the sync committee.
|
|
func (s *SyncCommitteeCache) idxPositionInCommittee(
|
|
root [32]byte, valIdx primitives.ValidatorIndex,
|
|
) (*positionInCommittee, error) {
|
|
obj, exists, err := s.cache.GetByKey(key(root))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !exists {
|
|
SyncCommitteeCacheMiss.Inc()
|
|
return nil, ErrNonExistingSyncCommitteeKey
|
|
}
|
|
item, ok := obj.(*syncCommitteeIndexPosition)
|
|
if !ok {
|
|
return nil, errNotSyncCommitteeIndexPosition
|
|
}
|
|
idxInCommittee, ok := item.vIndexToPositionMap[valIdx]
|
|
if !ok {
|
|
SyncCommitteeCacheMiss.Inc()
|
|
return nil, nil
|
|
}
|
|
SyncCommitteeCacheHit.Inc()
|
|
return idxInCommittee, nil
|
|
}
|
|
|
|
// UpdatePositionsInCommittee updates caching of validators position in sync committee in respect to
|
|
// current epoch and next epoch. This should be called when `current_sync_committee` and `next_sync_committee`
|
|
// change and that happens every `EPOCHS_PER_SYNC_COMMITTEE_PERIOD`.
|
|
func (s *SyncCommitteeCache) UpdatePositionsInCommittee(syncCommitteeBoundaryRoot [32]byte, st state.BeaconState) error {
|
|
// since we call UpdatePositionsInCommittee asynchronously, keep track of the cache value
|
|
// seen at the beginning of the routine and compare at the end before updating. If the underlying value has been
|
|
// cycled (new address), don't update it.
|
|
clearCount := s.cleared.Load()
|
|
csc, err := st.CurrentSyncCommittee()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
positionsMap := make(map[primitives.ValidatorIndex]*positionInCommittee)
|
|
for i, pubkey := range csc.Pubkeys {
|
|
p := bytesutil.ToBytes48(pubkey)
|
|
validatorIndex, ok := st.ValidatorIndexByPubkey(p)
|
|
if !ok {
|
|
continue
|
|
}
|
|
if _, ok := positionsMap[validatorIndex]; !ok {
|
|
m := &positionInCommittee{currentPeriod: []primitives.CommitteeIndex{primitives.CommitteeIndex(i)}, nextPeriod: []primitives.CommitteeIndex{}}
|
|
positionsMap[validatorIndex] = m
|
|
} else {
|
|
positionsMap[validatorIndex].currentPeriod = append(positionsMap[validatorIndex].currentPeriod, primitives.CommitteeIndex(i))
|
|
}
|
|
}
|
|
|
|
nsc, err := st.NextSyncCommittee()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for i, pubkey := range nsc.Pubkeys {
|
|
p := bytesutil.ToBytes48(pubkey)
|
|
validatorIndex, ok := st.ValidatorIndexByPubkey(p)
|
|
if !ok {
|
|
continue
|
|
}
|
|
if _, ok := positionsMap[validatorIndex]; !ok {
|
|
m := &positionInCommittee{nextPeriod: []primitives.CommitteeIndex{primitives.CommitteeIndex(i)}, currentPeriod: []primitives.CommitteeIndex{}}
|
|
positionsMap[validatorIndex] = m
|
|
} else {
|
|
positionsMap[validatorIndex].nextPeriod = append(positionsMap[validatorIndex].nextPeriod, primitives.CommitteeIndex(i))
|
|
}
|
|
}
|
|
|
|
s.lock.Lock()
|
|
defer s.lock.Unlock()
|
|
if clearCount != s.cleared.Load() {
|
|
log.Warn("cache rotated during async committee update operation - abandoning cache update")
|
|
return nil
|
|
}
|
|
|
|
if err := s.cache.Add(&syncCommitteeIndexPosition{
|
|
currentSyncCommitteeRoot: syncCommitteeBoundaryRoot,
|
|
vIndexToPositionMap: positionsMap,
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
trim(s.cache, maxSyncCommitteeSize)
|
|
|
|
return nil
|
|
}
|
|
|
|
// Given the `syncCommitteeIndexPosition` object, this returns the key of the object.
|
|
// The key is the `currentSyncCommitteeRoot` within the field.
|
|
// Error gets returned if input does not comply with `currentSyncCommitteeRoot` object.
|
|
func keyFn(obj interface{}) (string, error) {
|
|
info, ok := obj.(*syncCommitteeIndexPosition)
|
|
if !ok {
|
|
return "", errNotSyncCommitteeIndexPosition
|
|
}
|
|
|
|
return string(info.currentSyncCommitteeRoot[:]), nil
|
|
}
|