mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-25 21:07:18 +00:00
86cd873e67
* Add span and annotate errors for validating beacon attestations * fix test
73 lines
2.3 KiB
Go
73 lines
2.3 KiB
Go
package sync
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/gogo/protobuf/proto"
|
|
"github.com/pkg/errors"
|
|
"github.com/prysmaticlabs/go-ssz"
|
|
"github.com/prysmaticlabs/prysm/beacon-chain/p2p"
|
|
ethpb "github.com/prysmaticlabs/prysm/proto/eth/v1alpha1"
|
|
"github.com/prysmaticlabs/prysm/shared/bytesutil"
|
|
"github.com/prysmaticlabs/prysm/shared/traceutil"
|
|
"go.opencensus.io/trace"
|
|
)
|
|
|
|
var errPointsToBlockNotInDatabase = errors.New("attestation points to a block which is not in the database")
|
|
|
|
// validateBeaconAttestation validates that the block being voted for passes validation before forwarding to the
|
|
// network.
|
|
func (r *RegularSync) validateBeaconAttestation(ctx context.Context, msg proto.Message, p p2p.Broadcaster, fromSelf bool) (bool, error) {
|
|
// Attestation processing requires the target block to be present in the database, so we'll skip
|
|
// validating or processing attestations until fully synced.
|
|
if r.initialSync.Syncing() {
|
|
return false, nil
|
|
}
|
|
|
|
ctx, span := trace.StartSpan(ctx, "sync.validateBeaconAttestation")
|
|
defer span.End()
|
|
|
|
// TODO(1332): Add blocks.VerifyAttestation before processing further.
|
|
// Discussion: https://github.com/ethereum/eth2.0-specs/issues/1332
|
|
|
|
att := msg.(*ethpb.Attestation)
|
|
|
|
attRoot, err := ssz.HashTreeRoot(att)
|
|
if err != nil {
|
|
return false, errors.Wrap(err, "could not hash attestation")
|
|
}
|
|
|
|
span.AddAttributes(
|
|
trace.StringAttribute("blockRoot", fmt.Sprintf("%#x", att.Data.BeaconBlockRoot)),
|
|
trace.StringAttribute("attRoot", fmt.Sprintf("%#x", attRoot)),
|
|
)
|
|
|
|
// Only valid blocks are saved in the database.
|
|
if !r.db.HasBlock(ctx, bytesutil.ToBytes32(att.Data.BeaconBlockRoot)) {
|
|
log.WithField(
|
|
"blockRoot",
|
|
fmt.Sprintf("%#x", att.Data.BeaconBlockRoot),
|
|
).WithError(errPointsToBlockNotInDatabase).Debug("Ignored incoming attestation that points to a block which is not in the database")
|
|
traceutil.AnnotateError(span, errPointsToBlockNotInDatabase)
|
|
return false, nil
|
|
}
|
|
|
|
if recentlySeenRoots.Get(string(attRoot[:])) != nil {
|
|
return false, nil
|
|
}
|
|
|
|
recentlySeenRoots.Set(string(attRoot[:]), true /*value*/, 365*24*time.Hour /*TTL*/)
|
|
|
|
if fromSelf {
|
|
return false, nil
|
|
}
|
|
|
|
if err := p.Broadcast(ctx, msg); err != nil {
|
|
log.WithError(err).Error("Failed to broadcast message")
|
|
traceutil.AnnotateError(span, err)
|
|
}
|
|
return true, nil
|
|
}
|