prysm-pulse/beacon-chain/powchain/deposit_test.go
Raul Jordan cc741ed8af
Ensure New State Type Tests Pass in Prysm (#4646)
* begin state service

* begin on the state trie idea

* created beacon state structure

* add in the full clone getter

* return by value instead

* add all setters

* new state setters are being completed

* arrays roots exposed

*  close to finishing all these headerssss

* functionality complete

* added in proto benchmark test

* test for compatibility

* add test for compat

* comments fixed

* add clone

* add clone

* remove underlying copies

* make it immutable

* integrate it into chainservice

* revert

* wrap up comments for package

* address all comments and godocs

* address all comments

* clone the pending attestation properly

* properly clone remaining items

* tests pass fixed bug

* begin using it instead of head state

* prevent nil pointer exceptions

* begin using new struct in db

* integrated new type into db package

* add proper nil checks

* using new state in archiver

* refactored much of core

* editing all the precompute functions

* done with most core refactor

* fixed up some bugs in the clone comparisons

* append current epoch atts

* add missing setters

* add new setters

* fix other core methods

* fix up transition

* main service and forkchoice

* fix rpc

* integrated to powchain

* some more changes

* fix build

* improve processing of deposits

* fix error

* prevent panic

* comment

* fix process att

* gaz

* fix up att process

* resolve existing review comments

* resolve another batch of gh comments

* resolve broken cpt state

* revise testutil to use the new state

* begin updating the state transition func to pass in more compartmentalized args

* finish editing transition function to return errors

* block operations pretty much done with refactor

* state transition fully refactored

* got epoch processing completed

* fix build in fork choice

* fixing more of the build

* fix up broken sync package

* it builds nowww it buildssss

* revert registry changes

* Recompute on Read (#4627)

* compute on read

* fix up eth1 data votes

* looking into slashings bug introduced in core/

* able to advance more slots

* add logging

* can now sync with testnet yay

* remove the leaves algorithm and other merkle imports

* expose initialize unsafe funcs

* Update beacon-chain/db/kv/state.go

* lint

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>

* More Optimizations for New State (#4641)

* map optimization

* more optimizations

* use a custom hasher

* comment

* block operations optimizations

* Update beacon-chain/state/types.go

Co-Authored-By: Raul Jordan <raul@prysmaticlabs.com>

* fixed up various operations to use the validator index map access

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>

* archiver tests pass

* fixing cache tests

* cache tests passing

* edited validator tests

* powchain tests passing

* halfway thru sync tests

* more sync test fixes

* add in tests for state/

* working through rpc tests

* assignments tests passed

* almost done with rpc/beacon tests

* resolved painful validator test

* fixed up even more tests

* resolve tests

* fix build

* reduce a randao mixes copy

* fixes under //beacon-chain/blockchain/...

* build //beacon-chain/core/...

* fixes

* Runtime Optimizations (#4648)

* parallelize shuffling

* clean up

* lint

* fix build

* use callback to read from registry

* fix array roots and size map

* new improvements

* reduce hash allocs

* improved shuffling

* terence's review

* use different method

* raul's comment

* new array roots

* remove clone in pre-compute

* Update beacon-chain/state/types.go

Co-Authored-By: Raul Jordan <raul@prysmaticlabs.com>

* raul's review

* lint

* fix build issues

* fix visibility

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>

* fix visibility

* build works for all

* fix blockchain test

* fix a few tests

* fix more tests

* update validator in slashing

* archiver passing

* fixed rpc/validator

* progress on core tests

* resolve broken rpc tests

* blockchain tests passed

* fix up some tests in core

* fix message diff

* remove unnecessary save

* Save validator after slashing

* Update validators one by one

* another update

* fix everything

* fix more precompute tests

* fix blocks tests

* more elegant fix

* more helper fixes

* change back ?

* fix test

* fix skip slot

* fix test

* reset caches

* fix testutil

* raceoff fixed

* passing

* Retrieve cached state in the beginning

* lint

* Fixed tests part 1

* Fixed rest of the tests

* Minor changes to avoid copying, small refactor to reduce deplicated code

* Handle att req for slot 0

* New beacon state: Only populate merkle layers as needed, copy merkle layers on copy/clone. (#4689)

* Only populate merkle layers as needed, copy merkle layers on copy/clone.

* use custom copy

* Make maps of correct size

* slightly fast, doesn't wait for lock

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>

* Target root can't be 0x00

* Don't use cache for current slot (may not be the right fix)

* fixed up tests

* Remove some copy for init sync. Not sure if it is safe enough for runtime though... testing...

* Align with prev logic for process slots cachedState.Slot() < slot

* Fix Initial Sync Flag (#4692)

* fixes

* fix up some test failures due to lack of nil checks

* fix up some test failures due to lack of nil checks

* fix up imports

* revert some changes

* imports

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>

* resolving further conflicts

* Better skip slot cache (#4694)

* Return copy of skip slot cache state, disable skip slot cache on sync

* fix

* Fix pruning

* fix up issues with broken tests

Co-authored-by: Nishant Das <nish1993@hotmail.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: shayzluf <thezluf@gmail.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2020-01-31 12:57:01 -08:00

329 lines
8.8 KiB
Go

package powchain
import (
"context"
"strings"
"testing"
ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
"github.com/prysmaticlabs/go-ssz"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
testDB "github.com/prysmaticlabs/prysm/beacon-chain/db/testing"
"github.com/prysmaticlabs/prysm/shared/bls"
"github.com/prysmaticlabs/prysm/shared/params"
"github.com/prysmaticlabs/prysm/shared/testutil"
"github.com/prysmaticlabs/prysm/shared/trieutil"
logTest "github.com/sirupsen/logrus/hooks/test"
)
const pubKeyErr = "could not convert bytes to public key"
func TestProcessDeposit_OK(t *testing.T) {
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
deposits, _, _ := testutil.DeterministicDepositsAndKeys(1)
eth1Data, err := testutil.DeterministicEth1Data(len(deposits))
if err != nil {
t.Fatal(err)
}
if err := web3Service.processDeposit(eth1Data, deposits[0]); err != nil {
t.Fatalf("Could not process deposit %v", err)
}
valcount, err := helpers.ActiveValidatorCount(web3Service.preGenesisState, 0)
if err != nil {
t.Fatal(err)
}
if valcount != 1 {
t.Errorf("Did not get correct active validator count received %d, but wanted %d", valcount, 1)
}
}
func TestProcessDeposit_InvalidMerkleBranch(t *testing.T) {
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
deposits, _, _ := testutil.DeterministicDepositsAndKeys(1)
eth1Data, err := testutil.DeterministicEth1Data(len(deposits))
if err != nil {
t.Fatal(err)
}
deposits[0].Proof = [][]byte{{'f', 'a', 'k', 'e'}}
err = web3Service.processDeposit(eth1Data, deposits[0])
if err == nil {
t.Fatal("No errors, when an error was expected")
}
want := "deposit merkle branch of deposit root did not verify for root"
if !strings.Contains(err.Error(), want) {
t.Errorf("Did not get expected error. Wanted: '%s' but got '%s'", want, err.Error())
}
}
func TestProcessDeposit_InvalidPublicKey(t *testing.T) {
hook := logTest.NewGlobal()
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
deposits, _, _ := testutil.DeterministicDepositsAndKeys(1)
deposits[0].Data.PublicKey = []byte("junk")
leaf, err := ssz.HashTreeRoot(deposits[0].Data)
if err != nil {
t.Fatalf("Could not hash deposit %v", err)
}
trie, err := trieutil.GenerateTrieFromItems([][]byte{leaf[:]}, int(params.BeaconConfig().DepositContractTreeDepth))
if err != nil {
log.Error(err)
}
deposits[0].Proof, err = trie.MerkleProof(0)
if err != nil {
t.Fatal(err)
}
root := trie.Root()
eth1Data := &ethpb.Eth1Data{
DepositCount: 1,
DepositRoot: root[:],
}
web3Service.processDeposit(eth1Data, deposits[0])
testutil.AssertLogsContain(t, hook, pubKeyErr)
}
func TestProcessDeposit_InvalidSignature(t *testing.T) {
hook := logTest.NewGlobal()
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
deposits, _, _ := testutil.DeterministicDepositsAndKeys(1)
var fakeSig [96]byte
copy(fakeSig[:], []byte{'F', 'A', 'K', 'E'})
deposits[0].Data.Signature = fakeSig[:]
leaf, err := ssz.HashTreeRoot(deposits[0].Data)
if err != nil {
t.Fatalf("Could not hash deposit %v", err)
}
trie, err := trieutil.GenerateTrieFromItems([][]byte{leaf[:]}, int(params.BeaconConfig().DepositContractTreeDepth))
if err != nil {
log.Error(err)
}
root := trie.Root()
eth1Data := &ethpb.Eth1Data{
DepositCount: 1,
DepositRoot: root[:],
}
web3Service.processDeposit(eth1Data, deposits[0])
testutil.AssertLogsContain(t, hook, pubKeyErr)
}
func TestProcessDeposit_UnableToVerify(t *testing.T) {
hook := logTest.NewGlobal()
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
testutil.ResetCache()
deposits, keys, _ := testutil.DeterministicDepositsAndKeys(1)
sig := keys[0].Sign([]byte{'F', 'A', 'K', 'E'}, bls.ComputeDomain(params.BeaconConfig().DomainDeposit))
deposits[0].Data.Signature = sig.Marshal()[:]
trie, _, err := testutil.DepositTrieFromDeposits(deposits)
if err != nil {
t.Fatal(err)
}
root := trie.Root()
eth1Data := &ethpb.Eth1Data{
DepositCount: 1,
DepositRoot: root[:],
}
proof, err := trie.MerkleProof(0)
if err != nil {
t.Fatal(err)
}
deposits[0].Proof = proof
web3Service.processDeposit(eth1Data, deposits[0])
want := "signature did not verify"
testutil.AssertLogsContain(t, hook, want)
}
func TestProcessDeposit_IncompleteDeposit(t *testing.T) {
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
deposit := &ethpb.Deposit{
Data: &ethpb.Deposit_Data{
Amount: params.BeaconConfig().EffectiveBalanceIncrement, // incomplete deposit
WithdrawalCredentials: []byte("testing"),
},
}
sk := bls.RandKey()
deposit.Data.PublicKey = sk.PublicKey().Marshal()
signedRoot, err := ssz.HashTreeRoot(deposit.Data)
if err != nil {
t.Fatal(err)
}
sig := sk.Sign(signedRoot[:], bls.ComputeDomain(params.BeaconConfig().DomainDeposit))
deposit.Data.Signature = sig.Marshal()
trie, err := trieutil.NewTrie(int(params.BeaconConfig().DepositContractTreeDepth))
if err != nil {
t.Fatal(err)
}
root := trie.Root()
eth1Data := &ethpb.Eth1Data{
DepositCount: 1,
DepositRoot: root[:],
}
proof, err := trie.MerkleProof(0)
if err != nil {
t.Fatal(err)
}
dataRoot, err := ssz.HashTreeRoot(deposit.Data)
if err != nil {
t.Fatal(err)
}
deposit.Proof = proof
factor := params.BeaconConfig().MaxEffectiveBalance / params.BeaconConfig().EffectiveBalanceIncrement
// deposit till 31e9
for i := 0; i < int(factor-1); i++ {
trie.Insert(dataRoot[:], i)
trieRoot := trie.HashTreeRoot()
eth1Data.DepositRoot = trieRoot[:]
eth1Data.DepositCount = uint64(i + 1)
deposit.Proof, err = trie.MerkleProof(i)
if err != nil {
t.Fatal(err)
}
if err := web3Service.processDeposit(eth1Data, deposit); err != nil {
t.Fatalf("Could not process deposit at %d %v", i, err)
}
valcount, err := helpers.ActiveValidatorCount(web3Service.preGenesisState, 0)
if err != nil {
t.Fatal(err)
}
if valcount == 1 {
t.Errorf("Did not get correct active validator count received %d, but wanted %d", valcount, 0)
}
}
}
func TestProcessDeposit_AllDepositedSuccessfully(t *testing.T) {
beaconDB := testDB.SetupDB(t)
defer testDB.TeardownDB(t, beaconDB)
web3Service, err := NewService(context.Background(), &Web3ServiceConfig{
ETH1Endpoint: endpoint,
BeaconDB: beaconDB,
})
if err != nil {
t.Fatalf("Unable to setup web3 ETH1.0 chain service: %v", err)
}
web3Service = setDefaultMocks(web3Service)
testutil.ResetCache()
deposits, keys, _ := testutil.DeterministicDepositsAndKeys(10)
eth1Data, err := testutil.DeterministicEth1Data(len(deposits))
if err != nil {
t.Fatal(err)
}
for i := range keys {
eth1Data.DepositCount = uint64(i + 1)
if err := web3Service.processDeposit(eth1Data, deposits[i]); err != nil {
t.Fatalf("Could not process deposit %v", err)
}
valCount, err := helpers.ActiveValidatorCount(web3Service.preGenesisState, 0)
if err != nil {
t.Fatal(err)
}
if valCount != uint64(i+1) {
t.Errorf("Did not get correct active validator count received %d, but wanted %d", valCount, uint64(i+1))
}
val, err := web3Service.preGenesisState.ValidatorAtIndex(uint64(i))
if err != nil {
t.Fatal(err)
}
if val.EffectiveBalance != params.BeaconConfig().MaxEffectiveBalance {
t.Errorf(
"Wanted a full deposit of %d but got %d",
params.BeaconConfig().MaxEffectiveBalance,
val.EffectiveBalance,
)
}
}
}