mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2025-01-08 02:31:19 +00:00
ef21d3adf8
* `EpochFromString`: Use already defined `Uint64FromString` function. * `Test_uint64FromString` => `Test_FromString` This test function tests more functions than `Uint64FromString`. * Slashing protection history: Remove unreachable code. The function `NewKVStore` creates, via `kv.UpdatePublicKeysBuckets`, a new item in the `proposal-history-bucket-interchange`. IMO there is no real reason to prefer `proposal` than `attestation` as a prefix for this bucket, but this is the way it is done right now and renaming the bucket will probably be backward incompatible. An `attestedPublicKey` cannot exist without the corresponding `proposedPublicKey`. Thus, the `else` portion of code removed in this commit is not reachable. We raise an error if we get there. This is also probably the reason why the removed `else` portion was not tested. * `NewKVStore`: Switch items in `createBuckets`. So the order corresponds to `schema.go` * `slashableAttestationCheck`: Fix comments and logs. * `ValidatorClient.db`: Use `iface.ValidatorDB`. * BoltDB database: Implement `GraffitiFileHash`. * Filesystem database: Creates `db.go`. This file defines the following structs: - `Store` - `Graffiti` - `Configuration` - `ValidatorSlashingProtection` This files implements the following public functions: - `NewStore` - `Close` - `Backup` - `DatabasePath` - `ClearDB` - `UpdatePublicKeysBuckets` This files implements the following private functions: - `slashingProtectionDirPath` - `configurationFilePath` - `configuration` - `saveConfiguration` - `validatorSlashingProtection` - `saveValidatorSlashingProtection` - `publicKeys` * Filesystem database: Creates `genesis.go`. This file defines the following public functions: - `GenesisValidatorsRoot` - `SaveGenesisValidatorsRoot` * Filesystem database: Creates `graffiti.go`. This file defines the following public functions: - `SaveGraffitiOrderedIndex` - `GraffitiOrderedIndex` * Filesystem database: Creates `migration.go`. This file defines the following public functions: - `RunUpMigrations` - `RunDownMigrations` * Filesystem database: Creates proposer_settings.go. This file defines the following public functions: - `ProposerSettings` - `ProposerSettingsExists` - `SaveProposerSettings` * Filesystem database: Creates `attester_protection.go`. This file defines the following public functions: - `EIPImportBlacklistedPublicKeys` - `SaveEIPImportBlacklistedPublicKeys` - `SigningRootAtTargetEpoch` - `LowestSignedTargetEpoch` - `LowestSignedSourceEpoch` - `AttestedPublicKeys` - `CheckSlashableAttestation` - `SaveAttestationForPubKey` - `SaveAttestationsForPubKey` - `AttestationHistoryForPubKey` * Filesystem database: Creates `proposer_protection.go`. This file defines the following public functions: - `HighestSignedProposal` - `LowestSignedProposal` - `ProposalHistoryForPubKey` - `ProposalHistoryForSlot` - `ProposedPublicKeys` * Ensure that the filesystem store implements the `ValidatorDB` interface. * `slashableAttestationCheck`: Check the database type. * `slashableProposalCheck`: Check the database type. * `slashableAttestationCheck`: Allow usage of minimal slashing protection. * `slashableProposalCheck`: Allow usage of minimal slashing protection. * `ImportStandardProtectionJSON`: Check the database type. * `ImportStandardProtectionJSON`: Allow usage of min slashing protection. * Implement `RecursiveDirFind`. * Implement minimal<->complete DB conversion. 3 public functions are implemented: - `IsCompleteDatabaseExisting` - `IsMinimalDatabaseExisting` - `ConvertDatabase` * `setupDB`: Add `isSlashingProtectionMinimal` argument. The feature addition is located in `validator/node/node_test.go`. The rest of this commit consists in minimal slashing protection testing. * `setupWithKey`: Add `isSlashingProtectionMinimal` argument. The feature addition is located in `validator/client/propose_test.go`. The rest of this commit consists in tests wrapping. * `setup`: Add `isSlashingProtectionMinimal` argument. The added feature is located in the `validator/client/propose_test.go` file. The rest of this commit consists in tests wrapping. * `initializeFromCLI` and `initializeForWeb`: Factorize db init. * Add `convert-complete-to-minimal` command. * Creates `--enable-minimal-slashing-protection` flag. * `importSlashingProtectionJSON`: Check database type. * `exportSlashingProtectionJSON`: Check database type. * `TestClearDB`: Test with minimal slashing protection. * KeyManager: Test with minimal slashing protection. * RPC: KeyManager: Test with minimal slashing protection. * `convert-complete-to-minimal`: Change option names. Options were: - `--source` (for source data directory), and - `--target` (for target data directory) However, since this command deals with slashing protection, which has source (epochs) and target (epochs), the initial option names may confuse the user. In this commit: `--source` ==> `--source-data-dir` `--target` ==> `--target-data-dir` * Set `SlashableAttestationCheck` as an iface method. And delete `CheckSlashableAttestation` from iface. * Move helpers functions in a more general directory. No functional change. * Extract common structs out of `kv`. ==> `filesystem` does not depend anymore on `kv`. ==> `iface` does not depend anymore on `kv`. ==> `slashing-protection` does not depend anymore on `kv`. * Move `ValidateMetadata` in `validator/helpers`. * `ValidateMetadata`: Test with mock. This way, we can: - Avoid any circular import for tests. - Implement once for all `iface.ValidatorDB` implementations the `ValidateMetadata`function. - Have tests (and coverage) of `ValidateMetadata`in its own package. The ideal solution would have been to implement `ValidateMetadata` as a method with the `iface.ValidatorDB`receiver. Unfortunately, golang does not allow that. * `iface.ValidatorDB`: Implement ImportStandardProtectionJSON. The whole purpose of this commit is to avoid the `switch validatorDB.(type)` in `ImportStandardProtectionJSON`. * `iface.ValidatorDB`: Implement `SlashableProposalCheck`. * Remove now useless `slashableProposalCheck`. * Delete useless `ImportStandardProtectionJSON`. * `file.Exists`: Detect directories and return an error. Before, `Exists` was only able to detect if a file exists. Now, this function takes an extra `File` or `Directory` argument. It detects either if a file or a directory exists. Before, if an error was returned by `os.Stat`, the the file was considered as non existing. Now, it is treated as a real error. * Replace `os.Stat` by `file.Exists`. * Remove `Is{Complete,Minimal}DatabaseExisting`. * `publicKeys`: Add log if unexpected file found. * Move `{Source,Target}DataDirFlag`in `db.go`. * `failedAttLocalProtectionErr`: `var`==> `const` * `signingRoot`: `32`==> `fieldparams.RootLength`. * `validatorClientData`==> `validator-client-data`. To be consistent with `slashing-protection`. * Add progress bars for `import` and `convert`. * `parseBlocksForUniquePublicKeys`: Move in `db/kv`. * helpers: Remove unused `initializeProgressBar` function.
147 lines
3.7 KiB
Go
147 lines
3.7 KiB
Go
package filesystem
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/ethereum/go-ethereum/common/hexutil"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
func (s *Store) SaveGraffitiOrderedIndex(_ context.Context, index uint64) error {
|
|
// Get the configuration.
|
|
configuration, err := s.configuration()
|
|
if err != nil {
|
|
return errors.Wrapf(err, "could not get configuration")
|
|
}
|
|
|
|
if configuration == nil {
|
|
// Create an new configuration.
|
|
configuration = &Configuration{
|
|
Graffiti: &Graffiti{
|
|
OrderedIndex: index,
|
|
},
|
|
}
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
if configuration.Graffiti == nil {
|
|
// Create a new graffiti.
|
|
configuration.Graffiti = &Graffiti{
|
|
OrderedIndex: index,
|
|
}
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Modify the value of ordered index.
|
|
configuration.Graffiti.OrderedIndex = index
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *Store) GraffitiOrderedIndex(_ context.Context, fileHash [32]byte) (uint64, error) {
|
|
// Encode the file hash to string.
|
|
fileHashHex := hexutil.Encode(fileHash[:])
|
|
|
|
// Get the configuration.
|
|
configuration, err := s.configuration()
|
|
if err != nil {
|
|
return 0, errors.Wrapf(err, "could not get configuration")
|
|
}
|
|
|
|
if configuration == nil {
|
|
// Create an new configuration.
|
|
configuration = &Configuration{
|
|
Graffiti: &Graffiti{
|
|
OrderedIndex: 0,
|
|
FileHash: &fileHashHex,
|
|
},
|
|
}
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return 0, errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return 0, nil
|
|
}
|
|
|
|
if configuration.Graffiti == nil {
|
|
// Create a new graffiti.
|
|
configuration.Graffiti = &Graffiti{
|
|
OrderedIndex: 0,
|
|
FileHash: &fileHashHex,
|
|
}
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return 0, errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return 0, nil
|
|
}
|
|
|
|
// Check if file hash does not exist or is not equal to the file hash in configuration.
|
|
if configuration.Graffiti.FileHash == nil || *configuration.Graffiti.FileHash != fileHashHex {
|
|
// Modify the value of ordered index.
|
|
configuration.Graffiti.OrderedIndex = 0
|
|
|
|
// Modify the value of file hash.
|
|
configuration.Graffiti.FileHash = &fileHashHex
|
|
|
|
// Save the configuration.
|
|
if err := s.saveConfiguration(configuration); err != nil {
|
|
return 0, errors.Wrapf(err, "could not save configuration")
|
|
}
|
|
|
|
return 0, nil
|
|
}
|
|
|
|
return configuration.Graffiti.OrderedIndex, nil
|
|
}
|
|
|
|
func (s *Store) GraffitiFileHash() ([32]byte, bool, error) {
|
|
// Get configuration.
|
|
configuration, err := s.configuration()
|
|
if err != nil {
|
|
return [32]byte{}, false, errors.Wrapf(err, "could not get configuration")
|
|
}
|
|
|
|
// If configuration is nil or graffiti is nil or file hash is nil, set graffiti file hash as not existing.
|
|
if configuration == nil || configuration.Graffiti == nil || configuration.Graffiti.FileHash == nil {
|
|
return [32]byte{}, false, nil
|
|
}
|
|
|
|
// Convert the graffiti file hash to [32]byte.
|
|
fileHashBytes, err := hexutil.Decode(*configuration.Graffiti.FileHash)
|
|
if err != nil {
|
|
return [32]byte{}, false, errors.Wrapf(err, "could not decode graffiti file hash")
|
|
}
|
|
|
|
if len(fileHashBytes) != 32 {
|
|
return [32]byte{}, false, errors.Wrapf(err, "invalid graffiti file hash length")
|
|
}
|
|
|
|
var fileHash [32]byte
|
|
copy(fileHash[:], fileHashBytes)
|
|
|
|
// Return the graffiti file hash.
|
|
return fileHash, true, nil
|
|
}
|