prysm-pulse/shared/p2p/service_test.go
Preston Van Loon 4add403335
Validator Proposer Rewrite (#1462)
* WIP - with TODOs

* interface w/ test

* basic test for broadcast

* Add computeStateRoot funciton

* remove custody challenge

* resolve TODO lint issues

* more TODOs

* revert new line in types.proto

* broadcaster comment

* one of several failure condition tests

* Add test cases

* handle compute state error test case

* fix config in validator helpers

* fix tests too

* fix conflict

* partial PR feedback

* remove p2p

* gazelle

* package comment

* Better godoc
2019-02-05 08:47:25 -05:00

395 lines
9.8 KiB
Go

package p2p
import (
"context"
"fmt"
"reflect"
"strings"
"sync"
"testing"
"time"
"github.com/gogo/protobuf/proto"
"github.com/golang/mock/gomock"
ipfslog "github.com/ipfs/go-log"
bhost "github.com/libp2p/go-libp2p-blankhost"
pubsub "github.com/libp2p/go-libp2p-pubsub"
swarmt "github.com/libp2p/go-libp2p-swarm/testing"
shardpb "github.com/prysmaticlabs/prysm/proto/sharding/p2p/v1"
testpb "github.com/prysmaticlabs/prysm/proto/testing"
"github.com/prysmaticlabs/prysm/shared"
p2pmock "github.com/prysmaticlabs/prysm/shared/p2p/mock"
"github.com/sirupsen/logrus"
logTest "github.com/sirupsen/logrus/hooks/test"
)
// Ensure that server implements service.
var _ = shared.Service(&Server{})
var _ = Broadcaster(&Server{})
func init() {
logrus.SetLevel(logrus.DebugLevel)
ipfslog.SetDebugLogging()
}
func TestStartDialRelayNodeFails(t *testing.T) {
hook := logTest.NewGlobal()
s, err := NewServer(&ServerConfig{
RelayNodeAddr: "bad",
})
if err != nil {
t.Fatalf("Unable to create server: %v", err)
}
s.Start()
logContains(t, hook, "Could not dial relay node: invalid multiaddr, must begin with /", logrus.ErrorLevel)
}
func TestP2pPortTakenError(t *testing.T) {
thePort := 10000
_, err := NewServer(&ServerConfig{
Port: thePort,
})
if err != nil {
t.Fatalf("unable to create server: %s", err)
}
_, err = NewServer(&ServerConfig{
Port: thePort,
})
if !strings.Contains(err.Error(), fmt.Sprintf("port %d already taken", thePort)) {
t.Fatalf("expected fail when setting another server with same p2p port")
}
}
func TestBroadcast(t *testing.T) {
s, err := NewServer(&ServerConfig{})
if err != nil {
t.Fatalf("Could not start a new server: %v", err)
}
msg := &shardpb.CollationBodyRequest{}
s.Broadcast(msg)
// TODO(543): test that topic was published
}
func TestEmit(t *testing.T) {
s, _ := NewServer(&ServerConfig{})
p := &testpb.TestMessage{Foo: "bar"}
ctrl := gomock.NewController(t)
defer ctrl.Finish()
feed := p2pmock.NewMockFeed(ctrl)
var got Message
feed.EXPECT().Send(gomock.AssignableToTypeOf(Message{})).Times(1).Do(func(m Message) {
got = m
})
s.emit(Message{Ctx: context.Background(), Data: p}, feed)
if !proto.Equal(p, got.Data) {
t.Error("feed was not called with the correct data")
}
}
func TestSubscribeToTopic(t *testing.T) {
ctx, cancel := context.WithTimeout(context.TODO(), 1*time.Second)
defer cancel()
h := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
gsub, err := pubsub.NewFloodSub(ctx, h)
if err != nil {
t.Errorf("Failed to create pubsub: %v", err)
}
s := Server{
ctx: ctx,
gsub: gsub,
host: h,
feeds: make(map[reflect.Type]Feed),
mutex: &sync.Mutex{},
topicMapping: make(map[reflect.Type]string),
}
feed := s.Feed(&shardpb.CollationBodyRequest{})
ch := make(chan Message)
sub := feed.Subscribe(ch)
defer sub.Unsubscribe()
testSubscribe(ctx, t, s, gsub, ch)
}
func TestSubscribe(t *testing.T) {
ctx, cancel := context.WithTimeout(context.TODO(), 1*time.Second)
defer cancel()
h := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
gsub, err := pubsub.NewFloodSub(ctx, h)
if err != nil {
t.Errorf("Failed to create pubsub: %v", err)
}
s := Server{
ctx: ctx,
gsub: gsub,
host: h,
feeds: make(map[reflect.Type]Feed),
mutex: &sync.Mutex{},
topicMapping: make(map[reflect.Type]string),
}
ch := make(chan Message)
sub := s.Subscribe(&shardpb.CollationBodyRequest{}, ch)
defer sub.Unsubscribe()
testSubscribe(ctx, t, s, gsub, ch)
}
func testSubscribe(ctx context.Context, t *testing.T, s Server, gsub *pubsub.PubSub, ch chan Message) {
topic := shardpb.Topic_COLLATION_BODY_REQUEST
s.RegisterTopic(topic.String(), &shardpb.CollationBodyRequest{})
// Short delay to let goroutine add subscription.
time.Sleep(time.Millisecond * 10)
// The topic should be subscribed with gsub.
topics := gsub.GetTopics()
if len(topics) < 1 || topics[0] != topic.String() {
t.Errorf("Unexpected subscribed topics: %v. Wanted %s", topics, topic)
}
pbMsg := &shardpb.CollationBodyRequest{ShardId: 5}
done := make(chan bool)
go func() {
// The message should be received from the feed.
msg := <-ch
if !proto.Equal(msg.Data.(proto.Message), pbMsg) {
t.Errorf("Unexpected msg: %+v. Wanted %+v.", msg.Data, pbMsg)
}
done <- true
}()
b, err := proto.Marshal(pbMsg)
if err != nil {
t.Errorf("Failed to marshal service %v", err)
}
if err = gsub.Publish(topic.String(), b); err != nil {
t.Errorf("Failed to publish message: %v", err)
}
// Wait for our message assertion to complete.
select {
case <-done:
case <-ctx.Done():
t.Error("Context timed out before a message was received!")
}
}
func TestRegisterTopic_HandleInvalidProtobufs(t *testing.T) {
topic := shardpb.Topic_COLLATION_BODY_REQUEST
hook := logTest.NewGlobal()
ctx, cancel := context.WithTimeout(context.TODO(), 1*time.Second)
defer cancel()
h := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
gsub, err := pubsub.NewFloodSub(ctx, h)
if err != nil {
t.Errorf("Failed to create floodsub: %v", err)
}
s := Server{
ctx: ctx,
gsub: gsub,
host: h,
feeds: make(map[reflect.Type]Feed),
mutex: &sync.Mutex{},
topicMapping: make(map[reflect.Type]string),
}
s.RegisterTopic(topic.String(), &shardpb.CollationBodyRequest{})
ch := make(chan Message)
sub := s.Subscribe(&shardpb.CollationBodyRequest{}, ch)
defer sub.Unsubscribe()
if err = gsub.Publish(topic.String(), []byte("invalid protobuf message")); err != nil {
t.Errorf("Failed to publish message: %v", err)
}
pbMsg := &shardpb.CollationBodyRequest{ShardId: 5}
b, err := proto.Marshal(pbMsg)
if err != nil {
t.Errorf("Failed to marshal service %v", err)
}
if err = gsub.Publish(topic.String(), b); err != nil {
t.Errorf("Failed to publish message: %v", err)
}
select {
case <-ctx.Done():
t.Error("Context timed out before a message was received!")
case <-ch:
logContains(t, hook, "Failed to decode data", logrus.ErrorLevel)
}
}
func TestRegisterTopic_WithoutAdapters(t *testing.T) {
// TODO(488): Unskip this test
t.Skip("Currently failing to simulate incoming p2p messages. See github.com/prysmaticlabs/prysm/issues/488")
s, err := NewServer(&ServerConfig{})
if err != nil {
t.Fatalf("Failed to create new server: %v", err)
}
topic := "test_topic"
testMessage := &testpb.TestMessage{Foo: "bar"}
s.RegisterTopic(topic, testMessage)
ch := make(chan Message)
sub := s.Subscribe(testMessage, ch)
defer sub.Unsubscribe()
wait := make(chan struct{})
go func() {
defer close(wait)
msg := <-ch
tmsg := msg.Data.(*testpb.TestMessage)
if tmsg.Foo != "bar" {
t.Errorf("Expected test message Foo: \"bar\". Got: %v", tmsg)
}
}()
b, _ := proto.Marshal(testMessage)
_ = b
if err := simulateIncomingMessage(t, s, topic, b); err != nil {
t.Errorf("Failed to send to topic %s", topic)
}
select {
case <-wait:
return // OK
case <-time.After(1 * time.Second):
t.Fatal("TestMessage not received within 1 seconds")
}
}
func TestRegisterTopic_WithAdapters(t *testing.T) {
// TODO(488): Unskip this test
t.Skip("Currently failing to simulate incoming p2p messages. See github.com/prysmaticlabs/prysm/issues/488")
s, err := NewServer(&ServerConfig{})
if err != nil {
t.Fatalf("Failed to create new server: %v", err)
}
topic := "test_topic"
testMessage := &testpb.TestMessage{Foo: "bar"}
i := 0
var testAdapter Adapter = func(next Handler) Handler {
return func(msg Message) {
i++
next(msg)
}
}
adapters := []Adapter{
testAdapter,
testAdapter,
testAdapter,
testAdapter,
testAdapter,
}
s.RegisterTopic(topic, testMessage, adapters...)
ch := make(chan Message)
sub := s.Subscribe(testMessage, ch)
defer sub.Unsubscribe()
wait := make(chan struct{})
go func() {
defer close(wait)
msg := <-ch
tmsg := msg.Data.(*testpb.TestMessage)
if tmsg.Foo != "bar" {
t.Errorf("Expected test message Foo: \"bar\". Got: %v", tmsg)
}
}()
if err := simulateIncomingMessage(t, s, topic, []byte{}); err != nil {
t.Errorf("Failed to send to topic %s", topic)
}
select {
case <-wait:
if i != 5 {
t.Errorf("Expected testAdapter to increment i to 5, but was %d", i)
}
return // OK
case <-time.After(1 * time.Second):
t.Fatal("TestMessage not received within 1 seconds")
}
}
func TestStatus_MinimumPeers(t *testing.T) {
minPeers := 5
ctx := context.Background()
h := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
s := Server{host: h}
err := s.Status()
if err == nil || err.Error() != "less than 5 peers" {
t.Errorf("p2p server did not return expected status, instead returned %v", err)
}
for i := 0; i < minPeers; i++ {
other := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
if err := h.Connect(ctx, other.Peerstore().PeerInfo(other.ID())); err != nil {
t.Fatalf("Could not connect to host for test setup")
}
}
if err := s.Status(); err != nil {
t.Errorf("Unexpected server status %v", err)
}
}
func simulateIncomingMessage(t *testing.T, s *Server, topic string, b []byte) error {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
h := bhost.NewBlankHost(swarmt.GenSwarm(t, ctx))
gsub, err := pubsub.NewFloodSub(ctx, h)
if err != nil {
return err
}
pinfo := h.Peerstore().PeerInfo(h.ID())
if err = s.host.Connect(ctx, pinfo); err != nil {
return err
}
// Short timeout to allow libp2p to handle peer connection.
time.Sleep(time.Millisecond * 10)
return gsub.Publish(topic, b)
}
func logContains(t *testing.T, hook *logTest.Hook, message string, level logrus.Level) {
var logs string
for _, entry := range hook.AllEntries() {
logs = fmt.Sprintf("%s\nlevel=%s msg=\"%s\"", logs, entry.Level, entry.Message)
if entry.Level == level && strings.Contains(entry.Message, message) {
return
}
}
t.Errorf("Expected log to contain level=%s and msg=\"%s\" inside log entries: %s", level, message, logs)
}