prysm-pulse/shared/featureconfig/config.go
Preston Van Loon a5da9f2dd6
Add feature flag to toggle gossip sub in p2p (#2322)
* add feature flag to enable gossip sub in p2p

* invert the enable/disable logic

* add the flag in k8s and fix tests

* gazellle

* return empty config if nil
2019-04-21 13:31:23 -04:00

104 lines
3.7 KiB
Go

/*
Package featureconfig defines which features are enabled for runtime
in order to selctively enable certain features to maintain a stable runtime.
The process for implementing new features using this package is as follows:
1. Add a new CMD flag in flags.go, and place it in the proper list(s) var for its client.
2. Add a condition for the flag in the proper Configure function(s) below.
3. Place any "new" behavior in the `if flagEnabled` statement.
4. Place any "previous" behavior in the `else` statement.
5. Ensure any tests using the new feature fail if the flag isn't enabled.
5a. Use the following to enable your flag for tests:
cfg := &featureconfig.FeatureFlagConfig{
VerifyAttestationSigs: true,
}
featureconfig.InitFeatureConfig(cfg)
*/
package featureconfig
import (
"github.com/sirupsen/logrus"
"github.com/urfave/cli"
)
var log = logrus.WithField("prefix", "flags")
// FeatureFlagConfig is a struct to represent what features the client will perform on runtime.
type FeatureFlagConfig struct {
VerifyAttestationSigs bool // VerifyAttestationSigs declares if the client will verify attestations.
EnableComputeStateRoot bool // EnableComputeStateRoot implementation on server side.
EnableCrosslinks bool // EnableCrosslinks in epoch processing.
EnableCheckBlockStateRoot bool // EnableCheckBlockStateRoot in block processing.
EnableHistoricalStatePruning bool // EnableHistoricalStatePruning when updating finalized states.
EnableCommitteesCache bool // EnableCommitteesCache for state transition.
EnableBlockAncestorCache bool //EnableBlockAncestorCache for fork choice optimization.
DisableGossipSub bool // DisableGossipSub in p2p messaging.
}
var featureConfig *FeatureFlagConfig
// FeatureConfig retrieves feature config.
func FeatureConfig() *FeatureFlagConfig {
if featureConfig == nil {
return &FeatureFlagConfig{}
}
return featureConfig
}
// InitFeatureConfig sets the global config equal to the config that is passed in.
func InitFeatureConfig(c *FeatureFlagConfig) {
featureConfig = c
}
// ConfigureBeaconFeatures sets the global config based
// on what flags are enabled for the beacon-chain client.
func ConfigureBeaconFeatures(ctx *cli.Context) {
cfg := &FeatureFlagConfig{}
if ctx.GlobalBool(VerifyAttestationSigsFlag.Name) {
log.Info("Verifying signatures for attestations")
cfg.VerifyAttestationSigs = true
}
if ctx.GlobalBool(EnableComputeStateRootFlag.Name) {
log.Info("Enabled compute state root server side")
cfg.EnableComputeStateRoot = true
}
if ctx.GlobalBool(EnableCrosslinksFlag.Name) {
log.Info("Enabled crosslink computations")
cfg.EnableCrosslinks = true
}
if ctx.GlobalBool(EnableCheckBlockStateRootFlag.Name) {
log.Info("Enabled check block state root")
cfg.EnableCheckBlockStateRoot = true
}
if ctx.GlobalBool(EnableHistoricalStatePruningFlag.Name) {
log.Info("Enabled historical state pruning")
cfg.EnableHistoricalStatePruning = true
}
if ctx.GlobalBool(EnableCommitteesCacheFlag.Name) {
log.Info("Enabled committees cache")
cfg.EnableCommitteesCache = true
}
if ctx.GlobalBool(EnableBlockAncestorCacheFlag.Name) {
log.Info("Enabled block ancestor cache")
cfg.EnableBlockAncestorCache = true
}
if ctx.GlobalBool(DisableGossipSubFlag.Name) {
log.Info("Disabled gossipsub, using floodsub")
cfg.DisableGossipSub = true
}
InitFeatureConfig(cfg)
}
// ConfigureValidatorFeatures sets the global config based
// on what flags are enabled for the validator client.
func ConfigureValidatorFeatures(ctx *cli.Context) {
cfg := &FeatureFlagConfig{}
if ctx.GlobalBool(VerifyAttestationSigsFlag.Name) {
log.Info("Verifying signatures for attestations")
cfg.VerifyAttestationSigs = true
}
InitFeatureConfig(cfg)
}