mirror of
https://gitlab.com/pulsechaincom/prysm-pulse.git
synced 2024-12-23 11:57:18 +00:00
e43152102e
* Identify invalid signature within batch verification (#11582) * Fix issues found by linter * Make deepsource happy * Add signature description enums * Make descriptions a mandatory field * More readable error message of invalid signatures * Add 'enable-verbose-sig-verification' option * Fix format * Move descriptions to package signing * Add more validation and test cases * Fix build failure Co-authored-by: Nishant Das <nishdas93@gmail.com>
88 lines
2.5 KiB
Go
88 lines
2.5 KiB
Go
package sync
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
pubsub "github.com/libp2p/go-libp2p-pubsub"
|
|
"github.com/prysmaticlabs/prysm/v3/beacon-chain/core/signing"
|
|
"github.com/prysmaticlabs/prysm/v3/crypto/bls"
|
|
"github.com/prysmaticlabs/prysm/v3/testing/assert"
|
|
"github.com/prysmaticlabs/prysm/v3/testing/util"
|
|
)
|
|
|
|
func TestValidateWithBatchVerifier(t *testing.T) {
|
|
_, keys, err := util.DeterministicDepositsAndKeys(10)
|
|
assert.NoError(t, err)
|
|
sig := keys[0].Sign(make([]byte, 32))
|
|
badSig := keys[1].Sign(make([]byte, 32))
|
|
validSet := &bls.SignatureBatch{
|
|
Messages: [][32]byte{{}},
|
|
PublicKeys: []bls.PublicKey{keys[0].PublicKey()},
|
|
Signatures: [][]byte{sig.Marshal()},
|
|
Descriptions: []string{signing.UnknownSignature},
|
|
}
|
|
invalidSet := &bls.SignatureBatch{
|
|
Messages: [][32]byte{{}},
|
|
PublicKeys: []bls.PublicKey{keys[0].PublicKey()},
|
|
Signatures: [][]byte{badSig.Marshal()},
|
|
Descriptions: []string{signing.UnknownSignature},
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
message string
|
|
set *bls.SignatureBatch
|
|
preFilledSets []*bls.SignatureBatch
|
|
want pubsub.ValidationResult
|
|
}{
|
|
{
|
|
name: "empty queue",
|
|
message: "random",
|
|
set: validSet,
|
|
want: pubsub.ValidationAccept,
|
|
},
|
|
{
|
|
name: "invalid set",
|
|
message: "random",
|
|
set: invalidSet,
|
|
want: pubsub.ValidationReject,
|
|
},
|
|
{
|
|
name: "invalid set in routine with valid set",
|
|
message: "random",
|
|
set: validSet,
|
|
preFilledSets: []*bls.SignatureBatch{invalidSet},
|
|
want: pubsub.ValidationAccept,
|
|
},
|
|
{
|
|
name: "valid set in routine with invalid set",
|
|
message: "random",
|
|
set: invalidSet,
|
|
preFilledSets: []*bls.SignatureBatch{validSet},
|
|
want: pubsub.ValidationReject,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
svc := &Service{
|
|
ctx: ctx,
|
|
cancel: cancel,
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go svc.verifierRoutine()
|
|
for _, st := range tt.preFilledSets {
|
|
svc.signatureChan <- &signatureVerifier{set: st, resChan: make(chan error, 10)}
|
|
}
|
|
got, err := svc.validateWithBatchVerifier(context.Background(), tt.message, tt.set)
|
|
if got != tt.want {
|
|
t.Errorf("validateWithBatchVerifier() = %v, want %v", got, tt.want)
|
|
}
|
|
if err != nil && tt.want == pubsub.ValidationAccept {
|
|
t.Errorf("Wanted no error but received: %v", err)
|
|
}
|
|
cancel()
|
|
})
|
|
}
|
|
}
|