prysm-pulse/beacon-chain/sync/subscriber_beacon_blocks.go
Preston Van Loon aa52e693ce
Sync: do not remove attestations from pool on failed block processing (#6474)
* Add test and return error on failed block processing
* use atts in body
* Merge branch 'master' into p2p-potential-error-block
2020-07-02 20:24:30 +00:00

64 lines
1.7 KiB
Go

package sync
import (
"context"
"errors"
"github.com/gogo/protobuf/proto"
ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
"github.com/prysmaticlabs/prysm/beacon-chain/core/state/interop"
"github.com/prysmaticlabs/prysm/beacon-chain/state/stateutil"
)
func (s *Service) beaconBlockSubscriber(ctx context.Context, msg proto.Message) error {
signed, ok := msg.(*ethpb.SignedBeaconBlock)
if !ok {
return errors.New("message is not type *ethpb.SignedBeaconBlock")
}
if signed == nil || signed.Block == nil {
return errors.New("nil block")
}
s.setSeenBlockIndexSlot(signed.Block.Slot, signed.Block.ProposerIndex)
block := signed.Block
root, err := stateutil.BlockRoot(block)
if err != nil {
return err
}
if err := s.chain.ReceiveBlockNoPubsub(ctx, signed, root); err != nil {
interop.WriteBlockToDisk(signed, true /*failed*/)
return err
}
// Delete attestations from the block in the pool to avoid inclusion in future block.
if err := s.deleteAttsInPool(block.Body.Attestations); err != nil {
log.Errorf("Could not delete attestations in pool: %v", err)
return nil
}
return err
}
// The input attestations are seen by the network, this deletes them from pool
// so proposers don't include them in a block for the future.
func (s *Service) deleteAttsInPool(atts []*ethpb.Attestation) error {
for _, att := range atts {
if helpers.IsAggregated(att) {
if err := s.attPool.DeleteAggregatedAttestation(att); err != nil {
return err
}
} else {
// Ideally there's shouldn't be any unaggregated attestation in the block.
if err := s.attPool.DeleteUnaggregatedAttestation(att); err != nil {
return err
}
}
}
return nil
}