prysm-pulse/shared/featureconfig/config.go
Preston Van Loon dfc64121c6
Remove unused feature flags (#3002)
* remove a few feature flags that are no longer needed

* remove other unused flags

* forgot a few more
2019-07-19 21:27:35 -04:00

75 lines
2.7 KiB
Go

/*
Package featureconfig defines which features are enabled for runtime
in order to selctively enable certain features to maintain a stable runtime.
The process for implementing new features using this package is as follows:
1. Add a new CMD flag in flags.go, and place it in the proper list(s) var for its client.
2. Add a condition for the flag in the proper Configure function(s) below.
3. Place any "new" behavior in the `if flagEnabled` statement.
4. Place any "previous" behavior in the `else` statement.
5. Ensure any tests using the new feature fail if the flag isn't enabled.
5a. Use the following to enable your flag for tests:
cfg := &featureconfig.FeatureFlagConfig{
VerifyAttestationSigs: true,
}
featureconfig.InitFeatureConfig(cfg)
*/
package featureconfig
import (
"github.com/sirupsen/logrus"
"github.com/urfave/cli"
)
var log = logrus.WithField("prefix", "flags")
// FeatureFlagConfig is a struct to represent what features the client will perform on runtime.
type FeatureFlagConfig struct {
DisableHistoricalStatePruning bool // DisableHistoricalStatePruning when updating finalized states.
DisableGossipSub bool // DisableGossipSub in p2p messaging.
EnableCommitteesCache bool // EnableCommitteesCache for state transition.
EnableExcessDeposits bool // EnableExcessDeposits in validator balances.
NoGenesisDelay bool // NoGenesisDelay when processing a chain start genesis event.
}
var featureConfig *FeatureFlagConfig
// FeatureConfig retrieves feature config.
func FeatureConfig() *FeatureFlagConfig {
if featureConfig == nil {
return &FeatureFlagConfig{}
}
return featureConfig
}
// InitFeatureConfig sets the global config equal to the config that is passed in.
func InitFeatureConfig(c *FeatureFlagConfig) {
featureConfig = c
}
// ConfigureBeaconFeatures sets the global config based
// on what flags are enabled for the beacon-chain client.
func ConfigureBeaconFeatures(ctx *cli.Context) {
cfg := &FeatureFlagConfig{}
if ctx.GlobalBool(DisableHistoricalStatePruningFlag.Name) {
log.Info("Enabled historical state pruning")
cfg.DisableHistoricalStatePruning = true
}
if ctx.GlobalBool(DisableGossipSubFlag.Name) {
log.Info("Disabled gossipsub, using floodsub")
cfg.DisableGossipSub = true
}
if ctx.GlobalBool(NoGenesisDelayFlag.Name) {
log.Warn("Using non standard genesis delay. This may cause problems in a multi-node environment.")
cfg.NoGenesisDelay = true
}
InitFeatureConfig(cfg)
}
// ConfigureValidatorFeatures sets the global config based
// on what flags are enabled for the validator client.
func ConfigureValidatorFeatures(ctx *cli.Context) {
cfg := &FeatureFlagConfig{}
InitFeatureConfig(cfg)
}