prysm-pulse/validator/db/convert.go
Manu NALEPA ef21d3adf8
Implement EIP-3076 minimal slashing protection, using a filesystem database (#13360)
* `EpochFromString`: Use already defined `Uint64FromString` function.

* `Test_uint64FromString` => `Test_FromString`

This test function tests more functions than `Uint64FromString`.

* Slashing protection history: Remove unreachable code.

The function `NewKVStore` creates, via `kv.UpdatePublicKeysBuckets`,
a new item in the `proposal-history-bucket-interchange`.

IMO there is no real reason to prefer `proposal` than `attestation`
as a prefix for this bucket, but this is the way it is done right now
and renaming the bucket will probably be backward incompatible.

An `attestedPublicKey` cannot exist without
the corresponding `proposedPublicKey`.

Thus, the `else` portion of code removed in this commit is not reachable.
We raise an error if we get there.

This is also probably the reason why the removed `else` portion was not
tested.

* `NewKVStore`: Switch items in `createBuckets`.

So the order corresponds to `schema.go`

* `slashableAttestationCheck`: Fix comments and logs.

* `ValidatorClient.db`: Use `iface.ValidatorDB`.

* BoltDB database: Implement `GraffitiFileHash`.

* Filesystem database: Creates `db.go`.

This file defines the following structs:
- `Store`
- `Graffiti`
- `Configuration`
- `ValidatorSlashingProtection`

This files implements the following public functions:
- `NewStore`
- `Close`
- `Backup`
- `DatabasePath`
- `ClearDB`
- `UpdatePublicKeysBuckets`

This files implements the following private functions:
- `slashingProtectionDirPath`
- `configurationFilePath`
- `configuration`
- `saveConfiguration`
- `validatorSlashingProtection`
- `saveValidatorSlashingProtection`
- `publicKeys`

* Filesystem database: Creates `genesis.go`.

This file defines the following public functions:
- `GenesisValidatorsRoot`
- `SaveGenesisValidatorsRoot`

* Filesystem database: Creates `graffiti.go`.

This file defines the following public functions:
- `SaveGraffitiOrderedIndex`
- `GraffitiOrderedIndex`

* Filesystem database: Creates `migration.go`.

This file defines the following public functions:
- `RunUpMigrations`
- `RunDownMigrations`

* Filesystem database: Creates proposer_settings.go.

This file defines the following public functions:
- `ProposerSettings`
- `ProposerSettingsExists`
- `SaveProposerSettings`

* Filesystem database: Creates `attester_protection.go`.

This file defines the following public functions:
- `EIPImportBlacklistedPublicKeys`
- `SaveEIPImportBlacklistedPublicKeys`
- `SigningRootAtTargetEpoch`
- `LowestSignedTargetEpoch`
- `LowestSignedSourceEpoch`
- `AttestedPublicKeys`
- `CheckSlashableAttestation`
- `SaveAttestationForPubKey`
- `SaveAttestationsForPubKey`
- `AttestationHistoryForPubKey`

* Filesystem database: Creates `proposer_protection.go`.

This file defines the following public functions:
- `HighestSignedProposal`
- `LowestSignedProposal`
- `ProposalHistoryForPubKey`
- `ProposalHistoryForSlot`
- `ProposedPublicKeys`

* Ensure that the filesystem store implements the `ValidatorDB` interface.

* `slashableAttestationCheck`: Check the database type.

* `slashableProposalCheck`: Check the database type.

* `slashableAttestationCheck`: Allow usage of minimal slashing protection.

* `slashableProposalCheck`: Allow usage of minimal slashing protection.

* `ImportStandardProtectionJSON`: Check the database type.

* `ImportStandardProtectionJSON`: Allow usage of min slashing protection.

* Implement `RecursiveDirFind`.

* Implement minimal<->complete DB conversion.

3 public functions are implemented:
- `IsCompleteDatabaseExisting`
- `IsMinimalDatabaseExisting`
- `ConvertDatabase`

* `setupDB`: Add `isSlashingProtectionMinimal` argument.

The feature addition is located in `validator/node/node_test.go`.
The rest of this commit consists in minimal slashing protection testing.

* `setupWithKey`: Add `isSlashingProtectionMinimal` argument.

The feature addition is located in `validator/client/propose_test.go`.

The rest of this commit consists in tests wrapping.

* `setup`: Add `isSlashingProtectionMinimal` argument.

The added feature is located in the `validator/client/propose_test.go`
file.

The rest of this commit consists in tests wrapping.

* `initializeFromCLI` and `initializeForWeb`: Factorize db init.

* Add `convert-complete-to-minimal` command.

* Creates `--enable-minimal-slashing-protection` flag.

* `importSlashingProtectionJSON`: Check database type.

* `exportSlashingProtectionJSON`: Check database type.

* `TestClearDB`: Test with minimal slashing protection.

* KeyManager: Test with minimal slashing protection.

* RPC: KeyManager: Test with minimal slashing protection.

* `convert-complete-to-minimal`: Change option names.

Options were:
- `--source` (for source data directory), and
- `--target` (for target data directory)

However, since this command deals with slashing protection, which has
source (epochs) and target (epochs), the initial option names may confuse
the user.

In this commit:
`--source` ==> `--source-data-dir`
`--target` ==> `--target-data-dir`

* Set `SlashableAttestationCheck` as an iface method.

And delete `CheckSlashableAttestation` from iface.

* Move helpers functions in a more general directory.

No functional change.

* Extract common structs out of `kv`.

==> `filesystem` does not depend anymore on `kv`.
==> `iface` does not depend anymore on `kv`.
==> `slashing-protection` does not depend anymore on `kv`.

* Move `ValidateMetadata` in `validator/helpers`.

* `ValidateMetadata`: Test with mock.

This way, we can:
- Avoid any circular import for tests.
- Implement once for all `iface.ValidatorDB` implementations
  the `ValidateMetadata`function.
- Have tests (and coverage) of `ValidateMetadata`in
  its own package.

The ideal solution would have been to implement `ValidateMetadata` as
a method with the `iface.ValidatorDB`receiver.
Unfortunately, golang does not allow that.

* `iface.ValidatorDB`: Implement ImportStandardProtectionJSON.

The whole purpose of this commit is to avoid the `switch validatorDB.(type)`
in `ImportStandardProtectionJSON`.

* `iface.ValidatorDB`: Implement `SlashableProposalCheck`.

* Remove now useless `slashableProposalCheck`.

* Delete useless `ImportStandardProtectionJSON`.

* `file.Exists`: Detect directories and return an error.

Before, `Exists` was only able to detect if a file exists.
Now, this function takes an extra `File` or `Directory` argument.
It detects either if a file or a directory exists.

Before, if an error was returned by `os.Stat`, the the file was
considered as non existing.
Now, it is treated as a real error.

* Replace `os.Stat` by `file.Exists`.

* Remove `Is{Complete,Minimal}DatabaseExisting`.

* `publicKeys`: Add log if unexpected file found.

* Move `{Source,Target}DataDirFlag`in `db.go`.

* `failedAttLocalProtectionErr`: `var`==> `const`

* `signingRoot`: `32`==> `fieldparams.RootLength`.

* `validatorClientData`==> `validator-client-data`.

To be consistent with `slashing-protection`.

* Add progress bars for `import` and `convert`.

* `parseBlocksForUniquePublicKeys`: Move in `db/kv`.

* helpers: Remove unused `initializeProgressBar` function.
2024-03-05 15:27:15 +00:00

258 lines
7.4 KiB
Go

package db
import (
"context"
"path/filepath"
"github.com/pkg/errors"
fieldparams "github.com/prysmaticlabs/prysm/v5/config/fieldparams"
"github.com/prysmaticlabs/prysm/v5/consensus-types/primitives"
"github.com/prysmaticlabs/prysm/v5/io/file"
ethpb "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1"
"github.com/prysmaticlabs/prysm/v5/validator/db/common"
"github.com/prysmaticlabs/prysm/v5/validator/db/filesystem"
"github.com/prysmaticlabs/prysm/v5/validator/db/iface"
"github.com/prysmaticlabs/prysm/v5/validator/db/kv"
)
// ConvertDatabase converts a minimal database to a complete database or a complete database to a minimal database.
// Delete the source database after conversion.
func ConvertDatabase(ctx context.Context, sourceDataDir string, targetDataDir string, minimalToComplete bool) error {
// Check if the source database exists.
var (
sourceDatabaseExists bool
err error
)
if minimalToComplete {
sourceDataBasePath := filepath.Join(sourceDataDir, filesystem.DatabaseDirName)
sourceDatabaseExists, err = file.Exists(sourceDataBasePath, file.Directory)
} else {
sourceDataBasePath := filepath.Join(sourceDataDir, kv.ProtectionDbFileName)
sourceDatabaseExists, err = file.Exists(sourceDataBasePath, file.Regular)
}
if err != nil {
return errors.Wrap(err, "could not check if source database exists")
}
// If the source database does not exist, there is nothing to convert.
if !sourceDatabaseExists {
return errors.New("source database does not exist")
}
// Get the source database.
var sourceDatabase iface.ValidatorDB
if minimalToComplete {
sourceDatabase, err = filesystem.NewStore(sourceDataDir, nil)
} else {
sourceDatabase, err = kv.NewKVStore(ctx, sourceDataDir, nil)
}
if err != nil {
return errors.Wrap(err, "could not get source database")
}
// Close the source database.
defer func() {
if err := sourceDatabase.Close(); err != nil {
log.WithError(err).Error("Failed to close source database")
}
}()
// Create the target database.
var targetDatabase iface.ValidatorDB
if minimalToComplete {
targetDatabase, err = kv.NewKVStore(ctx, targetDataDir, nil)
} else {
targetDatabase, err = filesystem.NewStore(targetDataDir, nil)
}
if err != nil {
return errors.Wrap(err, "could not create target database")
}
// Close the target database.
defer func() {
if err := targetDatabase.Close(); err != nil {
log.WithError(err).Error("Failed to close target database")
}
}()
// Genesis
// -------
// Get the genesis validators root.
genesisValidatorRoot, err := sourceDatabase.GenesisValidatorsRoot(ctx)
if err != nil {
return errors.Wrap(err, "could not get genesis validators root from source database")
}
// Save the genesis validators root.
if err := targetDatabase.SaveGenesisValidatorsRoot(ctx, genesisValidatorRoot); err != nil {
return errors.Wrap(err, "could not save genesis validators root")
}
// Graffiti
// --------
// Get the graffiti file hash.
graffitiFileHash, exists, err := sourceDatabase.GraffitiFileHash()
if err != nil {
return errors.Wrap(err, "could not get graffiti file hash from source database")
}
if exists {
// Calling GraffitiOrderedIndex will save the graffiti file hash.
if _, err := targetDatabase.GraffitiOrderedIndex(ctx, graffitiFileHash); err != nil {
return errors.Wrap(err, "could get graffiti ordered index")
}
}
// Get the graffiti ordered index.
graffitiOrderedIndex, err := sourceDatabase.GraffitiOrderedIndex(ctx, graffitiFileHash)
if err != nil {
return errors.Wrap(err, "could not get graffiti ordered index from source database")
}
// Save the graffiti ordered index.
if err := targetDatabase.SaveGraffitiOrderedIndex(ctx, graffitiOrderedIndex); err != nil {
return errors.Wrap(err, "could not save graffiti ordered index")
}
// Proposer settings
// -----------------
// Get the proposer settings.
proposerSettings, err := sourceDatabase.ProposerSettings(ctx)
if err != nil {
return errors.Wrap(err, "could not get proposer settings from source database")
}
// Save the proposer settings.
if err := targetDatabase.SaveProposerSettings(ctx, proposerSettings); err != nil {
return errors.Wrap(err, "could not save proposer settings")
}
// Attestations
// ------------
// Get all public keys that have attested.
attestedPublicKeys, err := sourceDatabase.AttestedPublicKeys(ctx)
if err != nil {
return errors.Wrap(err, "could not get attested public keys from source database")
}
// Initialize the progress bar.
bar := common.InitializeProgressBar(
len(attestedPublicKeys),
"Processing attestations:",
)
for _, pubkey := range attestedPublicKeys {
// Update the progress bar.
if err := bar.Add(1); err != nil {
log.WithError(err).Debug("Could not increase progress bar")
}
// Get the attestation records.
attestationRecords, err := sourceDatabase.AttestationHistoryForPubKey(ctx, pubkey)
if err != nil {
return errors.Wrap(err, "could not get attestation history for public key")
}
// If there are no attestation records, skip this public key.
if len(attestationRecords) == 0 {
continue
}
highestSource, highestTarget := primitives.Epoch(0), primitives.Epoch(0)
for _, record := range attestationRecords {
// If the record is nil, skip it.
if record == nil {
continue
}
// Get the highest source and target epoch.
if record.Source > highestSource {
highestSource = record.Source
}
if record.Target > highestTarget {
highestTarget = record.Target
}
}
// Create the indexed attestation with the highest source and target epoch.
indexedAttestation := &ethpb.IndexedAttestation{
Data: &ethpb.AttestationData{
Source: &ethpb.Checkpoint{
Epoch: highestSource,
},
Target: &ethpb.Checkpoint{
Epoch: highestTarget,
},
},
}
if err := targetDatabase.SaveAttestationForPubKey(ctx, pubkey, [fieldparams.RootLength]byte{}, indexedAttestation); err != nil {
return errors.Wrap(err, "could not save attestation for public key")
}
}
// Proposals
// ---------
// Get all pubkeys in database.
proposedPublicKeys, err := sourceDatabase.ProposedPublicKeys(ctx)
if err != nil {
return errors.Wrap(err, "could not get proposed public keys from source database")
}
// Initialize the progress bar.
bar = common.InitializeProgressBar(
len(attestedPublicKeys),
"Processing proposals:",
)
for _, pubkey := range proposedPublicKeys {
// Update the progress bar.
if err := bar.Add(1); err != nil {
log.WithError(err).Debug("Could not increase progress bar")
}
// Get the proposal history.
proposals, err := sourceDatabase.ProposalHistoryForPubKey(ctx, pubkey)
if err != nil {
return errors.Wrap(err, "could not get proposal history for public key")
}
// If there are no proposals, skip this public key.
if len(proposals) == 0 {
continue
}
highestSlot := primitives.Slot(0)
for _, proposal := range proposals {
// If proposal is nil, skip it.
if proposal == nil {
continue
}
// Get the highest slot.
if proposal.Slot > highestSlot {
highestSlot = proposal.Slot
}
}
// Save the proposal history for the highest slot.
if err := targetDatabase.SaveProposalHistoryForSlot(ctx, pubkey, highestSlot, nil); err != nil {
return errors.Wrap(err, "could not save proposal history for public key")
}
}
// Delete the source database.
if err := sourceDatabase.ClearDB(); err != nil {
return errors.Wrap(err, "could not delete source database")
}
return nil
}