prysm-pulse/beacon-chain/p2p/handshake.go
Preston Van Loon fa7b8ab60d A few improvements to handshake (#4214)
* A few improvements to handshake and exit round robin
* revert beacon-chain/sync/initial-sync/round_robin.go
* Merge refs/heads/master into p2p-fixes
* make handshake non-blocking
* Merge branch 'p2p-fixes' of github.com:prysmaticlabs/prysm into p2p-fixes
* Merge refs/heads/master into p2p-fixes
* Merge refs/heads/master into p2p-fixes
* Merge refs/heads/master into p2p-fixes
* Update handshake.go
2019-12-08 05:12:56 +00:00

91 lines
3.4 KiB
Go

package p2p
import (
"context"
"fmt"
"io"
"time"
"github.com/libp2p/go-libp2p-core/network"
"github.com/libp2p/go-libp2p-core/peer"
"github.com/prysmaticlabs/prysm/beacon-chain/sync/peerstatus"
"github.com/sirupsen/logrus"
)
// AddConnectionHandler adds a callback function which handles the connection with a
// newly added peer. It performs a handshake with that peer by sending a hello request
// and validating the response from the peer.
func (s *Service) AddConnectionHandler(reqFunc func(ctx context.Context, id peer.ID) error) {
s.host.Network().Notify(&network.NotifyBundle{
ConnectedF: func(net network.Network, conn network.Conn) {
if peerCount(s.host) > int(s.cfg.MaxPeers) {
if err := s.Disconnect(conn.RemotePeer()); err != nil {
log.WithError(err).Errorf("Unable to close peer %s", conn.RemotePeer())
return
}
}
multiAddr := fmt.Sprintf("%s/p2p/%s", conn.RemoteMultiaddr().String(), conn.RemotePeer().String())
log.WithFields(logrus.Fields{
"direction": conn.Stat().Direction,
"multiAddr": multiAddr,
"peerCount": peerCount(s.host),
}).Debug("Connection")
if peerstatus.IsBadPeer(conn.RemotePeer()) {
// Add Peer to gossipsub blacklist
s.pubsub.BlacklistPeer(conn.RemotePeer())
log.WithField("peerID", conn.RemotePeer().Pretty()).Trace("Disconnecting with bad peer")
if err := s.Disconnect(conn.RemotePeer()); err != nil {
log.WithError(err).Errorf("Unable to close peer %s", conn.RemotePeer())
return
}
return
}
// ConnectedF must be non-blocking as part of libp2p design.
go func() {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
log := log.WithField("peer", conn.RemotePeer().Pretty())
log.Debug("Performing handshake with peer")
if err := reqFunc(ctx, conn.RemotePeer()); err != nil && err != io.EOF {
log.WithError(err).Debug("Could not send successful hello rpc request")
if err.Error() == "protocol not supported" {
// This is only to ensure the smooth running of our testnets. This will not be
// used in production.
log.Debug("Not disconnecting peer with unsupported protocol. This may be the DHT node or relay.")
s.host.ConnManager().Protect(conn.RemotePeer(), "relay/bootnode")
return
}
if err := s.Disconnect(conn.RemotePeer()); err != nil {
log.WithError(err).Errorf("Unable to close peer %s", conn.RemotePeer())
return
}
return
}
log.WithField("peer", conn.RemotePeer().Pretty()).Info("New peer connected")
}()
},
})
}
// AddDisconnectionHandler ensures that previously disconnected peers aren't dialed again. Due
// to either their ports being closed, nodes are no longer active,etc. This also calls the handler
// responsible for maintaining other parts of the sync or p2p system.
func (s *Service) AddDisconnectionHandler(handler func(ctx context.Context, id peer.ID) error) {
s.host.Network().Notify(&network.NotifyBundle{
DisconnectedF: func(net network.Network, conn network.Conn) {
// Must be handled in a goroutine as this callback cannot be blocking.
go func() {
s.exclusionList.Set(conn.RemotePeer().String(), true, 1)
log := log.WithField("peer", conn.RemotePeer())
log.Debug("Peer is added to exclusion list")
ctx := context.Background()
if err := handler(ctx, conn.RemotePeer()); err != nil {
log.WithError(err).Error("Failed to handle disconnecting peer")
}
}()
},
})
}