prysm-pulse/beacon-chain/rpc/proposer_server_test.go
Preston Van Loon f44c7082d8
Prevent invalid pending attestations (#1994)
* prevent invalid pending attestations

* no past block

* regress test

* +1

* fix lint

* fix buld

* revert unrelated

* passing tests, still need regression tst
2019-03-19 12:25:34 -04:00

269 lines
7.2 KiB
Go

package rpc
import (
"context"
"strconv"
"testing"
"time"
b "github.com/prysmaticlabs/prysm/beacon-chain/core/blocks"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
"github.com/prysmaticlabs/prysm/beacon-chain/core/state"
"github.com/prysmaticlabs/prysm/beacon-chain/internal"
pbp2p "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1"
pb "github.com/prysmaticlabs/prysm/proto/beacon/rpc/v1"
"github.com/prysmaticlabs/prysm/shared/params"
)
func TestProposeBlock_OK(t *testing.T) {
db := internal.SetupDB(t)
defer internal.TeardownDB(t, db)
mockChain := &mockChainService{}
genesis := b.NewGenesisBlock([]byte{})
if err := db.SaveBlock(genesis); err != nil {
t.Fatalf("Could not save genesis block: %v", err)
}
deposits := make([]*pbp2p.Deposit, params.BeaconConfig().DepositsForChainStart)
for i := 0; i < len(deposits); i++ {
depositData, err := helpers.EncodeDepositData(
&pbp2p.DepositInput{
Pubkey: []byte(strconv.Itoa(i)),
},
params.BeaconConfig().MaxDepositAmount,
time.Now().Unix(),
)
if err != nil {
t.Fatalf("Could not encode deposit input: %v", err)
}
deposits[i] = &pbp2p.Deposit{
DepositData: depositData,
}
}
beaconState, err := state.GenesisBeaconState(deposits, 0, nil)
if err != nil {
t.Fatalf("Could not instantiate genesis state: %v", err)
}
if err := db.UpdateChainHead(genesis, beaconState); err != nil {
t.Fatalf("Could not save genesis state: %v", err)
}
proposerServer := &ProposerServer{
chainService: mockChain,
beaconDB: db,
powChainService: &mockPOWChainService{},
}
req := &pbp2p.BeaconBlock{
Slot: 5,
ParentRootHash32: []byte("parent-hash"),
}
if _, err := proposerServer.ProposeBlock(context.Background(), req); err != nil {
t.Errorf("Could not propose block correctly: %v", err)
}
}
func TestComputeStateRoot_OK(t *testing.T) {
db := internal.SetupDB(t)
defer internal.TeardownDB(t, db)
mockChain := &mockChainService{}
genesis := b.NewGenesisBlock([]byte{})
if err := db.SaveBlock(genesis); err != nil {
t.Fatalf("Could not save genesis block: %v", err)
}
deposits := make([]*pbp2p.Deposit, params.BeaconConfig().DepositsForChainStart)
for i := 0; i < len(deposits); i++ {
depositData, err := helpers.EncodeDepositData(
&pbp2p.DepositInput{
Pubkey: []byte(strconv.Itoa(i)),
},
params.BeaconConfig().MaxDepositAmount,
time.Now().Unix(),
)
if err != nil {
t.Fatalf("Could not encode deposit input: %v", err)
}
deposits[i] = &pbp2p.Deposit{
DepositData: depositData,
}
}
beaconState, err := state.GenesisBeaconState(deposits, 0, nil)
if err != nil {
t.Fatalf("Could not instantiate genesis state: %v", err)
}
beaconState.Slot = 10
if err := db.UpdateChainHead(genesis, beaconState); err != nil {
t.Fatalf("Could not save genesis state: %v", err)
}
proposerServer := &ProposerServer{
chainService: mockChain,
beaconDB: db,
powChainService: &mockPOWChainService{},
}
req := &pbp2p.BeaconBlock{
ParentRootHash32: nil,
Slot: 11,
RandaoReveal: nil,
Body: &pbp2p.BeaconBlockBody{
ProposerSlashings: nil,
AttesterSlashings: nil,
},
}
_, _ = proposerServer.ComputeStateRoot(context.Background(), req)
}
func TestPendingAttestations_FiltersWithinInclusionDelay(t *testing.T) {
db := internal.SetupDB(t)
defer internal.TeardownDB(t, db)
beaconState := &pbp2p.BeaconState{
Slot: params.BeaconConfig().GenesisSlot + params.BeaconConfig().MinAttestationInclusionDelay + 100,
}
proposerServer := &ProposerServer{
operationService: &mockOperationService{
pendingAttestations: []*pbp2p.Attestation{
{Data: &pbp2p.AttestationData{
Slot: beaconState.Slot - params.BeaconConfig().MinAttestationInclusionDelay,
}},
},
},
beaconDB: db,
}
if err := db.SaveState(beaconState); err != nil {
t.Fatal(err)
}
blk := &pbp2p.BeaconBlock{
Slot: beaconState.Slot,
}
if err := db.SaveBlock(blk); err != nil {
t.Fatalf("failed to save block %v")
}
if err := db.UpdateChainHead(blk, beaconState); err != nil {
t.Fatalf("couldnt update chainhead: %v")
}
res, err := proposerServer.PendingAttestations(context.Background(), &pb.PendingAttestationsRequest{
FilterReadyForInclusion: true,
})
if err != nil {
t.Fatalf("Unexpected error fetching pending attestations: %v", err)
}
if len(res.PendingAttestations) == 0 {
t.Error("Expected pending attestations list to be non-empty")
}
}
func TestPendingAttestations_FiltersExpiredAttestations(t *testing.T) {
db := internal.SetupDB(t)
defer internal.TeardownDB(t, db)
// Edge case: current slot is at the end of an epoch. The pending attestation
// for the next slot should come from currentSlot + 1.
currentSlot := helpers.StartSlot(
params.BeaconConfig().GenesisEpoch+10,
) - 1
opService := &mockOperationService{
pendingAttestations: []*pbp2p.Attestation{
// Expired attestations
{Data: &pbp2p.AttestationData{Slot: 0}},
{Data: &pbp2p.AttestationData{Slot: currentSlot - 10000}},
{Data: &pbp2p.AttestationData{Slot: currentSlot - 5000}},
{Data: &pbp2p.AttestationData{Slot: currentSlot - 100}},
{Data: &pbp2p.AttestationData{Slot: currentSlot - params.BeaconConfig().SlotsPerEpoch}},
// Non-expired attestations
{Data: &pbp2p.AttestationData{Slot: currentSlot - 5}},
{Data: &pbp2p.AttestationData{Slot: currentSlot - 2}},
{Data: &pbp2p.AttestationData{Slot: currentSlot}},
},
}
expectedNumberOfAttestations := 3
proposerServer := &ProposerServer{
operationService: opService,
beaconDB: db,
}
beaconState := &pbp2p.BeaconState{
Slot: currentSlot,
}
if err := db.SaveState(beaconState); err != nil {
t.Fatal(err)
}
blk := &pbp2p.BeaconBlock{
Slot: beaconState.Slot,
}
if err := db.SaveBlock(blk); err != nil {
t.Fatalf("failed to save block %v")
}
if err := db.UpdateChainHead(blk, beaconState); err != nil {
t.Fatalf("couldnt update chainhead: %v")
}
res, err := proposerServer.PendingAttestations(
context.Background(),
&pb.PendingAttestationsRequest{
ProposalBlockSlot: currentSlot,
},
)
if err != nil {
t.Fatalf("Unexpected error fetching pending attestations: %v", err)
}
if len(res.PendingAttestations) != expectedNumberOfAttestations {
t.Errorf(
"Expected pending attestations list length %d, but was %d",
expectedNumberOfAttestations,
len(res.PendingAttestations),
)
}
}
func TestPendingAttestations_OK(t *testing.T) {
db := internal.SetupDB(t)
defer internal.TeardownDB(t, db)
proposerServer := &ProposerServer{
operationService: &mockOperationService{},
beaconDB: db,
}
beaconState := &pbp2p.BeaconState{
Slot: params.BeaconConfig().GenesisSlot + params.BeaconConfig().MinAttestationInclusionDelay,
}
if err := db.SaveState(beaconState); err != nil {
t.Fatal(err)
}
blk := &pbp2p.BeaconBlock{
Slot: beaconState.Slot,
}
if err := db.SaveBlock(blk); err != nil {
t.Fatalf("failed to save block %v")
}
if err := db.UpdateChainHead(blk, beaconState); err != nil {
t.Fatalf("couldnt update chainhead: %v")
}
res, err := proposerServer.PendingAttestations(context.Background(), &pb.PendingAttestationsRequest{})
if err != nil {
t.Fatalf("Unexpected error fetching pending attestations: %v", err)
}
if len(res.PendingAttestations) == 0 {
t.Error("Expected pending attestations list to be non-empty")
}
}