mirror/go-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/go-pulse.git synced 2024-12-25 12:57:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed jsonrpc response 0 not handled properly

Browse Source
This commit is contained in:
Marek Kotewicz 2015-02-04 11:23:23 +01:00
parent a0cfa3ca21
commit f3e1797153
5 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/ethereum.js vendored
View File

@ -979,7 +979,7 @@ var isValidResponse = function (response) {
!response.error && !response.error &&
response.jsonrpc === '2.0' && response.jsonrpc === '2.0' &&
typeof response.id === 'number' && typeof response.id === 'number' &&
(!!response.result || typeof response.result === 'boolean'); response.result !== undefined; // only undefined is not valid json object
}; };
/// Should be called to create batch payload object /// Should be called to create batch payload object

2
dist/ethereum.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
dist/ethereum.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
lib/jsonrpc.js
View File

@ -45,7 +45,7 @@ var isValidResponse = function (response) {
!response.error && !response.error &&
response.jsonrpc === '2.0' && response.jsonrpc === '2.0' &&
typeof response.id === 'number' && typeof response.id === 'number' &&
(!!response.result || typeof response.result === 'boolean'); response.result !== undefined; // only undefined is not valid json object
}; };
/// Should be called to create batch payload object /// Should be called to create batch payload object

15
test/jsonrpc.isValidResponse.js
View File

@ -124,5 +124,20 @@ describe('jsonrpc', function () {
assert.equal(valid, true); assert.equal(valid, true);
}); });
it('should validate jsonrpc response with result field === 0', function () {
// given
var response = {
jsonrpc: '2.0',
id: 1,
result: 0
};
// when
var valid = jsonrpc.isValidResponse(response);
// then
assert.equal(valid, true);
});
}); });
}); });