mirror/go-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/go-pulse.git synced 2024-12-22 19:40:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

swarm/storage: fix loop bound for database cleanup (#19085)

Browse Source 
The current loop continuation condition is always true as a uint8
is always being checked whether it is less than 255 (its maximum
value). Since the loop starts with the value 1, the loop termination
can be guarranteed to exit once the value overflows to 0.
This commit is contained in:
Matthew Halpern 2019-02-20 21:37:32 -08:00 committed by Viktor Trón
parent 9d5e10f5bb
commit fbedf62f3d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
swarm/storage/ldbstore.go
View File

@ -527,8 +527,8 @@ func (s *LDBStore) Cleanup(f func(*chunk) bool) {
if err != nil {
found := false
// highest possible proximity is 255
for po = 1; po <= 255; po++ {
// The highest possible proximity is 255, so exit loop upon overflow.
for po = uint8(1); po != 0; po++ {
datakey = getDataKey(index.Idx, po)
data, err = s.db.Get(datakey)
if err == nil {