Felix Lange 909dd4a109 rlp/rlpgen: remove build tag (#28106) ... * rlp/rlpgen: remove build tag This tag was supposed to prevent unstable output when types reference each other. Imagine there are two struct types A and B, where a reference to type B is in A. If I run rlpgen on type B first, and then on type A, the generator will see the B.EncodeRLP method and call it. However, if I run rlpgen on type A first, it will inline the encoding of B. The solution I chose for the initial release of rlpgen was to just ignore methods generated by rlpgen using a build tag. But there is a problem with this: if any code in the package calls EncodeRLP explicitly, the package can't be loaded without errors anymore in rlpgen, because the loader ignores it. Would be nice if there was a way to just make it ignore invalid functions during type checking (they're not necessary for rlpgen), but golang.org/x/tools/go/packages does not provide a way of ignoring them. Luckily, the types we use rlpgen with do not reference each other right now, so we can just remove the build tags for now.		2023-09-14 12:28:40 +02:00
..
testdata	rlp: support for uint256 (#26898)	2023-03-17 06:51:55 -04:00
gen_test.go	rlp/rlpgen: print want/expect output string if mismatch (#26932)	2023-03-24 14:17:39 +01:00
gen.go	rlp: support for uint256 (#26898)	2023-03-17 06:51:55 -04:00
main.go	rlp/rlpgen: remove build tag (#28106)	2023-09-14 12:28:40 +02:00
types.go	rlp: support for uint256 (#26898)	2023-03-17 06:51:55 -04:00