go-pulse/accounts
Roberto Bayardo 67ac5f0ae7
core, core/types: plain Message struct (#25977)
Here, the core.Message interface turns into a plain struct and
types.Message gets removed.

This is a breaking change to packages core and core/types. While we do
not promise API stability for package core, we do for core/types. An
exception can be made for types.Message, since it doesn't have any
purpose apart from invoking the state transition in package core.
types.Message was also marked deprecated by the same commit it
got added in, 4dca5d4db7 (November 2016).

The core.Message interface was added in December 2014, in commit
db494170dc, for the purpose of 'testing' state transitions. It's the
same change that made transaction struct fields private. Before that,
the state transition used *types.Transaction directly.

Over time, multiple implementations of the interface accrued across
different packages, since constructing a Message is required whenever
one wants to invoke the state transition. These implementations all
looked very similar, a struct with private fields exposing the fields
as accessor methods.

By changing Message into a struct with public fields we can remove all
these useless interface implementations. It will also hopefully
simplify future changes to the type with less updates to apply across
all of go-ethereum when a field is added to Message.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
2023-03-09 14:19:12 +01:00
..
abi core, core/types: plain Message struct (#25977) 2023-03-09 14:19:12 +01:00
external all: more linters (#24783) 2022-06-13 16:24:45 +02:00
keystore all: remove deprecated uses of math.rand (#26710) 2023-02-16 14:36:58 -05:00
scwallet accounts/scwallet: fix keycard data signing error (#25331) 2022-10-27 10:06:28 +02:00
usbwallet accounts/usbwallet: mitigate ledger app chunking issue (#26773) 2023-03-07 15:20:04 +01:00
accounts_test.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
accounts.go build: upgrade to go 1.19 (#25726) 2022-09-10 13:25:40 +02:00
errors.go accounts: fix typo in comments (#24805) 2022-05-03 08:49:41 +02:00
hd_test.go accounts, signer: fix Ledger Live account derivation path (clef) (#21757) 2020-11-29 13:43:15 +01:00
hd.go build: upgrade to go 1.19 (#25726) 2022-09-10 13:25:40 +02:00
manager.go all: fix spelling mistakes (#25961) 2022-10-11 09:37:00 +02:00
sort.go accounts, console: frendly card errors, support pin unblock 2019-04-08 13:19:37 +02:00
url_test.go accounts: increase parseURL test coverage (#25033) 2022-06-07 12:46:27 +02:00
url.go build: upgrade to go 1.19 (#25726) 2022-09-10 13:25:40 +02:00