mirror of
https://gitlab.com/pulsechaincom/lighthouse-pulse.git
synced 2024-12-23 04:04:12 +00:00
1d016a83f2
## Description Add a new lint to CI that attempts to detect calls to functions like `block_on` from async execution contexts. This lint was written from scratch exactly for this purpose, on my fork of Clippy: https://github.com/michaelsproul/rust-clippy/tree/disallow-from-async ## Additional Info - I've successfully detected the previous two issues we had with `block_on` by running the linter on the commits prior to each of these PRs: https://github.com/sigp/lighthouse/pull/3165, https://github.com/sigp/lighthouse/pull/3199. - The lint runs on CI with `continue-on-error: true` so that if it fails spuriously it won't block CI. - I think it would be good to merge this PR before https://github.com/sigp/lighthouse/pull/3244 so that we can lint the extensive executor-related changes in that PR. - I aim to upstream the lint to Clippy, at which point building a custom version of Clippy from my fork will no longer be necessary. I imagine this will take several weeks or months though, because the code is currently a bit hacky and will need some renovations to pass review.
329 lines
10 KiB
YAML
329 lines
10 KiB
YAML
name: test-suite
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- stable
|
|
- staging
|
|
- trying
|
|
- 'pr/*'
|
|
pull_request:
|
|
env:
|
|
# Deny warnings in CI
|
|
RUSTFLAGS: "-D warnings"
|
|
# The Nightly version used for cargo-udeps, might need updating from time to time.
|
|
PINNED_NIGHTLY: nightly-2022-05-20
|
|
jobs:
|
|
target-branch-check:
|
|
name: target-branch-check
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request'
|
|
steps:
|
|
- name: Check that the pull request is not targeting the stable branch
|
|
run: test ${{ github.base_ref }} != "stable"
|
|
extract-msrv:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Extract Minimum Supported Rust Version (MSRV)
|
|
run: |
|
|
metadata=$(cargo metadata --no-deps --format-version 1)
|
|
msrv=$(echo $metadata | jq -r '.packages | map(select(.name == "lighthouse")) | .[0].rust_version')
|
|
echo "::set-output name=MSRV::$msrv"
|
|
id: extract_msrv
|
|
outputs:
|
|
MSRV: ${{ steps.extract_msrv.outputs.MSRV }}
|
|
cargo-fmt:
|
|
name: cargo-fmt
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Check formatting with cargo fmt
|
|
run: make cargo-fmt
|
|
release-tests-ubuntu:
|
|
name: release-tests-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run tests in release
|
|
run: make test-release
|
|
release-tests-windows:
|
|
name: release-tests-windows
|
|
runs-on: windows-2019
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v2
|
|
with:
|
|
node-version: '14'
|
|
- name: Install windows build tools
|
|
run: |
|
|
choco install python visualstudio2019-workload-vctools -y
|
|
npm config set msvs_version 2019
|
|
- name: Install ganache
|
|
run: npm install -g ganache --loglevel verbose
|
|
- name: Install make
|
|
run: choco install -y make
|
|
- uses: KyleMayes/install-llvm-action@v1
|
|
with:
|
|
version: "13.0"
|
|
directory: ${{ runner.temp }}/llvm
|
|
- name: Set LIBCLANG_PATH
|
|
run: echo "LIBCLANG_PATH=$((gcm clang).source -replace "clang.exe")" >> $env:GITHUB_ENV
|
|
- name: Run tests in release
|
|
run: make test-release
|
|
beacon-chain-tests:
|
|
name: beacon-chain-tests
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run beacon_chain tests for all known forks
|
|
run: make test-beacon-chain
|
|
op-pool-tests:
|
|
name: op-pool-tests
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run operation_pool tests for all known forks
|
|
run: make test-op-pool
|
|
debug-tests-ubuntu:
|
|
name: debug-tests-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run tests in debug
|
|
run: make test-debug
|
|
state-transition-vectors-ubuntu:
|
|
name: state-transition-vectors-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run state_transition_vectors in release.
|
|
run: make run-state-transition-tests
|
|
ef-tests-ubuntu:
|
|
name: ef-tests-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run consensus-spec-tests with blst, milagro and fake_crypto
|
|
run: make test-ef
|
|
dockerfile-ubuntu:
|
|
name: dockerfile-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Build the root Dockerfile
|
|
run: docker build --build-arg FEATURES=portable -t lighthouse:local .
|
|
- name: Test the built image
|
|
run: docker run -t lighthouse:local lighthouse --version
|
|
eth1-simulator-ubuntu:
|
|
name: eth1-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the beacon chain sim that starts from an eth1 contract
|
|
run: cargo run --release --bin simulator eth1-sim
|
|
no-eth1-simulator-ubuntu:
|
|
name: no-eth1-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the beacon chain sim without an eth1 connection
|
|
run: cargo run --release --bin simulator no-eth1-sim
|
|
syncing-simulator-ubuntu:
|
|
name: syncing-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the syncing simulator
|
|
run: cargo run --release --bin simulator syncing-sim
|
|
doppelganger-protection-test:
|
|
name: doppelganger-protection-test
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Install lighthouse and lcli
|
|
run: |
|
|
make
|
|
make install-lcli
|
|
- name: Run the doppelganger protection success test script
|
|
run: |
|
|
cd scripts/tests
|
|
./doppelganger_protection.sh success
|
|
- name: Run the doppelganger protection failure test script
|
|
run: |
|
|
cd scripts/tests
|
|
./doppelganger_protection.sh failure
|
|
execution-engine-integration-ubuntu:
|
|
name: execution-engine-integration-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.17'
|
|
- uses: actions/setup-dotnet@v1
|
|
with:
|
|
dotnet-version: '6.0.201'
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run exec engine integration tests in release
|
|
run: make test-exec-engine
|
|
check-benchmarks:
|
|
name: check-benchmarks
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Typecheck benchmark code without running it
|
|
run: make check-benches
|
|
check-consensus:
|
|
name: check-consensus
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Typecheck consensus code in strict mode
|
|
run: make check-consensus
|
|
clippy:
|
|
name: clippy
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Lint code for quality and style with Clippy
|
|
run: make lint
|
|
- name: Certify Cargo.lock freshness
|
|
run: git diff --exit-code Cargo.lock
|
|
disallowed-from-async-lint:
|
|
name: disallowed-from-async-lint
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
continue-on-error: true
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Install SigP Clippy fork
|
|
run: |
|
|
cd ..
|
|
git clone https://github.com/michaelsproul/rust-clippy.git
|
|
cd rust-clippy
|
|
git checkout 31a49666ccfcd7963b63345d6ce757c373f22c2a
|
|
cargo build --release --bin cargo-clippy --bin clippy-driver
|
|
cargo build --release --bin cargo-clippy --bin clippy-driver -Zunstable-options --out-dir $(rustc --print=sysroot)/bin
|
|
- name: Run Clippy with the disallowed-from-async lint
|
|
run: make nightly-lint
|
|
check-msrv:
|
|
name: check-msrv
|
|
runs-on: ubuntu-latest
|
|
needs: [cargo-fmt, extract-msrv]
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Install Rust @ MSRV (${{ needs.extract-msrv.outputs.MSRV }})
|
|
run: rustup override set ${{ needs.extract-msrv.outputs.MSRV }}
|
|
- name: Run cargo check
|
|
run: cargo check --workspace
|
|
arbitrary-check:
|
|
name: arbitrary-check
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Validate state_processing feature arbitrary-fuzz
|
|
run: make arbitrary-fuzz
|
|
cargo-audit:
|
|
name: cargo-audit
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run cargo audit to identify known security vulnerabilities reported to the RustSec Advisory Database
|
|
run: make audit
|
|
cargo-vendor:
|
|
name: cargo-vendor
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Run cargo vendor to make sure dependencies can be vendored for packaging, reproducibility and archival purpose
|
|
run: CARGO_HOME=$(readlink -f $HOME) make vendor
|
|
cargo-udeps:
|
|
name: cargo-udeps
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: Install Rust (${{ env.PINNED_NIGHTLY }})
|
|
run: rustup toolchain install $PINNED_NIGHTLY
|
|
- name: Install cargo-udeps
|
|
run: cargo install cargo-udeps --locked
|
|
- name: Create Cargo config dir
|
|
run: mkdir -p .cargo
|
|
- name: Install custom Cargo config
|
|
run: cp -f .github/custom/config.toml .cargo/config.toml
|
|
- name: Run cargo udeps to identify unused crates in the dependency graph
|
|
run: make udeps
|
|
env:
|
|
# Allow warnings on Nightly
|
|
RUSTFLAGS: ""
|