kasey
ce2344301c
forkchoice.Getter wrapper with locking wrappers ( #13244 )
...
* forkchoice.Getter wrapper with locking wrappers
* comments
* lint
* only expose fast fc getters
* potuz feedback re rlock
* update mocks for new fc method
* appease deepsource
* add missing exported func comment
* yeet errors to make the linter happy
* even more devious _discard
* rm TargetRoot
* derp
* handle nil error in _discard
* deep source
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-12-04 21:01:39 +00:00
Preston Van Loon
b68a4e12aa
Update bazel and other CI improvements ( #13246 )
...
* Update bazel to 6.4.0, review flags
* Remove problematic/slow targets
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-12-01 22:20:54 +00:00
Nishant Das
80526a1899
Verify Block Signatures On Insertion Into Pending Queue ( #13183 )
...
* add check for bad signatures via gossip
* edge case handled
2023-11-28 03:13:59 +00:00
Potuz
67d0b26a21
Accept block when error is only in logging ( #13223 )
...
* Accept block when error is only in logging
* linter shutup
* ignore nilerr on the linter
2023-11-24 19:00:53 +00:00
kasey
1123df7432
Verified roblobs ( #13190 )
...
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-11-21 18:44:38 +00:00
terence
4e3419e870
Enhance Validation for Block by Root RPC Requests ( #13184 )
...
* blk-by-root-check-root
* Account for gap
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-11-14 17:13:01 +00:00
terence
ac06362baf
Add a helper for max request block ( #13173 )
...
* Add a helper for max request block
* Add test
* Use deneb fork epoch from config
* Fix comment
2023-11-14 05:50:51 +00:00
Terence
7a6487b746
Remove pending blobs queue ( #13166 )
2023-11-03 07:07:43 -07:00
Terence
57eda1de63
Add RO blob sidecar ( #13144 )
2023-11-01 10:03:49 -07:00
Nishant Das
b56bf00682
Fix Pending Queue Deadline Bug ( #13145 )
...
* rearrange deadline
* naming
2023-10-31 06:40:41 +00:00
terencechain
cabf3476e7
Add context deadline for pending queue's receive block ( #13114 )
...
* Add context dead like for pending queue's receive block
* Use timeout
2023-10-25 19:40:17 +00:00
terencechain
b608c9f711
Log blob's kzg commmitment at sync ( #13111 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-25 16:27:19 +00:00
terencechain
cbf6a2752d
Reject Blob Sidecar Incorrect Index ( #13094 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-25 01:57:54 +00:00
Nishant Das
642458f037
Fix Pending Queue Expiration Bug ( #13104 )
...
* fix bug
* make test better
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-24 20:28:57 +00:00
terencechain
a2f60364ae
Check return and request lengths for blob sidecar by root ( #13106 )
2023-10-24 15:02:44 +00:00
terencechain
f55708b995
Fix blob sidecar subnet check ( #13102 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-23 23:08:25 +00:00
Nishant Das
f91efafe24
Fix Multivalue Slice Deadlock ( #13087 )
...
* fix deadlock
* gofmt
* lint
2023-10-21 17:08:52 +00:00
terencechain
9387a36b66
Refactor Exported Names to Follow Golang Best Practices ( #13075 )
...
* Fix exported names that start with a package name
* A few more renames
* Fix exported names that start with a package name
* A few more renames
* Radek's feedback
* Fix conflict
* fix keymanager test
* Fix comments
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-20 16:45:33 +00:00
Potuz
65ce27292c
sync only up to previous epoch on phase 1 ( #13083 )
...
Co-authored-by: Nishant Das <nishdas93@gmail.com>
2023-10-21 00:05:14 +08:00
terencechain
823f8ee3a2
Fix redundant type converstion ( #13076 )
...
* Fix redundant type converstion
* Revert generated changes
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-20 15:07:10 +00:00
Nishant Das
bc125a95ae
Set Verbosity of Goodbye Logs to Trace ( #13077 )
2023-10-19 03:49:34 +00:00
terencechain
4809da62cc
Passing block as arugment for sidecar validation ( #13062 )
2023-10-18 13:42:15 +00:00
terencechain
e10dbaa8b4
Use correct context for sendBatchRootRequest ( #13061 )
2023-10-18 05:58:44 -07:00
Delweng
71b08a50b7
beacon-chain/sync: fix some datarace in go test ( #13039 )
...
* beacon-chain/sync: adjust dataflow incase of datarace
Signed-off-by: jsvisa <delweng@gmail.com>
* beacon-chain/p2p: use atomic..Bool instead of bool
Signed-off-by: jsvisa <delweng@gmail.com>
* beacon-chain/sync: use channel to control concurrent
Signed-off-by: jsvisa <delweng@gmail.com>
* Revert "beacon-chain/sync: use channel to control concurrent"
This reverts commit 500d5b1ecdeef175e3a5970867d8176abd0763d7.
Signed-off-by: jsvisa <delweng@gmail.com>
* Revert "beacon-chain/sync: adjust dataflow incase of datarace"
This reverts commit 0c819e96cafb89ccba314ca98a8a0fdfcbb70b8c.
Signed-off-by: jsvisa <delweng@gmail.com>
* beacon-chain/sync: waitForChain is invoked inside registerHandlers
Signed-off-by: jsvisa <delweng@gmail.com>
* beacon-chain/sync: no need to registerHandler for waitForChainStart testcase
Signed-off-by: jsvisa <delweng@gmail.com>
* beacon-chain/sync: set p2p.Digest before goroutine
Signed-off-by: jsvisa <delweng@gmail.com>
---------
Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
2023-10-17 17:30:10 +00:00
terencechain
cb5ce74a23
Add pending blobs queue for missing parent block ( #13005 )
...
* Add pending blobs queue for missing parent block
* Prune sidecars older than previous slot
* Prune sidecar based on time
* Tests
* Fix state notifier
* Wait for chain to start
* Remove logs
* Remove bad logs
* James feedback
* Fix conflict
* Rm outdated check
* Potuz's feedback
* Kasey's feedback
* Use 11s mark
* Use secs
* Add pending blobs queue for missing parent block
* Prune sidecars older than previous slot
* Prune sidecar based on time
* Tests
* Fix state notifier
* Wait for chain to start
* Remove logs
* Remove bad logs
* James feedback
* Fix conflict
* Rm outdated check
* Potuz's feedback
* Kasey's feedback
* Use 11s mark
* Use secs
* Add test case for duplicates
* Radek's feedback
* Fix test
2023-10-17 14:42:15 +00:00
terencechain
58cdb29ef3
Verify blobs that arrived from by root request ( #13044 )
...
* Verify blobs that arrived from by root request
* Add tests
* Add tests
* Fix test
* Fix lint
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-16 05:30:33 +00:00
Potuz
806a394c89
Reject blobs with invalid parent ( #13047 )
...
* Reject blobs with invalid parent
* remove unused comment
2023-10-13 13:15:40 +00:00
terencechain
945b087ca9
Add more blob and block checks for by range ( #13043 )
...
* Add more blob and block checks for by range
* Update beacon-chain/sync/initial-sync/blocks_fetcher.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
* Update beacon-chain/sync/initial-sync/blocks_fetcher.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
* Update beacon-chain/sync/initial-sync/blocks_fetcher_test.go
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
---------
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
2023-10-12 19:35:32 +00:00
terencechain
867db1aeee
Exit early if blob by root request is empty ( #13038 )
2023-10-12 02:27:26 +00:00
terencechain
99843688cd
Request missing blobs while processing pending queue ( #13015 )
...
* Request missing blobs while processing pending queue
* Fix build
* Lower complexity
* Fix conflict
* Clean up per James's comment
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-11 22:07:11 +00:00
terencechain
c5501f8775
Refactor Pending Block Queue Logic in Sync Package ( #13026 )
...
* Clean up pending block queue
* Kasey's feedback
* Kasey's feedback on validateBeaconBlock err handling
* Clean up handleBlockProcessingError
* Clean up old comments
* James feedback
* has peer helper
* Reuse parent reoot
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-11 14:41:24 +00:00
terencechain
39072e1b74
Check block exists in pending queue before requesting from peer ( #13013 )
2023-10-09 10:35:15 -07:00
terencechain
66011d5d9c
Check blob exists before requesting from peer ( #13012 )
...
* Check blob exists before requesting from peer
* Potuz's feedback
* Fix err
* Add index check
2023-10-09 22:55:24 +08:00
Nishant Das
da6ae3c204
use read only head state ( #13014 )
2023-10-07 14:44:52 -05:00
Nishant Das
c1c0cd040c
Fix Initial Sync PreProcessing ( #13007 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-10-05 15:18:53 +00:00
terencechain
58c0899676
Don't mark block as bad in validateBeaconBlock for pending queue ( #12983 )
...
* Don't mark block as bad in validateBeaconBlock for pending queue
* Fix tests
2023-10-03 16:36:23 +00:00
Potuz
b4e72f1e19
Deneb spectests release v1.4.0-beta.2-hotfix ( #12959 )
...
* Update and use max per epoch churn limit
* Update spec tests
* Fix e2e test
* deneb fork epoch condition
* Fix lint and better casting
* fix ordering
* fix check
* gaz
* Fix more tests
* Apply proposer boost to first block in equivocation
* Increase timeout
* Don't increase timeout, it's not the reason
* implement deneb forkchoice spectests
expose ReceiveBlob from the blockchain package
* spin_off_helper
* remove minimal tests
* Terence's review
* Add process register test for Deneb
* Terence's suggestion
Co-authored-by: terencechain <terence@prysmaticlabs.com>
* fix forkchoice minimal
* fix minimal sha
* general sha
* different repos
* different repos
---------
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: nisdas <nishdas93@gmail.com>
2023-09-28 21:05:23 +00:00
Preston Van Loon
9a2c2470c6
db: Log a warning if the genesis state is smaller than 1Kb ( #12897 )
...
* Add warning with a small genesis state
* 1<<10 is 1Kb
* Add genesis state loading with hash information
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-09-23 15:29:15 +00:00
james-prysm
723f73795f
Deneb: blob sidecar events ( #12928 )
...
* adding in deneb blob event triggers
* fixing linting
* kasey's feedback
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-09-22 21:54:10 +00:00
Nishant Das
7247b8bd3c
Fix Unhandled Error ( #12938 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-09-21 16:23:56 +00:00
terencechain
0e5d299d02
Remove unused pending blobs queue ( #12913 )
...
* Remove pending blobs queue
* Fix tests
---------
Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
2023-09-20 17:00:01 +00:00
Nishant Das
398f44bb53
fix it ( #12917 )
2023-09-18 22:30:34 +08:00
Potuz
6b915bab26
Dont process blocks twice ( #12905 )
...
* keep track of block being synced
* gazelle
* use maps
* shutup deepsource
* change godoc
* Radek's review
* Do not process block twice if it's already being processed
* add unit test
2023-09-15 20:11:02 +00:00
Potuz
dd73f762ec
keep track of block being synced ( #12903 )
...
* keep track of block being synced
* gazelle
* use maps
* shutup deepsource
* change godoc
* Radek's review
2023-09-15 17:13:13 +00:00
terencechain
9bb81537c8
feat: add blob arrival gossip metric ( #12888 )
...
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-09-14 21:35:18 +00:00
terencechain
1e29877406
don't save blob sidecar syncing to head if 0 ( #12892 )
2023-09-14 13:17:49 +00:00
terencechain
35fc1c976f
Improved Logging for Blob Sidecar ( #12883 )
...
* feat: improve blob sidecar logs
* Kasey's feedback
2023-09-11 20:46:06 +00:00
terencechain
440cf32966
fix: correct blob sidecar count ( #12865 )
...
* fix: update blob sidecar count
* fix: use beacon config instead of network config
---------
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
2023-09-08 15:37:53 +00:00
kasey
809a67ebcc
reject blocks with more commitments than spec ( #12863 )
...
* reject blocks with more commitments than spec
* add details of excess commitments to error
* good catch, linter
---------
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
2023-09-07 20:21:03 +00:00
terencechain
2e3b013ae7
fix(sync/rpc): use blobs by root when requesting block ( #12837 )
...
* fix(sync/rpc): use blobs by root when requesting block
Fix: use blobs by root for pending block queue (option B)
* fix: skip htr if block is older than deneb
2023-09-06 13:52:42 +00:00
